Skip to content

Commit 2a01b5e

Browse files
author
maskara
committed
Remove empty test cases
1 parent 11034ae commit 2a01b5e

File tree

3 files changed

+5
-93
lines changed

3 files changed

+5
-93
lines changed

app/src/main/java/fr/free/nrw/commons/upload/FileProcessor.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public class FileProcessor implements SimilarImageDialogFragment.onResponse {
5050
FileProcessor() {
5151
}
5252

53-
public void initFileDetails(@NonNull String filePath, ContentResolver contentResolver) {
53+
void initFileDetails(@NonNull String filePath, ContentResolver contentResolver) {
5454
this.filePath = filePath;
5555
this.contentResolver = contentResolver;
5656
try {
@@ -78,10 +78,6 @@ GPSExtractor processFileCoordinates(SimilarImageInterface similarImageInterface)
7878
return imageObj;
7979
}
8080

81-
String getDecimalCoords() {
82-
return decimalCoords;
83-
}
84-
8581
/**
8682
* Find other images around the same location that were taken within the last 20 sec
8783
* @param similarImageInterface
@@ -135,7 +131,7 @@ private void findOtherImages(SimilarImageInterface similarImageInterface) {
135131
* Then initiates the calls to MediaWiki API through an instance of CategoryApi.
136132
*/
137133
@SuppressLint("CheckResult")
138-
public void useImageCoords() {
134+
private void useImageCoords() {
139135
if (decimalCoords != null) {
140136
Timber.d("Decimal coords of image: %s", decimalCoords);
141137
Timber.d("is EXIF data present:" + imageObj.imageCoordsExists + " from findOther image");

app/src/test/kotlin/fr/free/nrw/commons/upload/FileProcessorTest.kt

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
package fr.free.nrw.commons.upload
22

3+
import android.content.ContentResolver
34
import android.content.SharedPreferences
45
import fr.free.nrw.commons.caching.CacheController
56
import fr.free.nrw.commons.mwapi.CategoryApi
67
import org.junit.Before
78
import org.junit.Test
89
import org.mockito.InjectMocks
910
import org.mockito.Mock
11+
import org.mockito.Mockito.anyString
12+
import org.mockito.Mockito.mock
1013
import org.mockito.MockitoAnnotations
1114
import javax.inject.Inject
1215
import javax.inject.Named
@@ -33,13 +36,6 @@ class FileProcessorTest {
3336

3437
@Test
3538
fun processFileCoordinates() {
36-
}
3739

38-
@Test
39-
fun getDecimalCoords() {
40-
}
41-
42-
@Test
43-
fun useImageCoords() {
4440
}
4541
}

app/src/test/kotlin/fr/free/nrw/commons/upload/UploadPresenterTest.kt

-80
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import org.junit.Test
77
import org.mockito.InjectMocks
88
import org.mockito.Mock
99
import org.mockito.Mockito
10-
import org.mockito.Mockito.`when`
11-
import org.mockito.Mockito.mock
1210
import org.mockito.MockitoAnnotations
1311

1412
class UploadPresenterTest {
@@ -49,82 +47,4 @@ class UploadPresenterTest {
4947
uploadModel!!.receiveDirect(element, "image/jpeg", "external", "Q1", "Test", "Test"
5048
) { _, _ -> }
5149
}
52-
53-
@Test
54-
fun selectLicense() {
55-
56-
}
57-
58-
@Test
59-
fun handleNext() {
60-
61-
}
62-
63-
@Test
64-
fun handleCategoryNext() {
65-
}
66-
67-
@Test
68-
fun getCurrentImageFileName() {
69-
}
70-
71-
@Test
72-
fun handlePrevious() {
73-
}
74-
75-
@Test
76-
fun thumbnailClicked() {
77-
}
78-
79-
@Test
80-
fun handleSubmit() {
81-
}
82-
83-
@Test
84-
fun openCoordinateMap() {
85-
}
86-
87-
@Test
88-
fun keepPicture() {
89-
}
90-
91-
@Test
92-
fun deletePicture() {
93-
}
94-
95-
@Test
96-
fun toggleTopCardState() {
97-
}
98-
99-
@Test
100-
fun toggleBottomCardState() {
101-
}
102-
103-
@Test
104-
fun toggleRightCardState() {
105-
}
106-
107-
@Test
108-
fun closeAllCards() {
109-
}
110-
111-
@Test
112-
fun init() {
113-
}
114-
115-
@Test
116-
fun cleanup() {
117-
}
118-
119-
@Test
120-
fun removeView() {
121-
}
122-
123-
@Test
124-
fun addView() {
125-
}
126-
127-
@Test
128-
fun getImageTitleList() {
129-
}
13050
}

0 commit comments

Comments
 (0)