Fix crash because of inactive fragment UI (#2046)

maskaravivek · misaochan · commit 36e077f0b151 · 2018-12-05T18:09:08.000+10:00
* Fix crash because of inactive fragment UI

* Add java docs
diff --git a/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java b/app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java
@@ -64,7 +64,7 @@ protected void showBlockStatus()
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .filter(result -> result)
-                .subscribe(result -> ViewUtil.showSnackbar(findViewById(android.R.id.content), R.string.block_notification)
+                .subscribe(result -> ViewUtil.showShortSnackbar(findViewById(android.R.id.content), R.string.block_notification)
                 );
     }
 }
diff --git a/app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesFragment.java b/app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesFragment.java
@@ -129,7 +129,7 @@ private void handleNoInternet() {
             statusTextView.setVisibility(VISIBLE);
             statusTextView.setText(getString(R.string.no_internet));
         } else {
-            ViewUtil.showSnackbar(parentLayout, R.string.no_internet);
+            ViewUtil.showShortSnackbar(parentLayout, R.string.no_internet);
         }
     }
 
@@ -140,7 +140,7 @@ private void handleNoInternet() {
     private void handleError(Throwable throwable) {
         Timber.e(throwable, "Error occurred while loading images inside a category");
         try{
-            ViewUtil.showSnackbar(parentLayout, R.string.error_loading_images);
+            ViewUtil.showShortSnackbar(parentLayout, R.string.error_loading_images);
             initErrorView();
         }catch (Exception e){
             e.printStackTrace();
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java b/app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java
@@ -124,7 +124,7 @@ private void handleNoInternet() {
             statusTextView.setVisibility(VISIBLE);
             statusTextView.setText(getString(R.string.no_internet));
         } else {
-            ViewUtil.showSnackbar(parentLayout, R.string.no_internet);
+            ViewUtil.showShortSnackbar(parentLayout, R.string.no_internet);
         }
     }
 
@@ -135,7 +135,7 @@ private void handleNoInternet() {
     private void handleError(Throwable throwable) {
         Timber.e(throwable, "Error occurred while loading images inside a category");
         try{
-            ViewUtil.showSnackbar(parentLayout, R.string.error_loading_images);
+            ViewUtil.showShortSnackbar(parentLayout, R.string.error_loading_images);
             initErrorView();
         }catch (Exception e){
             e.printStackTrace();
diff --git a/app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java b/app/src/main/java/fr/free/nrw/commons/category/SubCategoryListFragment.java
@@ -135,10 +135,10 @@ private void handleSuccess(List<String> subCategoryList) {
     private void handleError(Throwable throwable) {
         if (!isParentCategory){
             Timber.e(throwable, "Error occurred while loading queried subcategories");
-            ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
+            ViewUtil.showShortSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
         }else {
             Timber.e(throwable, "Error occurred while loading queried parentcategories");
-            ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
+            ViewUtil.showShortSnackbar(categoriesRecyclerView,R.string.error_loading_categories);
         }
     }
 
@@ -161,6 +161,6 @@ private void initEmptyView() {
      */
     private void handleNoInternet() {
         progressBar.setVisibility(GONE);
-        ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);
+        ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.no_internet);
     }
 }
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java
@@ -196,7 +196,7 @@ private void handleError(Throwable throwable) {
         Timber.e(throwable, "Error occurred while loading queried categories");
         try {
             initErrorView();
-            ViewUtil.showSnackbar(categoriesRecyclerView, R.string.error_loading_categories);
+            ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.error_loading_categories);
         }catch (Exception e){
             e.printStackTrace();
         }
@@ -217,6 +217,6 @@ private void initErrorView() {
      */
     private void handleNoInternet() {
         progressBar.setVisibility(GONE);
-        ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);
+        ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.no_internet);
     }
 }
diff --git a/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java b/app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java
@@ -206,7 +206,7 @@ private void handleSuccess(List<Media> mediaList) {
     private void handleError(Throwable throwable) {
         Timber.e(throwable, "Error occurred while loading queried images");
         try {
-            ViewUtil.showSnackbar(imagesRecyclerView, R.string.error_loading_images);
+            ViewUtil.showShortSnackbar(imagesRecyclerView, R.string.error_loading_images);
         }catch (Exception e){
             e.printStackTrace();
         }
@@ -226,7 +226,7 @@ private void initErrorView() {
      */
     private void handleNoInternet() {
         progressBar.setVisibility(GONE);
-        ViewUtil.showSnackbar(imagesRecyclerView, R.string.no_internet);
+        ViewUtil.showShortSnackbar(imagesRecyclerView, R.string.no_internet);
     }
 
     /**
diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java
@@ -15,7 +15,6 @@
 import android.support.v4.app.FragmentTransaction;
 import android.support.v7.app.AlertDialog;
 import android.view.LayoutInflater;
-
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.LinearLayout;
@@ -37,6 +36,7 @@
 import fr.free.nrw.commons.location.LatLng;
 import fr.free.nrw.commons.location.LocationServiceManager;
 import fr.free.nrw.commons.location.LocationUpdateListener;
+import fr.free.nrw.commons.utils.FragmentUtils;
 import fr.free.nrw.commons.utils.NetworkUtils;
 import fr.free.nrw.commons.utils.UriSerializer;
 import fr.free.nrw.commons.utils.ViewUtil;
@@ -323,7 +323,7 @@ private void populatePlaces(NearbyController.NearbyPlacesInfo nearbyPlacesInfo)
         String gsonBoundaryCoordinates = gson.toJson(boundaryCoordinates);
 
         if (placeList.size() == 0) {
-            ViewUtil.showSnackbar(view.findViewById(R.id.container), R.string.no_nearby);
+            ViewUtil.showShortSnackbar(view.findViewById(R.id.container), R.string.no_nearby);
         }
 
         bundle.putString("PlaceList", gsonPlaceList);
@@ -591,14 +591,17 @@ private void showErrorMessage(String message) {
     }
 
     private void addNetworkBroadcastReceiver() {
+        if (!FragmentUtils.isFragmentUIActive(this)) {
+            return;
+        }
+        
         IntentFilter intentFilter = new IntentFilter(NETWORK_INTENT_ACTION);
-            snackbar = Snackbar.make(transparentView , R.string.no_internet, Snackbar.LENGTH_INDEFINITE);
-
-            broadcastReceiver = new BroadcastReceiver() {
+        snackbar = Snackbar.make(transparentView, R.string.no_internet, Snackbar.LENGTH_INDEFINITE);
 
+        broadcastReceiver = new BroadcastReceiver() {
             @Override
             public void onReceive(Context context, Intent intent) {
-                if (snackbar != null) {
+                if (snackbar != null && getActivity() != null) {
                     if (NetworkUtils.isInternetConnectionEstablished(getActivity())) {
                         refreshView(LOCATION_SIGNIFICANTLY_CHANGED);
                         snackbar.dismiss();
@@ -609,6 +612,10 @@ public void onReceive(Context context, Intent intent) {
             }
         };
 
+        if (getActivity() == null) {
+            return;
+        }
+
         getActivity().registerReceiver(broadcastReceiver, intentFilter);
 
     }
diff --git a/app/src/main/java/fr/free/nrw/commons/notification/NotificationActivity.java b/app/src/main/java/fr/free/nrw/commons/notification/NotificationActivity.java
@@ -106,7 +106,7 @@ private void addNotifications() {
                         progressBar.setVisibility(View.GONE);
                     }, throwable -> {
                         Timber.e(throwable, "Error occurred while loading notifications");
-                        ViewUtil.showSnackbar(relativeLayout, R.string.error_notifications);
+                        ViewUtil.showShortSnackbar(relativeLayout, R.string.error_notifications);
                         progressBar.setVisibility(View.GONE);
                     });
         } else {
@@ -123,7 +123,7 @@ private void handleUrl(String url) {
 
     private void setAdapter(List<Notification> notificationList) {
         if (notificationList == null || notificationList.isEmpty()) {
-            ViewUtil.showSnackbar(relativeLayout, R.string.no_notifications);
+            ViewUtil.showShortSnackbar(relativeLayout, R.string.no_notifications);
             return;
         }
         notificationAdapterFactory = new NotificationAdapterFactory(notification -> {
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/FragmentUtils.java b/app/src/main/java/fr/free/nrw/commons/utils/FragmentUtils.java
@@ -28,4 +28,13 @@ public static boolean addAndCommitFragmentWithImmediateExecution(
         }
         return false;
     }
+
+    /**
+     * Utility function to check whether the fragment UI is still active or not
+     * @param fragment
+     * @return
+     */
+    public static boolean isFragmentUIActive(Fragment fragment) {
+        return fragment.getActivity() != null && fragment.isAdded() && !fragment.isDetached() && !fragment.isRemoving();
+    }
 }
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/NetworkUtils.java b/app/src/main/java/fr/free/nrw/commons/utils/NetworkUtils.java
@@ -11,6 +11,9 @@ public static boolean isInternetConnectionEstablished(Context context) {
         ConnectivityManager cm =
                 (ConnectivityManager)context.getApplicationContext().getSystemService(Context.CONNECTIVITY_SERVICE);
 
+        if (cm == null) {
+            return false;
+        }
         NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
         return activeNetwork != null &&
                 activeNetwork.isConnectedOrConnecting();
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/ViewUtil.java b/app/src/main/java/fr/free/nrw/commons/utils/ViewUtil.java
@@ -17,7 +17,12 @@ public class ViewUtil {
     public static final String SHOWCASE_VIEW_ID_2 = "SHOWCASE_VIEW_ID_2";
     public static final String SHOWCASE_VIEW_ID_3 = "SHOWCASE_VIEW_ID_3";
 
-    public static void showSnackbar(View view, int messageResourceId) {
+    /**
+     * Utility function to show short snack bar
+     * @param view
+     * @param messageResourceId
+     */
+    public static void showShortSnackbar(View view, int messageResourceId) {
         if (view.getContext() == null) {
             return;
         }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ protected void showBlockStatus()`
`64`	`64`	`.subscribeOn(Schedulers.io())`
`65`	`65`	`.observeOn(AndroidSchedulers.mainThread())`
`66`	`66`	`.filter(result -> result)`
`67`		`- .subscribe(result -> ViewUtil.showSnackbar(findViewById(android.R.id.content), R.string.block_notification)`
	`67`	`+ .subscribe(result -> ViewUtil.showShortSnackbar(findViewById(android.R.id.content), R.string.block_notification)`
`68`	`68`	`);`
`69`	`69`	`}`
`70`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,10 +135,10 @@ private void handleSuccess(List<String> subCategoryList) {`
`135`	`135`	`private void handleError(Throwable throwable) {`
`136`	`136`	`if (!isParentCategory){`
`137`	`137`	`Timber.e(throwable, "Error occurred while loading queried subcategories");`
`138`		`- ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);`
	`138`	`+ ViewUtil.showShortSnackbar(categoriesRecyclerView,R.string.error_loading_categories);`
`139`	`139`	`}else {`
`140`	`140`	`Timber.e(throwable, "Error occurred while loading queried parentcategories");`
`141`		`- ViewUtil.showSnackbar(categoriesRecyclerView,R.string.error_loading_categories);`
	`141`	`+ ViewUtil.showShortSnackbar(categoriesRecyclerView,R.string.error_loading_categories);`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`@@ -161,6 +161,6 @@ private void initEmptyView() {`
`161`	`161`	`*/`
`162`	`162`	`private void handleNoInternet() {`
`163`	`163`	`progressBar.setVisibility(GONE);`
`164`		`- ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);`
	`164`	`+ ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.no_internet);`
`165`	`165`	`}`
`166`	`166`	`}`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ private void handleError(Throwable throwable) {`
`196`	`196`	`Timber.e(throwable, "Error occurred while loading queried categories");`
`197`	`197`	`try {`
`198`	`198`	`initErrorView();`
`199`		`- ViewUtil.showSnackbar(categoriesRecyclerView, R.string.error_loading_categories);`
	`199`	`+ ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.error_loading_categories);`
`200`	`200`	`}catch (Exception e){`
`201`	`201`	`e.printStackTrace();`
`202`	`202`	`}`
`@@ -217,6 +217,6 @@ private void initErrorView() {`
`217`	`217`	`*/`
`218`	`218`	`private void handleNoInternet() {`
`219`	`219`	`progressBar.setVisibility(GONE);`
`220`		`- ViewUtil.showSnackbar(categoriesRecyclerView, R.string.no_internet);`
	`220`	`+ ViewUtil.showShortSnackbar(categoriesRecyclerView, R.string.no_internet);`
`221`	`221`	`}`
`222`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,4 +28,13 @@ public static boolean addAndCommitFragmentWithImmediateExecution(`
`28`	`28`	`}`
`29`	`29`	`return false;`
`30`	`30`	`}`
	`31`	`+`
	`32`	`+ /**`
	`33`	`+ * Utility function to check whether the fragment UI is still active or not`
	`34`	`+ * @param fragment`
	`35`	`+ * @return`
	`36`	`+ */`
	`37`	`+ public static boolean isFragmentUIActive(Fragment fragment) {`
	`38`	`+ return fragment.getActivity() != null && fragment.isAdded() && !fragment.isDetached() && !fragment.isRemoving();`
	`39`	`+ }`
`31`	`40`	`}`