Skip to content

Commit 39cb190

Browse files
authored
Fix #3416 Add snackbar on clicking add/remove from bookmarks (#3419)
1 parent d423dbb commit 39cb190

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import androidx.fragment.app.FragmentStatePagerAdapter;
2121
import androidx.viewpager.widget.ViewPager;
2222

23+
import com.google.android.material.snackbar.Snackbar;
24+
2325
import javax.inject.Inject;
2426
import javax.inject.Named;
2527

@@ -148,7 +150,9 @@ public boolean onOptionsItemSelected(MenuItem item) {
148150
Media m = provider.getMediaAtPosition(pager.getCurrentItem());
149151
switch (item.getItemId()) {
150152
case R.id.menu_bookmark_current_image:
151-
bookmarkDao.updateBookmark(bookmark);
153+
boolean bookmarkExists = bookmarkDao.updateBookmark(bookmark);
154+
Snackbar snackbar = bookmarkExists ? Snackbar.make(getView(), R.string.add_bookmark, Snackbar.LENGTH_LONG) : Snackbar.make(getView(), R.string.remove_bookmark, Snackbar.LENGTH_LONG);
155+
snackbar.show();
152156
updateBookmarkState(item);
153157
return true;
154158
case R.id.menu_share_current_image:

app/src/main/res/values/strings.xml

+2
Original file line numberDiff line numberDiff line change
@@ -591,4 +591,6 @@ Upload your first media by tapping on the add button.</string>
591591

592592
<string name="upload_nearby_place_found_title">Nearby Place Found</string>
593593
<string name="upload_nearby_place_found_description">Is this a photo of Place %1$s?</string>
594+
<string name="remove_bookmark">Removed from bookmarks</string>
595+
<string name="add_bookmark">Added to bookmarks</string>
594596
</resources>

0 commit comments

Comments
 (0)