Fix issue 3137 (#3637)

* Fix issue 3137

* Remove import Timber

* Remove unnecessary space

Author: vvijayalakshmi21

app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragment.java

@@ -147,6 +147,7 @@ public void updateDepictionList(String query) {
      */
     @Override
     public void initErrorView() {
+        isLoading = false;
         progressBar.setVisibility(GONE);
         bottomProgressBar.setVisibility(GONE);
         depictionNotFound.setVisibility(VISIBLE);
@@ -195,10 +196,11 @@ public void onSuccess(List<DepictedItem> mediaList) {
     }
 
     @Override
-    public void loadingDepictions() {
+    public void loadingDepictions(boolean isLoading) {
         depictionNotFound.setVisibility(GONE);
         bottomProgressBar.setVisibility(View.VISIBLE);
         progressBar.setVisibility(GONE);
+        this.isLoading = isLoading;
     }
 
     @Override

app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragmentContract.java

@@ -32,7 +32,7 @@ interface View {
         /**
          * load depictions
          */
-        void loadingDepictions();
+        void loadingDepictions(boolean isLoading);
 
         /**
          * clear adapter

app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragmentPresenter.java

@@ -82,19 +82,19 @@ public void onDetachView() {
      */
     @Override
     public void updateDepictionList(String query, int pageSize, boolean reInitialise) {
-        this.query = query;
-        view.loadingDepictions();
-        if (reInitialise) {
-            size = 0;
-        }
-        saveQuery();
-        compositeDisposable.add(depictsClient.searchForDepictions(query, 25, offset)
-                .subscribeOn(ioScheduler)
-                .observeOn(mainThreadScheduler)
-                .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
-                .doOnSubscribe(disposable -> saveQuery())
-                .collect(ArrayList<DepictedItem>::new, ArrayList::add)
-                .subscribe(this::handleSuccess, this::handleError));
+      this.query = query;
+      view.loadingDepictions(true);
+      if (reInitialise) {
+        size = 0;
+      }
+      saveQuery();
+      compositeDisposable.add(depictsClient.searchForDepictions(query, 25, offset)
+            .subscribeOn(ioScheduler)
+            .observeOn(mainThreadScheduler)
+            .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+            .doOnSubscribe(disposable -> saveQuery())
+            .collect(ArrayList<DepictedItem>::new, ArrayList::add)
+            .subscribe(this::handleSuccess, this::handleError));
     }
 
     /**