Replaced Mapbox with osmdroid (Nearby activity) (#5403)

* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

Author: kanahia1

.idea/codeStyles/Project.xml

@@ -161,6 +161,8 @@ dependencies {
 
     implementation("io.github.coordinates2country:coordinates2country-android:1.3") {  exclude group: 'com.google.android', module: 'android' }
 
+    //OSMDroid
+    implementation ("org.osmdroid:osmdroid-android:$OSMDROID_VERSION")
     constraints {
         implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.0") {
             because("kotlin-stdlib-jdk7 is now a part of kotlin-stdlib")

app/build.gradle

@@ -1,57 +1,84 @@
 package fr.free.nrw.commons.nearby.contract;
 
 import android.content.Context;
-
 import androidx.annotation.Nullable;
 import com.mapbox.mapboxsdk.annotations.Marker;
-
-import fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType;
-import java.util.List;
-
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.location.LatLng;
+import fr.free.nrw.commons.location.LocationServiceManager.LocationChangeType;
 import fr.free.nrw.commons.nearby.Label;
 import fr.free.nrw.commons.nearby.NearbyBaseMarker;
 import fr.free.nrw.commons.nearby.Place;
+import java.util.List;
 
 public interface NearbyParentFragmentContract {
 
     interface View {
+
         boolean isNetworkConnectionEstablished();
+
         void listOptionMenuItemClicked();
+
         void populatePlaces(LatLng curlatLng);
+
         void populatePlaces(LatLng curlatLng, String customQuery);
+
         boolean isListBottomSheetExpanded();
+
         void checkPermissionsAndPerformAction();
+
         void displayLoginSkippedWarning();
+
         void setFABPlusAction(android.view.View.OnClickListener onClickListener);
+
         void setFABRecenterAction(android.view.View.OnClickListener onClickListener);
+
         void animateFABs();
+
         void recenterMap(LatLng curLatLng);
+
         void showLocationOffDialog();
+
         void openLocationSettings();
+
         void hideBottomSheet();
+
         void hideBottomDetailsSheet();
+
         void displayBottomSheetWithInfo(Marker marker);
-        void addOnCameraMoveListener();
+
         void addSearchThisAreaButtonAction();
+
         void setSearchThisAreaButtonVisibility(boolean isVisible);
+
         void setProgressBarVisibility(boolean isVisible);
+
         void setTabItemContributions();
+
         boolean isDetailsBottomSheetVisible();
+
         void setBottomSheetDetailsSmaller();
-        boolean isSearchThisAreaButtonVisible();
+
         void setRecyclerViewAdapterAllSelected();
+
         void setRecyclerViewAdapterItemsGreyedOut();
+
         void setCheckBoxAction();
+
         void setCheckBoxState(int state);
+
         void setFilterState();
+
         void disableFABRecenter();
+
         void enableFABRecenter();
+
         void addCurrentLocationMarker(LatLng curLatLng);
 
         void updateMapToTrackPosition(LatLng curLatLng);
 
+        void clearAllMarkers();
+
         Context getContext();
 
         void updateMapMarkers(List<NearbyBaseMarker> nearbyBaseMarkers, Marker selectedMarker);
@@ -60,7 +87,9 @@ interface View {
 
         void displayAllMarkers();
 
-        void filterMarkersByLabels(List<Label> selectedLabels, boolean existsSelected, boolean needPhotoSelected, boolean wlmSelected, boolean filterForPlaceState, boolean filterForAllNoneType);
+        void filterMarkersByLabels(List<Label> selectedLabels, boolean existsSelected,
+            boolean needPhotoSelected, boolean wlmSelected, boolean filterForPlaceState,
+            boolean filterForAllNoneType);
 
         LatLng getCameraTarget();
 
@@ -70,10 +99,15 @@ interface View {
 
         LatLng getLastLocation();
 
+        LatLng getLastMapFocus();
+
+        LatLng getMapCenter();
+
+        LatLng getMapFocus();
+
         com.mapbox.mapboxsdk.geometry.LatLng getLastFocusLocation();
 
         boolean isCurrentLocationMarkerVisible();
-        void setProjectorLatLngBounds();
 
         boolean isAdvancedQueryFragmentVisible();
 
@@ -83,26 +117,35 @@ interface View {
     }
 
     interface NearbyListView {
+
         void updateListFragment(List<Place> placeList);
     }
 
     interface UserActions {
+
         void updateMapAndList(LocationChangeType locationChangeType);
+
         void lockUnlockNearby(boolean isNearbyLocked);
 
         void attachView(View view);
 
         void detachView();
 
         void setActionListeners(JsonKvStore applicationKvStore);
+
         void removeNearbyPreferences(JsonKvStore applicationKvStore);
+
         boolean backButtonClicked();
+
         void onCameraMove(com.mapbox.mapboxsdk.geometry.LatLng latLng);
-        void filterByMarkerType(List<Label> selectedLabels, int state, boolean filterForPlaceState, boolean filterForAllNoneType);
+
+        void filterByMarkerType(List<Label> selectedLabels, int state, boolean filterForPlaceState,
+            boolean filterForAllNoneType);
 
         void updateMapMarkersToController(List<NearbyBaseMarker> nearbyBaseMarkers);
 
         void searchViewGainedFocus();
+
         void setCheckboxUnknown();
 
         void setAdvancedQuery(String query);