CategoriesModel: make category search case-insensitive

Author: kbhardwaj123

app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.java

@@ -123,8 +123,9 @@ public Observable<CategoryItem> searchAll(String term, List<String> imageTitleLi
         }
 
         //otherwise, search API for matching categories
+        //term passed as lower case to make search case-insensitive(taking only lower case for everything)
         return categoryClient
-                .searchCategoriesForPrefix(term, SEARCH_CATS_LIMIT)
+                .searchCategoriesForPrefix(term.toLowerCase(), SEARCH_CATS_LIMIT)
                 .map(name -> new CategoryItem(name, false));
     }
 
@@ -183,11 +184,12 @@ private Observable<CategoryItem> titleCategories(List<String> titleList) {
 
     /**
      * Return category for single title
+     * title is converted to lower case to make search case-insensitive
      * @param title
      * @return
      */
     private Observable<CategoryItem> getTitleCategories(String title) {
-        return categoryClient.searchCategories(title, SEARCH_CATS_LIMIT)
+        return categoryClient.searchCategories(title.toLowerCase(), SEARCH_CATS_LIMIT)
                 .map(name -> new CategoryItem(name, false));
     }
 

app/src/main/java/fr/free/nrw/commons/category/CategoryClient.java

@@ -30,15 +30,14 @@ public CategoryClient(CategoryInterface CategoryInterface) {
 
     /**
      * Searches for categories containing the specified string.
-     * It will be converted to Lower Case as the server performs Case-insensitive search.
      *
      * @param filter    The string to be searched
      * @param itemLimit How many results are returned
      * @param offset    Starts returning items from the nth result. If offset is 9, the response starts with the 9th item of the search result
      * @return
      */
     public Observable<String> searchCategories(String filter, int itemLimit, int offset) {
-        return responseToCategoryName(CategoryInterface.searchCategories(filter.toLowerCase(), itemLimit, offset));
+        return responseToCategoryName(CategoryInterface.searchCategories(filter, itemLimit, offset));
 
     }
 
@@ -56,15 +55,14 @@ public Observable<String> searchCategories(String filter, int itemLimit) {
 
     /**
      * Searches for categories starting with the specified string.
-     * It will be converted to Lower Case as the server performs Case-insensitive search.
      *
      * @param prefix    The prefix to be searched
      * @param itemLimit How many results are returned
      * @param offset    Starts returning items from the nth result. If offset is 9, the response starts with the 9th item of the search result
      * @return
      */
     public Observable<String> searchCategoriesForPrefix(String prefix, int itemLimit, int offset) {
-        return responseToCategoryName(CategoryInterface.searchCategoriesForPrefix(prefix.toLowerCase(), itemLimit, offset));
+        return responseToCategoryName(CategoryInterface.searchCategoriesForPrefix(prefix, itemLimit, offset));
     }
 
     /**