Skip to content

Commit 628a605

Browse files
authored
#3529 Captions/depictions are not saved to Commons (#3588)
* #3529 Captions/depictions are not saved to Commons - update flow to update appropriate data * #3529 Captions/depictions are not saved to Commons - fix invoking of setlabel * #3529 Captions/depictions are not saved to Commons - fix unit tests * #3529 Captions/depictions are not saved to Commons - use constant for @nAmed * #3529 Captions/depictions are not saved to Commons - remove captions interface * #3529 Captions/depictions are not saved to Commons - delete unused Contribution fields - enforce Single Responsibility by using PageContentsCreator * #3529 Captions/depictions are not saved to Commons - prefix id with M - remove language from url and only add from Field * #3529 Captions/depictions are not saved to Commons - make edits of depictions and captions sequential * #3529 Captions/depictions are not saved to Commons - remove unused model fields * #3529 Captions/depictions are not saved to Commons - weaken type of categories - copy list on Contribution creation * #3529 Captions/depictions are not saved to Commons - mark Media fields private - weaken types - remove partly implemented fields * #3529 Captions/depictions are not saved to Commons - add semi colon * #3529 Captions/depictions are not saved to Commons - fix test
1 parent 3f6d26c commit 628a605

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+897
-1243
lines changed

app/src/main/java/fr/free/nrw/commons/Media.java

Lines changed: 69 additions & 185 deletions
Large diffs are not rendered by default.

app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ private Media combineToMedia(final Media media, final Boolean deletionStatus, fi
5555
final String caption, final JsonObject depiction) {
5656
media.setDiscussion(discussion);
5757
media.setCaption(caption);
58-
media.setDepiction(formatDepictions(depiction));
58+
media.setDepictionList(formatDepictions(depiction));
5959
if (deletionStatus) {
60-
media.setRequestedDeletion();
60+
media.setRequestedDeletion(true);
6161
}
6262
return media;
6363
}

0 commit comments

Comments
 (0)