Skip to content

Commit 755d831

Browse files
authored
Make some hardcoded strings translatable (#6459)
1 parent b6457cc commit 755d831

File tree

5 files changed

+9
-3
lines changed

5 files changed

+9
-3
lines changed

app/src/main/res/layout/activity_quiz.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
android:layout_alignParentRight="true"
7272
android:layout_marginLeft="@dimen/activity_margin_horizontal"
7373
android:layout_marginRight="@dimen/activity_margin_horizontal"
74-
android:text="I am not sure"
74+
android:text="@string/quiz_i_am_not_sure"
7575
android:backgroundTint="#D6DCE0"
7676
android:layout_marginBottom="@dimen/activity_margin_vertical" />
7777

app/src/main/res/layout/activity_quiz_result.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
android:paddingHorizontal="@dimen/activity_margin_horizontal"
9999
android:layout_height="wrap_content"
100100
android:backgroundTint="#D6DCE0"
101-
android:text="Continue" />
101+
android:text="@string/quiz_continue" />
102102

103103
</RelativeLayout>
104104
</ScrollView>

app/src/main/res/layout/activity_upload_categories_dialog.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
android:id="@+id/categories_checkbox"
1212
android:layout_width="match_parent"
1313
android:layout_height="wrap_content"
14-
android:text="Don't show this message again" />
14+
android:text="@string/upload_categories_dont_show_this_message_again" />
1515

1616
</LinearLayout>

app/src/main/res/values-qq/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@
173173
<string name="explore_tab_title_map">{{Identical|Map}}</string>
174174
<string name="successful_wikidata_edit">Message shown in a dialog (\"success toast\") after a contribution by the user.\n\nParameter:\n* %1$s - title of the target page on Wikidata</string>
175175
<string name="question">{{Identical|Question}}</string>
176+
<string name="quiz_i_am_not_sure">In the quiz, a third option in addition to "Yes" and "No".</string>
176177
<string name="result">{{Identical|Result}}</string>
178+
<string name="quiz_continue">Button in quiz.</string>
177179
<string name="delete">{{Identical|Delete}}</string>
178180
<string name="statistics">Èstatistik</string>
179181
<string name="statistics_featured">To see the correct translation for your language, please go to https://commons.wikimedia.org/wiki/Commons:Featured_pictures and select your language in \"This project page in other languages\".</string>
@@ -190,6 +192,7 @@
190192
<string name="please_wait">{{Identical|Please wait}}</string>
191193
<string name="exif_tag_name_author">{{Identical|Author}}</string>
192194
<string name="exif_tag_name_location">{{Identical|Location}}</string>
195+
<string name="upload_categories_dont_show_this_message_again">A label of a checkbox.</string>
193196
<string name="no_depiction_found">{{Doc-commons-app-depicts}}</string>
194197
<string name="depictions_edit_helper_make_edit_toast">{{Doc-commons-app-depicts}}</string>
195198
<string name="depictions_edit_helper_show_edit_title">{{Doc-commons-app-depicts}}</string>

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@
348348
<string name="quiz">Quiz</string>
349349
<string name="quiz_question_string">Is this picture OK to upload?</string>
350350
<string name="question">Question</string>
351+
<string name="quiz_i_am_not_sure">I am not sure</string>
351352
<string name="result">Result</string>
352353
<string name="quiz_back_button">If you carry on uploading images that require deletion, your account will likely be banned. Are you sure you want to end the quiz?</string>
353354
<string name="quiz_alert_message">More than %1$s of the images you uploaded have been deleted. If you carry on uploading images that require deletion, your account will likely be banned.\n\nWould you like to view the tutorial again and then take a quiz to help you learn what type of images you should or shouldn\'t upload?</string>
@@ -357,6 +358,7 @@
357358
<string name="blurry_image_answer">One of the goals of Commons is to gather quality images. Therefore, blurry images shouldn\'t be uploaded. Always try to take nice pictures with good lighting.</string>
358359
<string name="construction_event_answer">Pictures showing technology or culture are very welcome on Commons.</string>
359360
<string name="congratulatory_message_quiz">You got %1$s of the answers correct. Congratulations!</string>
361+
<string name="quiz_continue">Continue</string>
360362
<string name="warning_for_no_answer">Select one of the two options to answer the question</string>
361363
<string name="user_not_logged_in">Log-in expired. Please log in again.</string>
362364
<string name="quiz_result_share_message">Share your quiz with your friends!</string>
@@ -555,6 +557,7 @@ Upload your first media by tapping on the add button.</string>
555557
<string name="share_text">Upload photos to Wikimedia Commons directly from your phone. Download the Commons App now: %1$s</string>
556558
<string name="share_via">Share app via...</string>
557559
<string name="image_info">Image Info</string>
560+
<string name="upload_categories_dont_show_this_message_again">Don\'t show this message again</string>
558561
<string name="no_categories_found">No Categories found</string>
559562
<string name="no_depiction_found">No Depictions found</string>
560563
<string name="upload_cancelled">Cancelled Upload</string>

0 commit comments

Comments
 (0)