Fix #3792 Missing Column Issue (#4468)

madhurgupta10 · web-flow · commit 7a74549b59cc · 2021-06-21T14:01:00.000+10:00
* Fix Missing Column Issue

* Fix tests
diff --git a/app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsDao.java b/app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsDao.java
@@ -284,22 +284,22 @@ public static void onUpdate(SQLiteDatabase db, int from, int to) {
                 }
                 return;
             }
-            if (from == 12) {
+            if (from >= 12) {
                 try {
                     db.execSQL(
                         "ALTER TABLE bookmarksLocations ADD COLUMN location_destroyed STRING;");
                 } catch (SQLiteException exception) {
                     Timber.e(exception);
                 }
             }
-            if (from == 13){
+            if (from >= 13){
                 try {
                     db.execSQL("ALTER TABLE bookmarksLocations ADD COLUMN location_language STRING;");
                 } catch (SQLiteException exception){
                     Timber.e(exception);
                 }
             }
-            if (from == 14){
+            if (from >= 14){
                 try {
                     db.execSQL("ALTER TABLE bookmarksLocations ADD COLUMN location_exists STRING;");
                 } catch (SQLiteException exception){

Original file line number	Diff line number	Diff line change
`@@ -284,22 +284,22 @@ public static void onUpdate(SQLiteDatabase db, int from, int to) {`
`284`	`284`	`}`
`285`	`285`	`return;`
`286`	`286`	`}`
`287`		`- if (from == 12) {`
	`287`	`+ if (from >= 12) {`
`288`	`288`	`try {`
`289`	`289`	`db.execSQL(`
`290`	`290`	`"ALTER TABLE bookmarksLocations ADD COLUMN location_destroyed STRING;");`
`291`	`291`	`} catch (SQLiteException exception) {`
`292`	`292`	`Timber.e(exception);`
`293`	`293`	`}`
`294`	`294`	`}`
`295`		`- if (from == 13){`
	`295`	`+ if (from >= 13){`
`296`	`296`	`try {`
`297`	`297`	`db.execSQL("ALTER TABLE bookmarksLocations ADD COLUMN location_language STRING;");`
`298`	`298`	`} catch (SQLiteException exception){`
`299`	`299`	`Timber.e(exception);`
`300`	`300`	`}`
`301`	`301`	`}`
`302`		`- if (from == 14){`
	`302`	`+ if (from >= 14){`
`303`	`303`	`try {`
`304`	`304`	`db.execSQL("ALTER TABLE bookmarksLocations ADD COLUMN location_exists STRING;");`
`305`	`305`	`} catch (SQLiteException exception){`