Fix nullability of the UploadItem

Author: psh

app/src/main/java/fr/free/nrw/commons/upload/ImageProcessingService.kt

@@ -45,7 +45,7 @@ class ImageProcessingService @Inject constructor(
         }
 
         Timber.d("Checking the validity of image")
-        val filePath = uploadItem.mediaUri.path
+        val filePath = uploadItem.mediaUri?.path
 
         return Single.zip(
             checkDuplicateImage(filePath),

app/src/main/java/fr/free/nrw/commons/upload/UploadItem.kt

@@ -8,11 +8,11 @@ import fr.free.nrw.commons.utils.ImageUtils
 import io.reactivex.subjects.BehaviorSubject
 
 class UploadItem(
-    var mediaUri: Uri,
+    var mediaUri: Uri?,
     val mimeType: String?,
     var gpsCoords: ImageCoordinates?,
-    var place: Place,
-    val createdTimestamp: Long,
+    var place: Place?,
+    val createdTimestamp: Long?,
     val createdTimestampSource: String?,
     /**
      * Uri of uploadItem
@@ -23,7 +23,7 @@ class UploadItem(
     val fileCreatedDateString: String?
 ) {
     var imageQuality: Int = ImageUtils.IMAGE_WAIT
-    var uploadMediaDetails: List<UploadMediaDetail> = listOf(UploadMediaDetail())
+    var uploadMediaDetails: MutableList<UploadMediaDetail> = mutableListOf(UploadMediaDetail())
     var hasInvalidLocation = false
     var isWLMUpload = false
     var countryCode: String? = null

app/src/test/kotlin/fr/free/nrw/commons/upload/CategoriesPresenterTest.kt

@@ -84,10 +84,10 @@ class CategoriesPresenterTest {
         )
         val nonEmptyCaptionUploadItem = mock<UploadItem>()
         whenever(nonEmptyCaptionUploadItem.uploadMediaDetails)
-            .thenReturn(listOf(UploadMediaDetail(captionText = "nonEmpty")))
+            .thenReturn(mutableListOf(UploadMediaDetail(captionText = "nonEmpty")))
         val emptyCaptionUploadItem = mock<UploadItem>()
         whenever(emptyCaptionUploadItem.uploadMediaDetails)
-            .thenReturn(listOf(UploadMediaDetail(captionText = "")))
+            .thenReturn(mutableListOf(UploadMediaDetail(captionText = "")))
         whenever(repository.getUploads()).thenReturn(
             listOf(
                 nonEmptyCaptionUploadItem,

app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaPresenterTest.kt

@@ -228,7 +228,7 @@ class UploadMediaPresenterTest {
         whenever(repository.getUploads()).thenReturn(listOf(uploadItem))
         whenever(repository.getUploadItem(ArgumentMatchers.anyInt()))
             .thenReturn(uploadItem)
-        whenever(uploadItem.uploadMediaDetails).thenReturn(listOf())
+        whenever(uploadItem.uploadMediaDetails).thenReturn(mutableListOf())
 
         uploadMediaPresenter.fetchTitleAndDescription(0)
         verify(view).updateMediaDetails(ArgumentMatchers.any())