rename toolbar name Favorites to Bookmarks (#4717)

* rename toolbar name Favorites to Bookmarks

* fix issue

* fix string.xml file

Author: Prince-kushwaha

app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java

@@ -271,7 +271,7 @@ private void restoreActiveFragment(@NonNull String fragmentName) {
             setTitle(getString(R.string.navigation_item_explore));
             loadFragment(ExploreFragment.newInstance(),false);
         }else if(fragmentName.equals(ActiveFragment.BOOKMARK.name())) {
-            setTitle(getString(R.string.favorites));
+            setTitle(getString(R.string.bookmarks));
             loadFragment(BookmarkFragment.newInstance(),false);
         }
     }

app/src/main/java/fr/free/nrw/commons/navtab/NavTab.java

@@ -8,7 +8,6 @@
 import fr.free.nrw.commons.bookmarks.BookmarkFragment;
 import fr.free.nrw.commons.contributions.ContributionsFragment;
 import fr.free.nrw.commons.explore.ExploreFragment;
-import fr.free.nrw.commons.explore.categories.search.SearchCategoryFragment;
 import fr.free.nrw.commons.nearby.fragments.NearbyParentFragment;
 import org.wikipedia.model.EnumCode;
 import org.wikipedia.model.EnumCodeMap;
@@ -38,7 +37,7 @@ public Fragment newInstance() {
             return ExploreFragment.newInstance();
         }
     },
-    FAVORITES(R.string.favorites, R.drawable.ic_round_star_border_24px) {
+    BOOKMARKS(R.string.bookmarks, R.drawable.ic_round_star_border_24px) {
         @NonNull
         @Override
         public Fragment newInstance() {

app/src/main/java/fr/free/nrw/commons/navtab/NavTabLoggedOut.java

@@ -20,7 +20,7 @@ public Fragment newInstance() {
             return ExploreFragment.newInstance();
         }
     },
-    FAVORITES(R.string.favorites, R.drawable.ic_round_star_border_24px) {
+    BOOKMARKS(R.string.bookmarks, R.drawable.ic_round_star_border_24px) {
         @NonNull
         @Override
         public Fragment newInstance() {

app/src/main/res/values/strings.xml

@@ -594,7 +594,7 @@ Upload your first media by tapping on the add button.</string>
   <string name="resume">resume</string>
   <string name="paused">Paused</string>
   <string name="more">More</string>
-  <string name="favorites">Favorites</string>
+  <string name="bookmarks">Bookmarks</string>
   <string name="achievements_tab_title">Achievements</string>
   <string name="leaderboard_tab_title">Leaderboard</string>
   <string name="rank_prefix">Rank:</string>