#4664 Moved Settings Activity to ViewBinding (#5506)

* Moved Main Activity and Settings Activity to ViewBinding
* Moving only SettingsActivity for now
* Removed values-yue-hant directory
* Removing previously done changes to main.xml

Author: ShashwatKedia

app/src/main/java/fr/free/nrw/commons/settings/SettingsActivity.java

@@ -3,32 +3,31 @@
 import android.os.Bundle;
 import android.view.MenuItem;
 
+import android.view.View;
 import androidx.appcompat.app.AppCompatDelegate;
 
-import androidx.appcompat.widget.Toolbar;
-import butterknife.BindView;
-import butterknife.ButterKnife;
-import fr.free.nrw.commons.R;
+import fr.free.nrw.commons.databinding.ActivitySettingsBinding;
 import fr.free.nrw.commons.theme.BaseActivity;
 
 /**
  * allows the user to change the settings
  */
 public class SettingsActivity extends BaseActivity {
+
+    private ActivitySettingsBinding binding;
     private AppCompatDelegate settingsDelegate;
-    @BindView(R.id.toolbar)
-    Toolbar toolbar;
     /**
      * to be called when the activity starts
      * @param savedInstanceState the previously saved state
      */
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        setContentView(R.layout.activity_settings);
+        binding = ActivitySettingsBinding.inflate(getLayoutInflater());
+        final View view = binding.getRoot();
+        setContentView(view);
 
-        ButterKnife.bind(this);
-        setSupportActionBar(toolbar);
+        setSupportActionBar(binding.toolbarBinding.toolbar);
         getSupportActionBar().setDisplayHomeAsUpEnabled(true);
     }
 

app/src/main/res/layout/activity_settings.xml

@@ -11,7 +11,9 @@
         android:id="@+id/toolbarLayout"
         android:layout_width="wrap_content"
         android:layout_height="?attr/actionBarSize">
-        <include layout="@layout/toolbar" />
+        <include
+          android:id="@+id/toolbarBinding"
+          layout="@layout/toolbar" />
     </LinearLayout>
     <RelativeLayout
         android:layout_width="match_parent"