Skip to content

Commit d1b0b4d

Browse files
cleanup
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
1 parent a647e61 commit d1b0b4d

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2230,4 +2230,4 @@ fun FileUsagesContainer(
22302230
}
22312231

22322232
}
2233-
}
2233+
}

app/src/main/java/fr/free/nrw/commons/media/MediaDetailViewModel.kt

-9
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ class MediaDetailViewModel(
3131
MutableStateFlow<FileUsagesContainerState>(FileUsagesContainerState.Initial)
3232
val globalContainerState = _globalContainerState.asStateFlow()
3333

34-
init {
35-
println("on this init ${hashCode()}")
36-
}
37-
3834
fun loadFileUsagesCommons(fileName: String) {
3935

4036
viewModelScope.launch(Dispatchers.IO) {
@@ -95,11 +91,6 @@ class MediaDetailViewModel(
9591

9692
}
9793

98-
override fun onCleared() {
99-
println("on this ${hashCode()} viewModel cleared")
100-
super.onCleared()
101-
}
102-
10394
sealed class FileUsagesContainerState {
10495
object Initial : FileUsagesContainerState()
10596
object Loading : FileUsagesContainerState()

app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt

-6
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,9 @@ class OkHttpJsonApiClient @Inject constructor(
9090
val urlBuilder = BuildConfig.FILE_USAGES_BASE_URL.toHttpUrlOrNull()!!.newBuilder()
9191
urlBuilder.addQueryParameter("prop", "fileusage")
9292
urlBuilder.addQueryParameter("titles", fileName)
93-
//TODO[Parry] might need pagination
9493
urlBuilder.addQueryParameter("fulimit", pageSize.toString())
9594

9695
Timber.i("Url %s", urlBuilder.toString())
97-
println(urlBuilder.build())
9896
val request: Request = Request.Builder()
9997
.url(urlBuilder.toString())
10098
.build()
@@ -109,11 +107,9 @@ class OkHttpJsonApiClient @Inject constructor(
109107
FileUsagesResponse::class.java
110108
)
111109
} catch (e: java.lang.Exception) {
112-
println("exception raised " + e.message)
113110
return@fromCallable null
114111
}
115112
}
116-
println("something else happend error")
117113
null
118114
})
119115
}
@@ -125,11 +121,9 @@ class OkHttpJsonApiClient @Inject constructor(
125121
val urlBuilder = BuildConfig.FILE_USAGES_BASE_URL.toHttpUrlOrNull()!!.newBuilder()
126122
urlBuilder.addQueryParameter("prop", "globalusage")
127123
urlBuilder.addQueryParameter("titles", fileName)
128-
//TODO[Parry] might need pagination
129124
urlBuilder.addQueryParameter("gulimit", pageSize.toString())
130125

131126
Timber.i("Url %s", urlBuilder.toString())
132-
println(urlBuilder.build())
133127
val request: Request = Request.Builder()
134128
.url(urlBuilder.toString())
135129
.build()

0 commit comments

Comments
 (0)