Fix Lint Issues #171: Remove unused imports (#2533)

* Fix Lint Issues #171: Remove unused imports

Removed unused Java imports

* Fix Lint Issues #171: Perfromance issue, close cursor

Cursor was not closed when no longer needed

Author: ronanb80

app/src/main/java/fr/free/nrw/commons/BasePresenter.java

@@ -1,7 +1,5 @@
 package fr.free.nrw.commons;
 
-import android.content.Context;
-
 /**
  * Base presenter, enforcing contracts to atach and detach view
  */

app/src/main/java/fr/free/nrw/commons/WelcomePagerAdapter.java

@@ -9,10 +9,6 @@
 import android.view.ViewGroup;
 import android.widget.TextView;
 
-import butterknife.ButterKnife;
-import butterknife.OnClick;
-import butterknife.Optional;
-
 public class WelcomePagerAdapter extends PagerAdapter {
     private static final int[] PAGE_LAYOUTS = new int[]{
             R.layout.welcome_wikipedia,

app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java

@@ -29,7 +29,6 @@
 
 import java.io.IOException;
 import java.util.Locale;
-import java.util.Objects;
 
 import javax.inject.Inject;
 import javax.inject.Named;

app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarksActivity.java

@@ -16,7 +16,6 @@
 import butterknife.ButterKnife;
 import fr.free.nrw.commons.Media;
 import fr.free.nrw.commons.R;
-import fr.free.nrw.commons.auth.AuthenticatedActivity;
 import fr.free.nrw.commons.contributions.ContributionController;
 import fr.free.nrw.commons.media.MediaDetailPagerFragment;
 import fr.free.nrw.commons.theme.NavigationBaseActivity;

app/src/main/java/fr/free/nrw/commons/bookmarks/locations/BookmarkLocationsDao.java

@@ -4,7 +4,6 @@
 import android.content.ContentValues;
 import android.database.Cursor;
 import android.database.sqlite.SQLiteDatabase;
-import android.net.Uri;
 import android.os.RemoteException;
 import android.support.annotation.NonNull;
 

app/src/main/java/fr/free/nrw/commons/campaigns/CampaignView.java

@@ -12,7 +12,6 @@
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Date;
-import java.util.Locale;
 
 import butterknife.BindView;
 import butterknife.ButterKnife;

app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.java

@@ -1,22 +1,19 @@
 package fr.free.nrw.commons.campaigns;
 
 import android.annotation.SuppressLint;
-import android.content.Context;
 import android.util.Log;
 
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Collections;
 import java.util.Date;
 import java.util.List;
-import java.util.Locale;
 
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
 import fr.free.nrw.commons.BasePresenter;
 import fr.free.nrw.commons.MvpView;
-import fr.free.nrw.commons.di.ApplicationlessInjection;
 import fr.free.nrw.commons.mwapi.OkHttpJsonApiClient;
 import io.reactivex.Single;
 import io.reactivex.SingleObserver;

app/src/main/java/fr/free/nrw/commons/campaigns/ICampaignsView.java

@@ -1,7 +1,6 @@
 package fr.free.nrw.commons.campaigns;
 
 import fr.free.nrw.commons.MvpView;
-import fr.free.nrw.commons.mwapi.MediaWikiApi;
 
 /**
  * Interface which defines the view contracts of the campaign view

app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java

@@ -2,7 +2,6 @@
 
 import android.content.Context;
 import android.view.View;
-import android.widget.ImageButton;
 import android.widget.LinearLayout;
 import android.widget.ProgressBar;
 import android.widget.TextView;

app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java

@@ -9,7 +9,6 @@
 import android.support.v4.app.Fragment;
 import android.support.v4.app.FragmentManager;
 import android.support.v4.app.FragmentPagerAdapter;
-import android.support.v4.content.ContextCompat;
 import android.support.v4.view.GravityCompat;
 import android.support.v4.view.ViewPager;
 import android.support.v4.widget.DrawerLayout;

app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java

@@ -9,7 +9,6 @@
 import fr.free.nrw.commons.CommonsApplication;
 import fr.free.nrw.commons.MediaWikiImageView;
 import fr.free.nrw.commons.auth.LoginActivity;
-import fr.free.nrw.commons.campaigns.CampaignsPresenter;
 import fr.free.nrw.commons.contributions.ContributionsSyncAdapter;
 import fr.free.nrw.commons.delete.DeleteTask;
 import fr.free.nrw.commons.modifications.ModificationsSyncAdapter;

app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.java

@@ -3,12 +3,10 @@
 import android.app.Activity;
 import android.content.ContentProviderClient;
 import android.content.Context;
-import android.net.Uri;
 import android.support.v4.util.LruCache;
 import android.view.inputmethod.InputMethodManager;
 
 import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
 
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -29,12 +27,9 @@
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.location.LocationServiceManager;
 import fr.free.nrw.commons.mwapi.MediaWikiApi;
-import fr.free.nrw.commons.nearby.NearbyPlaces;
 import fr.free.nrw.commons.settings.Prefs;
 import fr.free.nrw.commons.upload.UploadController;
 import fr.free.nrw.commons.utils.ConfigUtils;
-import fr.free.nrw.commons.utils.UriDeserializer;
-import fr.free.nrw.commons.utils.UriSerializer;
 import fr.free.nrw.commons.wikidata.WikidataEditListener;
 import fr.free.nrw.commons.wikidata.WikidataEditListenerImpl;
 

app/src/main/java/fr/free/nrw/commons/filepicker/UploadableFile.java

@@ -105,6 +105,7 @@ private DateTimeWithSource getFileCreatedDateFromCP(Context context) {
             }
             //If both the content providers do not give the data, lets leave it to Jesus
             if (lastModifiedColumnIndex == -1) {
+                cursor.close();
                 return null;
             }
             cursor.moveToFirst();

app/src/main/java/fr/free/nrw/commons/logging/CommonsLogSender.java

@@ -5,7 +5,6 @@
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
-import fr.free.nrw.commons.BuildConfig;
 import fr.free.nrw.commons.auth.SessionManager;
 import fr.free.nrw.commons.utils.ConfigUtils;
 import fr.free.nrw.commons.utils.DeviceInfoUtil;

app/src/main/java/fr/free/nrw/commons/logging/LogUtils.java

@@ -2,8 +2,6 @@
 
 import android.os.Environment;
 
-import java.io.File;
-
 import fr.free.nrw.commons.upload.FileUtils;
 import fr.free.nrw.commons.utils.ConfigUtils;
 

app/src/main/java/fr/free/nrw/commons/logging/LogsSender.java

@@ -10,7 +10,6 @@
 import org.acra.collector.CrashReportData;
 import org.acra.sender.ReportSender;
 import org.apache.commons.codec.Charsets;
-import org.apache.http.protocol.HTTP;
 
 import java.io.BufferedInputStream;
 import java.io.BufferedOutputStream;
@@ -23,7 +22,6 @@
 
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.auth.SessionManager;
-import fr.free.nrw.commons.utils.ConfigUtils;
 import timber.log.Timber;
 
 /**

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -2,8 +2,6 @@
 
 import android.annotation.SuppressLint;
 import android.app.AlertDialog;
-import android.content.ClipData;
-import android.content.ClipboardManager;
 import android.content.Intent;
 import android.database.DataSetObserver;
 import android.net.Uri;
@@ -58,7 +56,6 @@
 import io.reactivex.schedulers.Schedulers;
 import timber.log.Timber;
 
-import static android.content.Context.CLIPBOARD_SERVICE;
 import static android.view.View.GONE;
 import static android.view.View.VISIBLE;
 import static android.widget.Toast.LENGTH_SHORT;

app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java

@@ -47,7 +47,6 @@
 import fr.free.nrw.commons.notification.Notification;
 import fr.free.nrw.commons.notification.NotificationUtils;
 import fr.free.nrw.commons.utils.ConfigUtils;
-import fr.free.nrw.commons.utils.DateUtils;
 import fr.free.nrw.commons.utils.StringUtils;
 import fr.free.nrw.commons.utils.ViewUtil;
 import in.yuvi.http.fluent.Http;

app/src/main/java/fr/free/nrw/commons/mwapi/MediaWikiApi.java

@@ -4,18 +4,13 @@
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 
-import fr.free.nrw.commons.campaigns.CampaignResponseDTO;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.List;
 
 import fr.free.nrw.commons.Media;
-import fr.free.nrw.commons.achievements.FeedbackResponse;
-import fr.free.nrw.commons.location.LatLng;
-import fr.free.nrw.commons.nearby.Place;
 import fr.free.nrw.commons.notification.Notification;
 import io.reactivex.Observable;
-import io.reactivex.Single;
 
 public interface MediaWikiApi {
     String getUserAgent();

app/src/main/java/fr/free/nrw/commons/nearby/NearbyBaseMarker.java

@@ -1,19 +1,14 @@
 package fr.free.nrw.commons.nearby;
 
 import android.graphics.Bitmap;
-import android.net.Uri;
 import android.os.Parcel;
 import android.os.Parcelable;
 
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
 import com.mapbox.mapboxsdk.annotations.BaseMarkerOptions;
 import com.mapbox.mapboxsdk.annotations.Icon;
 import com.mapbox.mapboxsdk.annotations.IconFactory;
 import com.mapbox.mapboxsdk.geometry.LatLng;
 
-import fr.free.nrw.commons.utils.UriSerializer;
-
 public class NearbyBaseMarker extends BaseMarkerOptions<NearbyMarker, NearbyBaseMarker> {
 
     public static final Parcelable.Creator<NearbyBaseMarker> CREATOR = new Parcelable.Creator<NearbyBaseMarker>() {

app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java

@@ -1,8 +1,6 @@
 package fr.free.nrw.commons.nearby;
 
 import android.content.Context;
-import android.content.Intent;
-import android.net.Uri;
 import android.os.Bundle;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
@@ -11,7 +9,6 @@
 import android.view.ViewGroup;
 
 import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
 import com.google.gson.reflect.TypeToken;
 import com.pedrogomez.renderers.RVRendererAdapter;
 
@@ -29,7 +26,6 @@
 import fr.free.nrw.commons.kvstore.BasicKvStore;
 import fr.free.nrw.commons.kvstore.JsonKvStore;
 import fr.free.nrw.commons.location.LatLng;
-import fr.free.nrw.commons.utils.UriDeserializer;
 import timber.log.Timber;
 
 public class NearbyListFragment extends DaggerFragment {

app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java

@@ -3,9 +3,6 @@
 import android.animation.ObjectAnimator;
 import android.animation.TypeEvaluator;
 import android.animation.ValueAnimator;
-import android.content.ClipData;
-import android.content.ClipboardManager;
-import android.content.Context;
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;

app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java

@@ -9,7 +9,6 @@
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.ProgressBar;
-import android.widget.RelativeLayout;
 import android.widget.TextView;
 
 import fr.free.nrw.commons.R;

app/src/main/java/fr/free/nrw/commons/nearby/PlaceRenderer.java

@@ -4,7 +4,6 @@
 import android.net.Uri;
 import android.support.transition.TransitionManager;
 import android.support.v4.app.Fragment;
-import android.support.v4.app.FragmentManager;
 import android.support.v7.app.AlertDialog;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.PopupMenu;
@@ -32,7 +31,6 @@
 import fr.free.nrw.commons.auth.LoginActivity;
 import fr.free.nrw.commons.bookmarks.locations.BookmarkLocationsDao;
 import fr.free.nrw.commons.contributions.ContributionController;
-import fr.free.nrw.commons.contributions.MainActivity;
 import fr.free.nrw.commons.di.ApplicationlessInjection;
 import fr.free.nrw.commons.kvstore.BasicKvStore;
 import fr.free.nrw.commons.kvstore.JsonKvStore;

app/src/main/java/fr/free/nrw/commons/quiz/QuizActivity.java

@@ -1,6 +1,5 @@
 package fr.free.nrw.commons.quiz;
 
-import android.content.DialogInterface;
 import android.content.Intent;
 import android.os.Bundle;
 import android.support.graphics.drawable.VectorDrawableCompat;

app/src/main/java/fr/free/nrw/commons/quiz/QuizResultActivity.java

@@ -1,7 +1,6 @@
 package fr.free.nrw.commons.quiz;
 
 import android.content.Context;
-import android.content.DialogInterface;
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.net.Uri;

app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java

@@ -1,8 +1,6 @@
 package fr.free.nrw.commons.settings;
 
 import android.Manifest;
-import android.app.AlertDialog;
-import android.content.SharedPreferences;
 import android.net.Uri;
 import android.os.Bundle;
 import android.preference.EditTextPreference;
@@ -27,8 +25,6 @@
 import fr.free.nrw.commons.utils.PermissionUtils;
 import fr.free.nrw.commons.utils.ViewUtil;
 
-import static android.R.*;
-
 public class SettingsFragment extends PreferenceFragment {
 
     @Inject

app/src/main/java/fr/free/nrw/commons/theme/NavigationBaseActivity.java

@@ -34,7 +34,6 @@
 import fr.free.nrw.commons.WelcomeActivity;
 import fr.free.nrw.commons.achievements.AchievementsActivity;
 import fr.free.nrw.commons.auth.LoginActivity;
-import fr.free.nrw.commons.auth.SessionManager;
 import fr.free.nrw.commons.bookmarks.BookmarksActivity;
 import fr.free.nrw.commons.category.CategoryImagesActivity;
 import fr.free.nrw.commons.contributions.MainActivity;

app/src/main/java/fr/free/nrw/commons/ui/widget/CustomEditText.java

@@ -2,7 +2,6 @@
 
 import android.annotation.SuppressLint;
 import android.content.Context;
-import android.graphics.Canvas;
 import android.graphics.Rect;
 import android.graphics.drawable.Drawable;
 import android.util.AttributeSet;

app/src/main/java/fr/free/nrw/commons/upload/FileUtilsWrapper.java

@@ -1,12 +1,7 @@
 package fr.free.nrw.commons.upload;
 
-import android.content.ContentResolver;
-import android.content.Context;
-import android.net.Uri;
-
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
-import java.io.IOException;
 import java.io.InputStream;
 
 import javax.inject.Inject;

app/src/main/java/fr/free/nrw/commons/upload/Title.java

@@ -2,9 +2,6 @@
 
 import android.text.TextUtils;
 
-import io.reactivex.subjects.BehaviorSubject;
-import timber.log.Timber;
-
 public class Title{
 
     private String titleText;

app/src/main/java/fr/free/nrw/commons/upload/UploadThumbnailsAdapterFactory.java

@@ -7,8 +7,6 @@
 import java.util.Collections;
 import java.util.List;
 
-import javax.inject.Inject;
-
 public class UploadThumbnailsAdapterFactory {
     private ThumbnailClickedListener listener;
 

app/src/main/java/fr/free/nrw/commons/upload/UploadView.java

@@ -6,8 +6,6 @@
 import java.lang.annotation.Retention;
 import java.util.List;
 
-import fr.free.nrw.commons.utils.ImageUtils;
-
 import static java.lang.annotation.RetentionPolicy.SOURCE;
 
 public interface UploadView {

app/src/main/java/fr/free/nrw/commons/utils/ContributionListViewUtils.java

@@ -1,6 +1,5 @@
 package fr.free.nrw.commons.utils;
 
-import android.util.Log;
 import android.view.View;
 
 /**