bugfix/uploads (#3012)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView

* BugFix Illegal State Exception in ViewpPagerAdapter

* Remove irrelevant comment

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java

@@ -341,6 +341,7 @@ public int getTotalNumberOfSteps() {
             fragments.add(mediaLicenseFragment);
 
             uploadImagesAdapter.setFragments(fragments);
+            vpUpload.setOffscreenPageLimit(fragments.size());
         }
     }
 
@@ -430,8 +431,6 @@ public void setFragments(List<Fragment> fragments) {
         }
 
         @Override public int getCount() {
-            //I understand this is not the best way, I will think of something better than this
-            vpUpload.setOffscreenPageLimit(fragments.size());
             return fragments.size();
         }