Skip to content

Commit f573789

Browse files
authored
Merge pull request #402 from veyndan/unused-menu-icon
Remove references to icons when showAsAction is set to never
2 parents fcf9f3a + 21a6c45 commit f573789

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

app/src/main/res/menu/fragment_contributions_list.xml

-4
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,18 @@
1515
<item android:id="@+id/menu_settings"
1616
android:title="@string/menu_settings"
1717
app:showAsAction="never"
18-
android:icon="@android:drawable/ic_menu_preferences"
1918
/>
2019
<item android:id="@+id/menu_about"
2120
android:title="@string/menu_about"
2221
app:showAsAction="never"
23-
android:icon="@android:drawable/ic_menu_info_details"
2422
/>
2523
<item android:id="@+id/menu_feedback"
2624
android:title="@string/menu_feedback"
2725
app:showAsAction="never"
28-
android:icon="@android:drawable/ic_menu_send"
2926
/>
3027
<item android:id="@+id/menu_nearby"
3128
android:title="@string/menu_nearby"
3229
app:showAsAction="never"
33-
android:icon="@android:drawable/ic_menu_myplaces"
3430
/>
3531
<item android:id="@+id/menu_refresh"
3632
android:title="@string/menu_refresh"

app/src/main/res/menu/fragment_image_detail.xml

-3
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@
99
app:showAsAction="ifRoom|withText" />
1010
<item
1111
android:id="@+id/menu_browser_current_image"
12-
android:icon="@android:drawable/ic_menu_view"
1312
android:title="@string/menu_open_in_browser"
1413
app:showAsAction="never" />
1514
<item
1615
android:id="@+id/menu_download_current_image"
17-
android:icon="@drawable/ic_menu_download"
1816
android:title="@string/menu_download"
1917
app:showAsAction="never" />
2018
<item
@@ -27,7 +25,6 @@
2725
<item
2826
android:id="@+id/menu_cancel_current_image"
2927
android:enabled="false"
30-
android:icon="@android:drawable/ic_menu_delete"
3128
android:title="@string/menu_cancel_upload"
3229
android:visible="false"
3330
app:showAsAction="never" />

0 commit comments

Comments
 (0)