-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Explicitly show that the license text is a link #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Regardless, I think the Upload screen needs a revamp. It's quite odd to show the image being uploaded in the background. It seems to be cluttering up with the text in the screen (the text Wikimedia Commons policies is barely visible). It would be better to show a small preview of the image and let the users see it fully if they want to. |
Explicitly displaying the license link sounds good to me. Please do create a separate issue to discuss the Upload screen revamp. :) |
I like to work on this issue. |
@mithlesh4257 It is yours, waiting for your pull request :-) |
@nicolas-raoul If the issue is still not solved then I would love to work on it. |
@madhurgupta10 No news from @mithlesh4257 so yes, feel free! |
@nicolas-raoul Sure. |
Is someone working on this? |
@madhurgupta10 What is the situation on this? |
@nicolas-raoul can I work on this issue? |
@Mansi449 How about letting @AmineToualbi (who expressed interest 6 days ago) work on it? |
Fixed in new upload UI |
I saw the blog post about the recent release and came to know that the licenses were linked. I thought of seeing it in the app and was surprised to see that the text denoting the license was plain. Surprisingly tapping on the text did open the browser make it behave like links while not visually depicting a link. That wasn't something I expected (Principle of least surprise). I might not have even found it was a link if I hadn't read the blog post. I guess it's better to give links their usual distinction (like other links on the same screen).
I guess there are two ways to go about it,
The text was updated successfully, but these errors were encountered: