-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix Travis build failures due to Nearby tests #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to have a shot at this. I'll probably get to learn how to write tests properly too. 👍 |
@yashshah7197 I think you currently already have an assigned task (memory leak A)? But feel free to ping me after that has been completed and I will assign this to you then. :) |
Can I work on this? |
I had completed step 1. Starting working on step 2 now. |
2nd part is left in this issue can we reopen it? |
@ujjwalagrawal17 it is yours. :) |
@misaochan yup I will complete it soon. |
Summary:
Travis has been failing ever since our Nearby overhaul, specifically due to Nearby tests failing. I would propose two steps to fix this problem:
First, temporarily remove all Nearby tests. This allows us to actually use Travis again for PR and build evaluation, instead of just assuming it will fail.
Then, re-create Nearby tests one by one. Nearby has changed so significantly that I imagine we will need to rewrite the majority of the tests.
Steps to reproduce:
Look at Travis builds and Nearby tests
Would you like to work on the issue?
Ideally, no :) Anyone, please feel free to take it up.
The text was updated successfully, but these errors were encountered: