Skip to content

Fix Travis build failures due to Nearby tests #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue Mar 26, 2018 · 7 comments
Closed

Fix Travis build failures due to Nearby tests #1371

misaochan opened this issue Mar 26, 2018 · 7 comments

Comments

@misaochan
Copy link
Member

misaochan commented Mar 26, 2018

Summary:

Travis has been failing ever since our Nearby overhaul, specifically due to Nearby tests failing. I would propose two steps to fix this problem:

  1. First, temporarily remove all Nearby tests. This allows us to actually use Travis again for PR and build evaluation, instead of just assuming it will fail.

  2. Then, re-create Nearby tests one by one. Nearby has changed so significantly that I imagine we will need to rewrite the majority of the tests.

Steps to reproduce:

Look at Travis builds and Nearby tests

Would you like to work on the issue?

Ideally, no :) Anyone, please feel free to take it up.

@yashshah7197
Copy link
Contributor

I'd like to have a shot at this. I'll probably get to learn how to write tests properly too. 👍

@misaochan
Copy link
Member Author

@yashshah7197 I think you currently already have an assigned task (memory leak A)? But feel free to ping me after that has been completed and I will assign this to you then. :)

@ujjwalagrawal17
Copy link
Contributor

Can I work on this?

@ujjwalagrawal17
Copy link
Contributor

I had completed step 1. Starting working on step 2 now.

@ujjwalagrawal17
Copy link
Contributor

2nd part is left in this issue can we reopen it?

@neslihanturan neslihanturan reopened this Mar 28, 2018
@misaochan
Copy link
Member Author

@ujjwalagrawal17 it is yours. :)

@ujjwalagrawal17
Copy link
Contributor

@misaochan yup I will complete it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants