Skip to content

Count on Contributions does not update on deletion #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madhurgupta10 opened this issue Feb 23, 2019 · 5 comments
Closed

Count on Contributions does not update on deletion #2509

madhurgupta10 opened this issue Feb 23, 2019 · 5 comments

Comments

@madhurgupta10
Copy link
Collaborator

Summary:
If we delete a photo, the number of contributions do not change until the app is restarted.
#2377 & #2324 are similar but does not mention this specific case.
ezgif-5-5827a67ba2ac

Steps to reproduce:
Delete the file which is not uploaded and you will see the count of contributions is not uploaded.

Device and Android version:
Xiaomi Mi A1, with API level 28 running stock android

Commons app version:
betaDebug

Would you like to work on the issue?
Yes, I want to work on this issue :)

@maskaravivek
Copy link
Member

The contribution gets counted only after a upload is successful

@madhurgupta10
Copy link
Collaborator Author

@maskaravivek in my case the contribution do get updated even if the upload fails and do not updates when uploaded file is removed.

@maskaravivek
Copy link
Member

maskaravivek commented Feb 24, 2019

upload fails

not updating as this upload was never counted

uploaded file is removed

again the file was still not fully uploaded to the server. so canceling an upload won't affect the count.

@madhurgupta10
Copy link
Collaborator Author

@maskaravivek got it, thanks for the clarification. Should I close this issue?

@maskaravivek
Copy link
Member

Closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants