Notification does not disappear when upload fails

[nicolas-raoul]

Steps to reproduce:

1. Upload something
2. During the upload, remove the network connection or make the Internet super slow. It might need to be done at a very specific time, you will have to try.
3. The upload becomes marked as "Failed" in the Home activity.
4. Problem: The notification is still pretending to be progressing (in my case it says "Finishing uploading"). Expected: The notification either disappears or says that the upload failed.

Device and Android version:
LineageOS 7.1.2

Commons app version:
2.10.1.370~76e5a30

Screen-shots:

[omer-rotem1]

Hi, can I work on this please as a first issue?

Thanks

[nicolas-raoul]

@omer-rotem1 Yes, thanks!

[318anushka]

This issue doesn't exist anymore.
Could you please close it :-)

[nicolas-raoul]

@omer-rotem1 Are you still working on it? If not please let us know, thanks :-)

@318anushka I experienced this issue last week, do you think it has been fixed very recently? By the way, you might be interested in this issue meanwhile: #3582

[318anushka]

Yeah i checked and it seems to work fine. As soon as i remove net connection, failed notification pops up

[nicolas-raoul]

Ah, yes indeed this issue is about the "Finishing uploading" message, I see, thanks!

The remaining issue is that it seems impossible to swipe the failure notification away. The only solution to make it disappear seems to be to reboot the phone, which is quite inconvenient. Do you experience this problem? If yes, would you mind creating an issue about it? Thanks!

[318anushka]

Yes, swiping away is a problem. But once the upload fails, just tap on notification it takes you to the Home Activity then the notification automatically disappears. you don't have to reboot the phone.
Although it would be better if we could just swipe away the notification.

[nicolas-raoul]

wow I will try next time lol

[sivaraam]

Although it would be better if we could just swipe away the notification.

+1 for this. I don't see any reason why the failure notification should be sticky.

[318anushka]

Should i create a new issue for this?

[nicolas-raoul]

@318anushka Yes good idea, thanks! :-)

[Rishavgupta12345]

@nicolas-raoul notification works properly now so we can close this old issue