Skip to content

Media Detail view uses 640 width thumb url instead of using the original image URL #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maskaravivek opened this issue Apr 20, 2019 · 1 comment · Fixed by #2906
Closed
Assignees

Comments

@maskaravivek
Copy link
Member

The full image should only be downloaded when the user clicks to view the image.

As per the current code base, even on clicking the image, the media detail view shows the 640 width image as MediaDetailFragment also uses MediaWikiImageView. Will be fixing this too.

Going forward,

  • list views will use the thumbnail, and fallback to the original image if thumbnail is not available
  • the media detail view will use the original URL instead of using the thumbnail.

Originally posted by @maskaravivek in #2820 (comment)

@maskaravivek
Copy link
Member Author

@misaochan @neslihanturan Is there a specific reason for using thumb urls even in media detail view? If not, I will go ahead and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant