-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Reconsider peer review button strings #2920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@neslihanturan also the position of SKIP THIS IMAGE confuses first-time users (if it is a subtitle or a button). |
This appears to be fairly beginner-friendly so i'm happy to work on this.. |
Thanks for your interest, what are your suggestions for new strings @mar7yn ? |
Instead of: Use either: Button strings: Any thoughts? EDIT: Just looking through the ReviewImageFragment class file, specifically the context-specific button string declarations. I'll give this some more thought and will get back to you :) |
May I contribute to this issue @neslihanturan |
Sure @chaytanyasinha , do you have suggestions for strings? |
@neslihanturan ma'am, |
Hey @chaytanyasinha, thanks for sharing preffered strings but they are somehow longer then the previous ones. but we want to make them shorter. Additionally it is always better to ad a single space after punctuations. By the way I am not the most suitable person to discuss language fixes so this discussion is very open for someone to join |
Hey @neslihanturan thanks for letting me know.Well I was also thinking of of the string "Does this come under (category)?" where (category) is variable which will be adjusted with the according to whatever the category will be. |
@nicolas-raoul now we have a perfectly size button so we can close this issue now |
Summary:
We want to have single line buttons, but since our button texts are too long, we reduced their text sizes for a temporary solution.
We need to have shorter (but still meaningful) button texts. Or we need to find strings that will be relevant even in short form.
Steps to reproduce:
Open peer review activity
Screen-shots:
Here how it looks now:

Here how we want to make it look:
The text was updated successfully, but these errors were encountered: