Skip to content

Reconsider peer review button strings #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neslihanturan opened this issue Apr 24, 2019 · 10 comments
Closed

Reconsider peer review button strings #2920

neslihanturan opened this issue Apr 24, 2019 · 10 comments

Comments

@neslihanturan
Copy link
Collaborator

Summary:
We want to have single line buttons, but since our button texts are too long, we reduced their text sizes for a temporary solution.

We need to have shorter (but still meaningful) button texts. Or we need to find strings that will be relevant even in short form.

Steps to reproduce:

Open peer review activity

Screen-shots:

Here how it looks now:
Screenshot from 2019-04-24 14-23-15

Here how we want to make it look:

Screenshot from 2019-04-24 14-27-56

@madhurgupta10
Copy link
Collaborator

@neslihanturan also the position of SKIP THIS IMAGE confuses first-time users (if it is a subtitle or a button).

@mar7yn
Copy link

mar7yn commented May 8, 2019

This appears to be fairly beginner-friendly so i'm happy to work on this..

@neslihanturan
Copy link
Collaborator Author

Thanks for your interest, what are your suggestions for new strings @mar7yn ?

@mar7yn
Copy link

mar7yn commented May 9, 2019

Hi @neslihanturan

Instead of:
"Is this correctly categorized"

Use either:
"Review image categories" or
"Review category assignment"

Button strings:
"Reject" versus "Seems fine"

Any thoughts?

EDIT: Just looking through the ReviewImageFragment class file, specifically the context-specific button string declarations. I'll give this some more thought and will get back to you :)

@chaytanyasinha
Copy link

May I contribute to this issue @neslihanturan

@neslihanturan
Copy link
Collaborator Author

Sure @chaytanyasinha , do you have suggestions for strings?

@chaytanyasinha
Copy link

@neslihanturan ma'am,
I would say that while questioning we can let it be "Does this follow the rules of copyright?".And we can say "Logos,screenshots,movie posters are often copyright violations".That's it,because writing "Clicking NO to nominate this image for deletion" as it's already mentioned in the first review question and it's letting the "NO,copyright violation" to hide or we can shift the "NO,copyright violation" little upward.
WhatsApp Image 2019-11-09 at 22 28 01
WhatsApp Image 2019-11-09 at 22 28 56

@neslihanturan
Copy link
Collaborator Author

Hey @chaytanyasinha, thanks for sharing preffered strings but they are somehow longer then the previous ones. but we want to make them shorter. Additionally it is always better to ad a single space after punctuations. By the way I am not the most suitable person to discuss language fixes so this discussion is very open for someone to join

@chaytanyasinha
Copy link

chaytanyasinha commented Nov 13, 2019

Hey @neslihanturan thanks for letting me know.Well I was also thinking of of the string "Does this come under (category)?" where (category) is variable which will be adjusted with the according to whatever the category will be.

@Rishavgupta12345
Copy link
Contributor

@nicolas-raoul now we have a perfectly size button so we can close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants