Skip to content

Memory leaks when resuming and pausing #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue Nov 6, 2020 · 1 comment · Fixed by #4050
Closed

Memory leaks when resuming and pausing #4019

misaochan opened this issue Nov 6, 2020 · 1 comment · Fixed by #4050
Assignees
Labels

Comments

@misaochan
Copy link
Member

Summary:

Memory leaks found when resuming and pausing uploads

Steps to reproduce:

Install LeakCanary, pull #4011 , upload a pic, pause

Device and Android version:

Samsung Galaxy S20FE, Android 10

Commons app version:

#4011

@maskaravivek
Copy link
Member

maskaravivek commented Nov 7, 2020

@misaochan Can you share a screenshot of the leak info?

Edit: I was able to check this leak. It seems to be coming from the license spinner in the MediaLicenseFragment. I am assuming this might be happening for quite some time now because none of my limited upload changes affected the upload fragments.

Screenshot_2020-11-06-23-47-37-262_fr free nrw commons

I took a look at the issue but couldn't figure out the solution. Would it be possible for someone else to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants