Skip to content

Grey empty screen at Upload wizard caption step after denying files permission #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Oct 7, 2023 · 7 comments · Fixed by #5356
Closed
Assignees

Comments

@nicolas-raoul
Copy link
Member

Screenshot_20231007-182129.png

@kanahia1
Copy link
Contributor

kanahia1 commented Oct 7, 2023

Hi @nicolas-raoul , I would like to work on this issue, can you please assign it to me.

@nicolas-raoul
Copy link
Member Author

@kanahia1 Did you manage to reproduce the issue? :-)

@kanahia1
Copy link
Contributor

kanahia1 commented Oct 8, 2023

@nicolas-raoul , I have attached the video demonstrating the issue

VID-20231008-WA0012.mp4

@nicolas-raoul
Copy link
Member Author

@kanahia1 Great! It is yours, thanks 🙂

@kanahia1
Copy link
Contributor

Hi @nicolas-raoul, here is the progress of the week

🐛 Fixed grey empty screen at upload caption step ---

Untitled.video.-.Made.with.Clipchamp.2.mp4
Untitled.video.-.Made.with.Clipchamp.3.mp4

➕ Added functionality to the cancel button of the dialog box, because people often don't see or read everything on the screen. Therefore, we must warn them with a toast message in case they click on the cancel button and also inform them that they need to accept permissions in order to access the upload facility.

Untitled.video.-.Made.with.Clipchamp.5.mp4

I am currently working on an issue with a dialog box (an infinite loop) that is created due to checking permissions in the onResume method in Upload Activity. I will be sharing the pull request (PR) next week. ✨

@nicolas-raoul
Copy link
Member Author

Looks good, thanks a lot for the update!
Do not hesitate to send a draft pull request.

@kanahia1
Copy link
Contributor

Hi @nicolas-raoul , I have fixed loop issue, can you please review it. #5356

🐛Bug

Untitled.video.-.Made.with.Clipchamp.7.mp4

🔧Fixed

Untitled.video.-.Made.with.Clipchamp.8.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants