-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add location button UI not being updated when user clicks yes in similar image dialog #5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nicolas-raoul, could this issue be labelled as a 'good first issue' for newcomers to try? |
Thanks for spotting this bug! OK done :-) |
I would like to work on this! Can I be assigned? |
@alxmartin01 It is yours, thanks! 🙂 |
Hey, Could you please assign me this issue, Would like to work on that. |
@alxmartin01 Any progress to share? Are you still working on this? :-) |
Can I work on it? |
@AMANISPEACE and @nishit2003 Please use the "unassigned bugs" link at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md to find other tasks that are waiting for someone to take care of them, thanks :-) |
Hi, there hasn't been any recent activity on this issue, can I be assigned to it? I am new to this project and think this would be a great issue to work on! |
No news from alxmartin01 so it is yours @AdamTWEnglish thanks! :-) |
I believe this is fixed. :-) |
Summary
The app currently has a feature where the user can copy the location of a recently uploaded image to the new set of images being uploaded. The current image's 'Add location' button should change to 'Edit location' when the user clicks yes in the aforesaid dialog.
Steps to reproduce
Expected behaviour
The current image's 'Add location' button should change to 'Remove location' with the icon also changing accordingly, as the image now has location data, which can be verified by tapping the button.
Actual behaviour
The current image's 'Add location' button UI stays the same.
Device name
OnePlus Nord CE 2 Lite 5G
Android version
Android 12
Commons app version
master
Device logs
No response
Screen-shots
Screencast:
video6064299869818851037.mp4
Would you like to work on the issue?
None
The text was updated successfully, but these errors were encountered: