Skip to content

Rotatable map for the “nearby” search #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OpenGreenStreet opened this issue Sep 8, 2024 · 7 comments
Open

Rotatable map for the “nearby” search #5822

OpenGreenStreet opened this issue Sep 8, 2024 · 7 comments

Comments

@OpenGreenStreet
Copy link

What is the user problem or growth opportunity you want to see solved?

It would be very helpful if the map could be rotated.

How do you know that this problem exists today? Why is this important?

This would allow much better orientation

Who will benefit from it?

all users

Anything else you would like to add?

The StreetComplete app, for example, offers one such option

@cambo14
Copy link
Contributor

cambo14 commented Oct 11, 2024

Hi, could I please be assigned this?

@nicolas-raoul
Copy link
Member

@cambo14 Sorry would you mind using the "unassigned bug" link at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers to find an issue to work on? Thanks a lot! :-)

@savsch
Copy link
Contributor

savsch commented Dec 15, 2024

Hi, could I please be assigned this?
(shamelessly copied the above comment 😅)

@nicolas-raoul
Copy link
Member

While this will definitely be a nice feature to have in the future, Nearby currently suffers from big issues (UI slowdowns in areas with many points, slow loading of pins even cached ones, memory leaks) that make it almost useless in many big cities, and must be fixed before adding the complexity of rotation.

Wikidata's item search API can not take rotated rectangles as a parameter, so this feature will increase both complexity and slowliness, and memory consumption. So let's come back to it once Nearby is perfect, hopefully soon. Thanks all for your understanding! 🙂

@nicolas-raoul
Copy link
Member

I just noticed that the Wikipedia app's map can't be rotated either. 😥

Screenshot_20241228-142618.png

@savsch
Copy link
Contributor

savsch commented Dec 28, 2024

I just noticed that the Wikipedia app's map can't be rotated either. 😥

A workaround I had been thinking of was to query for places in a non-rotated rectangle circumscribed about the rotated map-boundary-rectangle, and to then filter out the places lying ouside the inner rectangle:

illustration

Oh, and while we're at it, @nicolas-raoul could you please help me out with #6081 (comment)

@nicolas-raoul
Copy link
Member

query for places in a non-rotated rectangle circumscribed about the rotated map-boundary-rectangle

That's would indeed be the best solution I believe, but it would still increase complexity/slowliness/memory consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants