-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Nearby: When tapping green pin, show picture thumbnail #6182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to try it |
Hi Nicolas, I have a few questions regarding the issue I’m working on: 1. Thumbnail
2. Using Glide for Image Loading
3. Clarification on Context
Let me know your thoughts. |
Yes. The current icons would still show up for items that do not have a picture yet (red pins).
The Media Details page. Like we do in Explore.
I see we already use Glide, so that sounds reasonable if necessary.
Sounds good!
This was an explanation of why this feature is beneficial, nothing special needed for this. :-) |
@nicolas-raoul Check this Record_2025-02-14-16-26-41.mp4Is this good, or should I do something else? Because if we need to show the Media Detail Pager in our app, then we have to fetch the image data. If we don’t need to show it in the Media Detail Pager, then I will raise the PR. You can also check this changes by running this branch: |
Your screencast looks fantastic! One minor detail: For red pins we probably do not need to try and load an image: we already know that there is no image. Feel free to raise the PR as is, though, this can be a separate enhancement. :-) |
I am also trying to implement the feature so that Wikidata opens in our app like the Explore section. Until then, the raised PR will handle this by redirecting the user to the website. Once I implement the in-app functionality, I will raise a new PR for that, as it will take some time to integrate Wikidata into the app like Explore. |
For instance, show a thumbnail of the image property Wikidata has for "Ukima" here:

It would:
Ideally, tapping that thumbnail could take the user to Media Details.
The text was updated successfully, but these errors were encountered: