Skip to content

Nearby: When tapping green pin, show picture thumbnail #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Feb 12, 2025 · 6 comments · Fixed by #6187
Closed

Nearby: When tapping green pin, show picture thumbnail #6182

nicolas-raoul opened this issue Feb 12, 2025 · 6 comments · Fixed by #6187
Assignees

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 12, 2025

For instance, show a thumbnail of the image property Wikidata has for "Ukima" here:
Screenshot_20250212-164608~2.png

It would:

  • Help users understand the task.
  • Show good examples.
  • Encourage users to fill the blanks, make them fedl that their Nearby upload are seen by others.

Ideally, tapping that thumbnail could take the user to Media Details.

@Sujal-Gupta-SG
Copy link
Contributor

I want to try it

@Sujal-Gupta-SG
Copy link
Contributor

Hi Nicolas,

I have a few questions regarding the issue I’m working on:

1. Thumbnail

  • Should we display a thumbnail of the nearby upload instead of the current icon?
  • Navigation on Click
    • When clicking on the thumbnail/icon, should it navigate to:
      • The Wikidata item link of the place on Browser?
      • The user’s contribution in the app?
      • Or something else?

2. Using Glide for Image Loading

  • Is it okay to use the Glide library to load images in the app?
  • Then I will first load a low-quality thumbnail, and when clicked, it will navigate to the Media Details page.

3. Clarification on Context

  • You mentioned:

    Help users understand the task.
    Show good examples.
    Encourage users to fill the blanks, make them feel that their Nearby upload is seen by others.

  • Could you clarify how we can best implement this in the current feature?

Let me know your thoughts.

@nicolas-raoul
Copy link
Member Author

Should we display a thumbnail of the nearby upload instead of the current icon?

Yes. The current icons would still show up for items that do not have a picture yet (red pins).

When clicking on the thumbnail/icon, should it navigate to:

The Media Details page. Like we do in Explore.

Is it okay to use the Glide library to load images in the app?

I see we already use Glide, so that sounds reasonable if necessary.
Please load the thumb URL rather than the full image, see https://github.com/commons-app/apps-android-commons/pull/6153/files

I will first load a low-quality thumbnail, and when clicked, it will navigate to the Media Details page.

Sounds good!

Could you clarify how we can best implement this in the current feature?

This was an explanation of why this feature is beneficial, nothing special needed for this. :-)

@Sujal-Gupta-SG
Copy link
Contributor

Sujal-Gupta-SG commented Feb 14, 2025

@nicolas-raoul Check this

Record_2025-02-14-16-26-41.mp4

Is this good, or should I do something else? Because if we need to show the Media Detail Pager in our app, then we have to fetch the image data.

If we don’t need to show it in the Media Detail Pager, then I will raise the PR.

You can also check this changes by running this branch:
Nearby - When tapping green pin, show picture thumbnail.

@nicolas-raoul
Copy link
Member Author

Your screencast looks fantastic!

One minor detail: For red pins we probably do not need to try and load an image: we already know that there is no image. Feel free to raise the PR as is, though, this can be a separate enhancement. :-)

@Sujal-Gupta-SG
Copy link
Contributor

I am also trying to implement the feature so that Wikidata opens in our app like the Explore section.

Until then, the raised PR will handle this by redirecting the user to the website.

Once I implement the in-app functionality, I will raise a new PR for that, as it will take some time to integrate Wikidata into the app like Explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants