[Bug]: Uploaded by shows what's in the source/author field, not the upload

[prototyperspective]

Summary

When browsing files, underneath each file it says "Uploaded by: " but it doesn't show the uploader but what's in the author or source field (I'll test which of those)

Steps to reproduce

1. Open the app and search for something or browse
2. See the "Uploaded by" underneath the files
3. (Go to the file page to check – open the file page in the browser to do so)

Expected behaviour

If it says "Uploaded by" it shouldn't show the author which could be an artist from 100 years ago but who uploaded it.

Actual behaviour

It shows the author or source (often bare HTML like <span title=British caricaturist and printm..) but not the uploader.

Device name

No response

Android version

Android 11

Commons app version

5.2.0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

[nicolas-raoul]

Good point!

We should probably show Author: rather than Uploaded by . @prototyperspective would that solve the issue?

Thanks!

[prototyperspective]

Yes. At low priority I'd consider making it an option which of the two or both should be shown since some users may be more interested in who uploaded things at first glance (if the author info is on the details page). If the uploader is the author, that would be in the |author= field too so yes I think that field would be the one that's best to show and would solve this issue.

[whym]

How about showing both author and uploader, if the two are different?

1. "By [UploaderName]" (when author = uploader)
2. "Created by [AuthorName], uploaded by [UploaderName]" (when author != uploader)
3. "Uploaded by [UploaderName]" (when author is missing)

For # 1, we can be more explicit and say "Created and uploaded by UploaderName", if that is more preferable.