Skip to content

Ask for location permissions at runtime for Nearby Places #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HonzaG opened this issue May 20, 2017 · 5 comments
Closed

Ask for location permissions at runtime for Nearby Places #650

HonzaG opened this issue May 20, 2017 · 5 comments

Comments

@HonzaG
Copy link

HonzaG commented May 20, 2017

While you use Nearby feature in new beta it doesnt show any nearby items; warning "No places nearby is shown instead. GPS on; Android 6.0

2017-05-20 14 27 55

@tobias47n9e
Copy link
Member

This could be related to this: #674

Moving around might solve the issue because the location is updated. But I am not totally sure how we currently do locations.

@tobias47n9e
Copy link
Member

I just tested this another time with the Android 7 emulator. For some reason the app ended up not having the location permissions. I had to manually go to the settings and allow the app to access the location. Maybe that is the cause of this issue?

screenshot from 2017-05-26 22-50-14

@misaochan
Copy link
Member

Interesting. The original implementation did ask for permissions at runtime - was this removed? If so, we definitely need to put permissions back in.

That being said, I don't think that is the sole cause of the issue. I was experiencing it to an extent with my phone in Svet Hub and in Jufa - going outside seemed to fix the problem for me, so I thought that it was just my hardware. But if other people are facing the same problem as well, then we do need to look into it further.

@misaochan
Copy link
Member

Tested a fresh install again and am experiencing the same issue as you guys - location permissions are not asked.

@tobias47n9e
Copy link
Member

Probably the same issue: #291

@misaochan misaochan changed the title Nearby doesnt work in beta Ask for location permissions at runtime for Nearby Places May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants