Skip to content

Replace ListView with RecyclerView #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veyndan opened this issue Jun 19, 2017 · 1 comment
Closed

Replace ListView with RecyclerView #743

veyndan opened this issue Jun 19, 2017 · 1 comment

Comments

@veyndan
Copy link
Contributor

veyndan commented Jun 19, 2017

ListView is basically deprecated and as we move to the future, RecyclerView should be used instead.

@psh
Copy link
Collaborator

psh commented Jul 9, 2017

Couple of things of note:

  1. Nearby will be a lot easier to jump into - it's just a single linear list of known Place objects
  2. There is no simple analog of the CursorAdapter in the world of RecyclerViews. This means there is a bunch of implied functionality behind the Contribution list view due to the ability to observe changed values out of the content provider.
  3. There is a nice (rich) model object hiding in the code waiting to be extracted. Doing so should reduce coupling of classes & fix a memory leak (follow all the calls to get activity() & where it's getting used)

1 & 2 obviously meet the needs of the issue, but 3 would improve the code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants