Fix #2194: Updated Nearby ⓘ icon to include 'Search this area' feature #2198
Conversation
There was a problem hiding this comment.
Because this is basically just wording and it was largely implemented by @neslihanturan, requesting her to review too.
domdomegg
changed the title
domdomegg
changed the title
| @@ -296,7 +296,7 @@ | |||
| <string name="retry">Retry</string> | |||
|
|
|||
| <string name="showcase_view_got_it_button">Got it!</string> | |||
| <string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles</string> | |||
| <string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'SEARCH THIS AREA\' locks the map and launches a nearby search around that location.</string> | |||
| <string name="showcase_view_list_icon">Tapping this button brings up a list of these places</string> | |||
There was a problem hiding this comment.
Hmm, I think locking the map is something only developers should know. But I am not sure what kind of message would be better. Let's wait some ideas from team.
There was a problem hiding this comment.
What about "...fixes the map at that location..."? Or maybe we can omit that part and just write that it launches a nearby search around that location?
There was a problem hiding this comment.
Lets discuss under #2194 so that everyone can follow.
|
What's going on with this PR - have we agreed on some wording for this yet @neslihanturan? |
|
I'm going to merge this for now given it's been here so long, if we need to change the wording we can open a new issue. |
Description (required)
Fixes #2194
What changes did you make and why?
Updated content of dialog box which opens up on clicking the i icon on the Nearby tab.
Tests performed (required)
Tested betaDebug on API 25.
Screenshots showing what changed