-
Notifications
You must be signed in to change notification settings - Fork 1.3k
resolved rtl issue in category #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
=========================================
- Coverage 5.89% 5.89% -0.01%
=========================================
Files 258 258
Lines 12310 12313 +3
Branches 1110 1111 +1
=========================================
Hits 726 726
- Misses 11525 11528 +3
Partials 59 59
Continue to review full report at Codecov.
|
Only judging from your screenshot: Checkboxes should be on the left and category names on the right, I believe? |
@nicolas-raoul, Sincere apologies I have misunderstood the Issue before :( .Here is the modified code. Kindly review the changes :) |
Looks good! |
I completely agree with you, this needs to be done. Aren't the localised category available from API? |
This is more or less the topic of #44, an issue opened 3 years ago :-) |
I just saw that |
Thanks for approving the PR @nicolas-raoul @maskaravivek :) |
Checbox visible at right in RTL languages and to left in ltr languages
Fixes #2566 Category suggestions wrong in RTL
Changes made
Checked whether configuration is for RTL if yes then modify checkbox layout for RTL
Screenshots showing what changed (optional - for UI changes)
