Skip to content

resolved rtl issue in category #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2019

Conversation

vanshikaarora
Copy link
Contributor

Checbox visible at right in RTL languages and to left in ltr languages

Fixes #2566 Category suggestions wrong in RTL

Changes made

Checked whether configuration is for RTL if yes then modify checkbox layout for RTL

Screenshots showing what changed (optional - for UI changes)
WhatsApp Image 2019-03-10 at 1 07 54 AM

@codecov-io
Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #2567 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2567      +/-   ##
=========================================
- Coverage    5.89%   5.89%   -0.01%     
=========================================
  Files         258     258              
  Lines       12310   12313       +3     
  Branches     1110    1111       +1     
=========================================
  Hits          726     726              
- Misses      11525   11528       +3     
  Partials       59      59
Impacted Files Coverage Δ
...e/nrw/commons/upload/UploadCategoriesRenderer.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c717ec...395c8b2. Read the comment docs.

@nicolas-raoul
Copy link
Member

Only judging from your screenshot: Checkboxes should be on the left and category names on the right, I believe?

@vanshikaarora
Copy link
Contributor Author

@nicolas-raoul, Sincere apologies I have misunderstood the Issue before :( .Here is the modified code. Kindly review the changes :)

@vanshikaarora
Copy link
Contributor Author

Updated Screenshot is here
WhatsApp Image 2019-03-11 at 4 29 36 PM

@nicolas-raoul
Copy link
Member

Looks good!
It will look even better when categories are localized or when we switch to Structured Commons, but that will be much much bigger change ^_^

@vanshikaarora
Copy link
Contributor Author

It will look even better when categories are localized

I completely agree with you, this needs to be done. Aren't the localised category available from API?

@nicolas-raoul
Copy link
Member

Aren't the localised category available from API?

This is more or less the topic of #44, an issue opened 3 years ago :-)

@maskaravivek maskaravivek merged commit 2e23658 into commons-app:master Mar 11, 2019
@vanshikaarora
Copy link
Contributor Author

This is more or less the topic of #44, an issue opened 3 years ago :-)

I just saw that
It would be great if this can be implemented, either by language setting after retrieving data from API. I'll look into that the issue.

@vanshikaarora
Copy link
Contributor Author

Thanks for approving the PR @nicolas-raoul @maskaravivek :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants