From 146921f66c489cd98bb95e7033b4f4b949e79fe8 Mon Sep 17 00:00:00 2001 From: Dan Garry Date: Sat, 18 May 2019 19:21:36 +0200 Subject: [PATCH] Remove unnecessary Integer.toString() calls In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability. --- .../nrw/commons/achievements/AchievementsActivity.java | 2 +- .../java/fr/free/nrw/commons/upload/UploadActivity.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java index 7b07df869e..38198b0242 100644 --- a/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java @@ -356,7 +356,7 @@ private void inflateAchievements(Achievements achievements) { (achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages()); imagesFeatured.setText(String.valueOf(achievements.getFeaturedImages())); String levelUpInfoString = getString(R.string.level); - levelUpInfoString += " " + Integer.toString(levelInfo.getLevelNumber()); + levelUpInfoString += " " + levelInfo.getLevelNumber(); levelNumber.setText(levelUpInfoString); imageView.setImageDrawable(VectorDrawableCompat.create(getResources(), R.drawable.badge, new ContextThemeWrapper(this, levelInfo.getLevelStyle()).getTheme())); diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java index a0fbda8e85..347d6e71c4 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java @@ -516,10 +516,10 @@ public void configurePrevButton(Boolean saveForPrevImage){ int descCount = directKvStore.getInt(name + "descCount"); for (int i = 0; i < descCount; i++) { Description description= new Description(); - String desc = directKvStore.getString(name + "description_<"+Integer.toString(i)+">"); + String desc = directKvStore.getString(name + "description_<" + i + ">"); description.setDescriptionText(desc); finalDesc.add(description); - int position = directKvStore.getInt(name + "spinnerPosition_<"+Integer.toString(i)+">"); + int position = directKvStore.getInt(name + "spinnerPosition_<" + i + ">"); description.setSelectedLanguageIndex(position); } prevTitleDecs.setOnTouchListener((v, event) -> { @@ -744,8 +744,8 @@ public void savePrevTitleDesc(String name){ int n = descriptionsAdapter.getItemCount() - 1; directKvStore.putInt(name + "descCount", n); for (int i = 0; i < n; i++) { - directKvStore.putString(name + "description_<"+Integer.toString(i)+">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText()); - directKvStore.putInt(name + "spinnerPosition_<" + Integer.toString(i) + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex()); + directKvStore.putString(name + "description_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText()); + directKvStore.putInt(name + "spinnerPosition_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex()); } } }