diff --git a/app/build.gradle b/app/build.gradle index 638a4048aa..08f322c055 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -21,7 +21,7 @@ dependencies { // Utils implementation 'in.yuvi:http.fluent:1.3' implementation 'com.google.code.gson:gson:2.8.5' - implementation 'com.squareup.okhttp3:okhttp:4.5.0' + implementation 'com.squareup.okhttp3:okhttp:4.8.0' implementation 'com.squareup.okio:okio:2.2.2' implementation 'io.reactivex.rxjava2:rxandroid:2.1.0' implementation 'io.reactivex.rxjava2:rxjava:2.2.3' @@ -50,6 +50,7 @@ dependencies { testImplementation "androidx.paging:paging-common-ktx:$PAGING_VERSION" implementation "androidx.paging:paging-rxjava2-ktx:$PAGING_VERSION" implementation "androidx.recyclerview:recyclerview:1.2.0-alpha02" + implementation 'com.squareup.okhttp3:okhttp-ws:3.4.1' // Logging implementation 'ch.acra:acra-dialog:5.3.0' @@ -79,7 +80,7 @@ dependencies { testImplementation 'junit:junit:4.13' testImplementation 'org.robolectric:robolectric:4.3' testImplementation 'androidx.test:core:1.2.0' - testImplementation 'com.squareup.okhttp3:mockwebserver:3.12.1' + testImplementation "com.squareup.okhttp3:mockwebserver:4.8.0" testImplementation "org.powermock:powermock-module-junit4:2.0.0-beta.5" testImplementation "org.powermock:powermock-api-mockito2:2.0.0-beta.5" testImplementation 'org.mockito:mockito-core:2.23.0' @@ -94,7 +95,7 @@ dependencies { androidTestImplementation 'androidx.test:runner:1.2.0' androidTestImplementation 'androidx.test:rules:1.2.0' androidTestImplementation 'androidx.annotation:annotation:1.1.0' - androidTestImplementation 'com.squareup.okhttp3:mockwebserver:3.12.1' + androidTestImplementation 'com.squareup.okhttp3:mockwebserver:4.8.0' androidTestUtil 'androidx.test:orchestrator:1.2.0' // Debugging diff --git a/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.java b/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.java index 23bbb85fe7..ee319ba9a4 100644 --- a/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.java @@ -56,6 +56,9 @@ public static void startYourself(Context context) { context.startActivity(intent); } + /** + * Set the tabs for the fragments + */ private void setTabs() { List fragmentList = new ArrayList<>(); List titleList = new ArrayList<>(); @@ -69,7 +72,6 @@ private void setTabs() { viewPagerAdapter.notifyDataSetChanged(); } - @Override public void onDestroy() { super.onDestroy(); diff --git a/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.java b/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.java index e536a950ad..cae28b4e71 100644 --- a/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardFragment.java @@ -97,6 +97,10 @@ private void setLeaderboard() { } } + /** + * Set the views + * @param response Leaderboard Response Object + */ private void setLeaderboardUser(LeaderboardResponse response) { hideProgressBar(); avatar.setImageURI( diff --git a/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardListAdapter.java b/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardListAdapter.java index 4a61a1cb19..25585fea1f 100644 --- a/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardListAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/profile/leaderboard/LeaderboardListAdapter.java @@ -32,6 +32,10 @@ public ListViewHolder(View itemView) { this.count = itemView.findViewById(R.id.user_count); } + /** + * This method will return the Context + * @return Context + */ public Context getContext() { return itemView.getContext(); } @@ -41,6 +45,12 @@ public LeaderboardListAdapter(List leaderboardList) { this.leaderboardList = leaderboardList; } + /** + * Overrides the onCreateViewHolder and inflates the recyclerview list item layout + * @param parent + * @param viewType + * @return + */ @NonNull @Override public LeaderboardListAdapter.ListViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) { @@ -50,6 +60,11 @@ public LeaderboardListAdapter.ListViewHolder onCreateViewHolder(@NonNull ViewGro return new ListViewHolder(view); } + /** + * Overrides the onBindViewHolder Set the view at the specific position with the specific value + * @param holder + * @param position + */ @Override public void onBindViewHolder(@NonNull LeaderboardListAdapter.ListViewHolder holder, int position) { TextView rank = holder.rank; @@ -66,6 +81,10 @@ public void onBindViewHolder(@NonNull LeaderboardListAdapter.ListViewHolder hold count.setText(leaderboardList.get(position).getCategoryCount().toString()); } + /** + * Override the getItemCount method + * @return the size of the recycler view list + */ @Override public int getItemCount() { return leaderboardList.size(); diff --git a/app/src/main/res/layout/fragment_leaderboard.xml b/app/src/main/res/layout/fragment_leaderboard.xml index b965e83db2..27f03eb5d9 100644 --- a/app/src/main/res/layout/fragment_leaderboard.xml +++ b/app/src/main/res/layout/fragment_leaderboard.xml @@ -8,7 +8,7 @@ + android:layout_height="wrap_content"> - + app:layout_constraintTop_toBottomOf="@+id/column_names"> + + + +