From 5c1b031655225678c5ab31719f9b3dcf1a29a924 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Mon, 6 Jan 2025 00:53:51 +0530
Subject: [PATCH 01/14] Rename Constants to Follow Kotlin Naming Conventions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

>This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase.

>Renamed the following constants in LoginActivity:
>saveProgressDialog → SAVE_PROGRESS_DIALOG
>saveErrorMessage → SAVE_ERROR_MESSAGE
>saveUsername → SAVE_USERNAME
>savePassword → SAVE_PASSWORD

>Updated all references to these constants throughout the project.
---
 .idea/inspectionProfiles/Project_Default.xml  | 52 +++++++++++++++++++
 .../fr/free/nrw/commons/auth/LoginActivity.kt | 26 +++++-----
 2 files changed, 65 insertions(+), 13 deletions(-)

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index f39734eb4b..ceea8c9643 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -2,11 +2,39 @@
   <profile version="1.0">
     <option name="myName" value="Project Default" />
     <inspection_tool class="ClassWithOnlyPrivateConstructors" enabled="true" level="WARNING" enabled_by_default="true" />
+    <inspection_tool class="ComposePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="ComposePreviewMustBeTopLevelFunction" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="ComposePreviewNeedsComposableAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="ComposePreviewNotSupportedInUnitTestFiles" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
     <inspection_tool class="ConfusingElse" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="reportWhenNoStatementFollow" value="true" />
     </inspection_tool>
     <inspection_tool class="ControlFlowStatementWithoutBraces" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ExplicitThis" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
+    <inspection_tool class="GlancePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="GlancePreviewMustBeTopLevelFunction" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="GlancePreviewNeedsComposableAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="GlancePreviewNotSupportedInUnitTestFiles" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+    </inspection_tool>
     <inspection_tool class="LocalCanBeFinal" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="REPORT_VARIABLES" value="true" />
       <option name="REPORT_PARAMETERS" value="true" />
@@ -20,6 +48,30 @@
     <inspection_tool class="OverlyStrongTypeCast" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="ignoreInMatchingInstanceof" value="false" />
     </inspection_tool>
+    <inspection_tool class="PreviewAnnotationInFunctionWithParameters" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="PreviewApiLevelMustBeValid" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="PreviewDeviceShouldUseNewSpec" enabled="true" level="WEAK WARNING" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="PreviewFontScaleMustBeGreaterThanZero" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="PreviewMultipleParameterProviders" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
+    <inspection_tool class="PreviewPickerAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
+      <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
+    </inspection_tool>
     <inspection_tool class="ProblematicWhitespace" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="RedundantFieldInitialization" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="RedundantImplements" enabled="true" level="WARNING" enabled_by_default="true">
diff --git a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt
index 47ee8588b5..75c4ac26dd 100644
--- a/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt
@@ -184,32 +184,32 @@ class LoginActivity : AccountAuthenticatorActivity() {
         // if progressDialog is visible during the configuration change  then store state as  true else false so that
         // we maintain visibility of progressDialog after configuration change
         if (progressDialog != null && progressDialog!!.isShowing) {
-            outState.putBoolean(saveProgressDialog, true)
+            outState.putBoolean(SAVE_PROGRESS_DIALOG, true)
         } else {
-            outState.putBoolean(saveProgressDialog, false)
+            outState.putBoolean(SAVE_PROGRESS_DIALOG, false)
         }
         outState.putString(
-            saveErrorMessage,
+            SAVE_ERROR_MESSAGE,
             binding!!.errorMessage.text.toString()
         ) //Save the errorMessage
         outState.putString(
-            saveUsername,
+            SAVE_USERNAME,
             binding!!.loginUsername.text.toString()
         ) // Save the username
         outState.putString(
-            savePassword,
+            SAVE_PASSWORD,
             binding!!.loginPassword.text.toString()
         ) // Save the password
     }
 
     override fun onRestoreInstanceState(savedInstanceState: Bundle) {
         super.onRestoreInstanceState(savedInstanceState)
-        binding!!.loginUsername.setText(savedInstanceState.getString(saveUsername))
-        binding!!.loginPassword.setText(savedInstanceState.getString(savePassword))
-        if (savedInstanceState.getBoolean(saveProgressDialog)) {
+        binding!!.loginUsername.setText(savedInstanceState.getString(SAVE_USERNAME))
+        binding!!.loginPassword.setText(savedInstanceState.getString(SAVE_PASSWORD))
+        if (savedInstanceState.getBoolean(SAVE_PROGRESS_DIALOG)) {
             performLogin()
         }
-        val errorMessage = savedInstanceState.getString(saveErrorMessage)
+        val errorMessage = savedInstanceState.getString(SAVE_ERROR_MESSAGE)
         if (sessionManager.isUserLoggedIn) {
             showMessage(R.string.login_success, R.color.primaryDarkColor)
         } else {
@@ -396,9 +396,9 @@ class LoginActivity : AccountAuthenticatorActivity() {
         fun startYourself(context: Context) =
             context.startActivity(Intent(context, LoginActivity::class.java))
 
-        const val saveProgressDialog: String = "ProgressDialog_state"
-        const val saveErrorMessage: String = "errorMessage"
-        const val saveUsername: String = "username"
-        const val savePassword: String = "password"
+        const val SAVE_PROGRESS_DIALOG: String = "ProgressDialog_state"
+        const val SAVE_ERROR_MESSAGE: String = "errorMessage"
+        const val SAVE_USERNAME: String = "username"
+        const val SAVE_PASSWORD: String = "password"
     }
 }

From 2f899ec05143d7d64fc590665957443f617eea8f Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Mon, 6 Jan 2025 13:17:51 +0530
Subject: [PATCH 02/14] Update Project_Default.xml

---
 .idea/inspectionProfiles/Project_Default.xml | 52 --------------------
 1 file changed, 52 deletions(-)

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index ceea8c9643..f39734eb4b 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -2,39 +2,11 @@
   <profile version="1.0">
     <option name="myName" value="Project Default" />
     <inspection_tool class="ClassWithOnlyPrivateConstructors" enabled="true" level="WARNING" enabled_by_default="true" />
-    <inspection_tool class="ComposePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ComposePreviewMustBeTopLevelFunction" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ComposePreviewNeedsComposableAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="ComposePreviewNotSupportedInUnitTestFiles" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
     <inspection_tool class="ConfusingElse" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="reportWhenNoStatementFollow" value="true" />
     </inspection_tool>
     <inspection_tool class="ControlFlowStatementWithoutBraces" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ExplicitThis" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
-    <inspection_tool class="GlancePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="GlancePreviewMustBeTopLevelFunction" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="GlancePreviewNeedsComposableAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="GlancePreviewNotSupportedInUnitTestFiles" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-    </inspection_tool>
     <inspection_tool class="LocalCanBeFinal" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="REPORT_VARIABLES" value="true" />
       <option name="REPORT_PARAMETERS" value="true" />
@@ -48,30 +20,6 @@
     <inspection_tool class="OverlyStrongTypeCast" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="ignoreInMatchingInstanceof" value="false" />
     </inspection_tool>
-    <inspection_tool class="PreviewAnnotationInFunctionWithParameters" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PreviewApiLevelMustBeValid" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PreviewDeviceShouldUseNewSpec" enabled="true" level="WEAK WARNING" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PreviewFontScaleMustBeGreaterThanZero" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PreviewMultipleParameterProviders" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
-    <inspection_tool class="PreviewPickerAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
-      <option name="composableFile" value="true" />
-      <option name="previewFile" value="true" />
-    </inspection_tool>
     <inspection_tool class="ProblematicWhitespace" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="RedundantFieldInitialization" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="RedundantImplements" enabled="true" level="WARNING" enabled_by_default="true">

From a7c1842b05874f46f1f72103ab2106cf6b364b82 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Thu, 9 Jan 2025 00:50:25 +0530
Subject: [PATCH 03/14] Refactor variable names to adhere to naming conventions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Renamed variables to use camel case:
-UPLOAD_COUNT_THRESHOLD → uploadCountThreshold
-REVERT_PERCENTAGE_FOR_MESSAGE → revertPercentageForMessage
-REVERT_SHARED_PREFERENCE → revertSharedPreference
-UPLOAD_SHARED_PREFERENCE → uploadSharedPreference

Renamed variables with uppercase initials to lowercase for alignment with Kotlin conventions:
-Latitude → latitude
-Longitude → longitude
-Accuracy → accuracy

Refactored the following variable names:
-NUMBER_OF_QUESTIONS → numberOfQuestions
-MULTIPLIER_TO_GET_PERCENTAGE → multiplierToGetPercentage
---
 .../coordinates/CoordinateEditHelper.kt       | 24 +++++++-------
 .../fr/free/nrw/commons/quiz/QuizChecker.kt   | 32 +++++++++----------
 .../nrw/commons/quiz/QuizResultActivity.kt    |  8 ++---
 3 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/coordinates/CoordinateEditHelper.kt b/app/src/main/java/fr/free/nrw/commons/coordinates/CoordinateEditHelper.kt
index 3095497c36..1bad2e2a50 100644
--- a/app/src/main/java/fr/free/nrw/commons/coordinates/CoordinateEditHelper.kt
+++ b/app/src/main/java/fr/free/nrw/commons/coordinates/CoordinateEditHelper.kt
@@ -61,16 +61,16 @@ class CoordinateEditHelper @Inject constructor(
     /**
      * Replaces new coordinates
      * @param media to be added
-     * @param Latitude to be added
-     * @param Longitude to be added
-     * @param Accuracy to be added
+     * @param latitude to be added
+     * @param longitude to be added
+     * @param accuracy to be added
      * @return Observable<Boolean>
      */
     private fun addCoordinates(
         media: Media,
-        Latitude: String,
-        Longitude: String,
-        Accuracy: String
+        latitude: String,
+        longitude: String,
+        accuracy: String
     ): Observable<Boolean>? {
         Timber.d("thread is coordinates adding %s", Thread.currentThread().getName())
         val summary = "Adding Coordinates"
@@ -83,9 +83,9 @@ class CoordinateEditHelper @Inject constructor(
                 .blockingGet()
         }
 
-        if (Latitude != null) {
-            buffer.append("\n{{Location|").append(Latitude).append("|").append(Longitude)
-                .append("|").append(Accuracy).append("}}")
+        if (latitude != null) {
+            buffer.append("\n{{Location|").append(latitude).append("|").append(longitude)
+                .append("|").append(accuracy).append("}}")
         }
 
         val editedLocation = buffer.toString()
@@ -141,7 +141,7 @@ class CoordinateEditHelper @Inject constructor(
      * @param media to be added
      * @param latitude to be added
      * @param longitude to be added
-     * @param Accuracy to be added
+     * @param accuracy to be added
      * @param result to be added
      * @return boolean
      */
@@ -150,7 +150,7 @@ class CoordinateEditHelper @Inject constructor(
         media: Media,
         latitude: String,
         longitude: String,
-        Accuracy: String,
+        accuracy: String,
         result: Boolean
     ): Boolean {
         val message: String
@@ -160,7 +160,7 @@ class CoordinateEditHelper @Inject constructor(
             media.coordinates = fr.free.nrw.commons.location.LatLng(
                 latitude.toDouble(),
                 longitude.toDouble(),
-                Accuracy.toFloat()
+                accuracy.toFloat()
             )
             title += ": " + context.getString(R.string.coordinates_edit_helper_show_edit_title_success)
             val coordinatesInMessage = StringBuilder()
diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt
index ec74ecf6f3..0183056a66 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizChecker.kt
@@ -40,10 +40,10 @@ class QuizChecker @Inject constructor(
 
     private val compositeDisposable = CompositeDisposable()
 
-    private val UPLOAD_COUNT_THRESHOLD = 5
-    private val REVERT_PERCENTAGE_FOR_MESSAGE = "50%"
-    private val REVERT_SHARED_PREFERENCE = "revertCount"
-    private val UPLOAD_SHARED_PREFERENCE = "uploadCount"
+    private val uploadCountThreshold = 5
+    private val revertPercentageForMessage = "50%"
+    private val revertSharedPreference = "revertCount"
+    private val uploadSharedPreference = "uploadCount"
 
     /**
      * Initializes quiz check by calculating revert parameters and showing quiz if necessary
@@ -80,12 +80,12 @@ class QuizChecker @Inject constructor(
      */
     private fun setTotalUploadCount(uploadCount: Int) {
         totalUploadCount = uploadCount - revertKvStore.getInt(
-            UPLOAD_SHARED_PREFERENCE,
+            uploadSharedPreference,
             0
         )
         if (totalUploadCount < 0) {
             totalUploadCount = 0
-            revertKvStore.putInt(UPLOAD_SHARED_PREFERENCE, 0)
+            revertKvStore.putInt(uploadSharedPreference, 0)
         }
         isUploadCountFetched = true
     }
@@ -112,10 +112,10 @@ class QuizChecker @Inject constructor(
      * @param revertCountFetched Count of deleted uploads
      */
     private fun setRevertParameter(revertCountFetched: Int) {
-        revertCount = revertCountFetched - revertKvStore.getInt(REVERT_SHARED_PREFERENCE, 0)
+        revertCount = revertCountFetched - revertKvStore.getInt(revertSharedPreference, 0)
         if (revertCount < 0) {
             revertCount = 0
-            revertKvStore.putInt(REVERT_SHARED_PREFERENCE, 0)
+            revertKvStore.putInt(revertSharedPreference, 0)
         }
         isRevertCountFetched = true
     }
@@ -128,13 +128,13 @@ class QuizChecker @Inject constructor(
         setRevertCount()
 
         if (revertCount < 0 || totalUploadCount < 0) {
-            revertKvStore.putInt(REVERT_SHARED_PREFERENCE, 0)
-            revertKvStore.putInt(UPLOAD_SHARED_PREFERENCE, 0)
+            revertKvStore.putInt(revertSharedPreference, 0)
+            revertKvStore.putInt(uploadSharedPreference, 0)
             return
         }
 
         if (isRevertCountFetched && isUploadCountFetched &&
-            totalUploadCount >= UPLOAD_COUNT_THRESHOLD &&
+            totalUploadCount >= uploadCountThreshold &&
             (revertCount * 100) / totalUploadCount >= 50
         ) {
             callQuiz(activity)
@@ -149,7 +149,7 @@ class QuizChecker @Inject constructor(
         DialogUtil.showAlertDialog(
             activity,
             activity.getString(R.string.quiz),
-            activity.getString(R.string.quiz_alert_message, REVERT_PERCENTAGE_FOR_MESSAGE),
+            activity.getString(R.string.quiz_alert_message, revertPercentageForMessage),
             activity.getString(R.string.about_translate_proceed),
             activity.getString(android.R.string.cancel),
             { startQuizActivity(activity) },
@@ -161,11 +161,11 @@ class QuizChecker @Inject constructor(
      * Starts the quiz activity and updates preferences for revert and upload counts
      */
     private fun startQuizActivity(activity: Activity) {
-        val newRevertSharedPrefs = revertCount + revertKvStore.getInt(REVERT_SHARED_PREFERENCE, 0)
-        revertKvStore.putInt(REVERT_SHARED_PREFERENCE, newRevertSharedPrefs)
+        val newRevertSharedPrefs = revertCount + revertKvStore.getInt(revertSharedPreference, 0)
+        revertKvStore.putInt(revertSharedPreference, newRevertSharedPrefs)
 
-        val newUploadCount = totalUploadCount + revertKvStore.getInt(UPLOAD_SHARED_PREFERENCE, 0)
-        revertKvStore.putInt(UPLOAD_SHARED_PREFERENCE, newUploadCount)
+        val newUploadCount = totalUploadCount + revertKvStore.getInt(uploadSharedPreference, 0)
+        revertKvStore.putInt(uploadSharedPreference, newUploadCount)
 
         val intent = Intent(activity, WelcomeActivity::class.java).apply {
             putExtra("isQuiz", true)
diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizResultActivity.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizResultActivity.kt
index 617f25a78e..0282da1904 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizResultActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizResultActivity.kt
@@ -30,8 +30,8 @@ import fr.free.nrw.commons.contributions.MainActivity
 class QuizResultActivity : AppCompatActivity() {
 
     private var binding: ActivityQuizResultBinding? = null
-    private val NUMBER_OF_QUESTIONS = 5
-    private val MULTIPLIER_TO_GET_PERCENTAGE = 20
+    private val numberOfQuestions = 5
+    private val multiplierToGetPercentage = 20
 
     public override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -67,9 +67,9 @@ class QuizResultActivity : AppCompatActivity() {
      */
     @SuppressLint("StringFormatInvalid", "SetTextI18n")
     fun setScore(score: Int) {
-        val scorePercent = score * MULTIPLIER_TO_GET_PERCENTAGE
+        val scorePercent = score * multiplierToGetPercentage
         binding?.resultProgressBar?.progress = scorePercent
-        binding?.tvResultProgress?.text = "$score / $NUMBER_OF_QUESTIONS"
+        binding?.tvResultProgress?.text = "$score / $numberOfQuestions"
         val message = resources.getString(R.string.congratulatory_message_quiz, "$scorePercent%")
         binding?.congratulatoryMessage?.text = message
     }

From 570ed58b6667879f3f86ed9c02044a5ea2802a43 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Fri, 10 Jan 2025 23:17:26 +0530
Subject: [PATCH 04/14] Refactor Dialog View Initialization with Null-Safe
 Calls

This PR refactors the dialog setup code in CustomSelectorActivity to improve safety and readability by replacing explicit casts with null-safe generic calls for findViewById.

>Replaced explicit casting (as Button and as TextView) with the generic findViewById<T>() method for improved type safety.
>Added null-safety (?.) to avoid potential crashes if a view is not found in the dialog layout.

why changed:-
>Prevents runtime crashes caused by NullPointerException when a view is missing in the layout.
---
 .../customselector/ui/selector/CustomSelectorActivity.kt    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt b/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt
index 52b615175e..4e2d58babe 100644
--- a/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt
@@ -271,7 +271,7 @@ class CustomSelectorActivity :
         dialog.setCancelable(false)
         dialog.requestWindowFeature(Window.FEATURE_NO_TITLE)
         dialog.setContentView(R.layout.custom_selector_info_dialog)
-        (dialog.findViewById(R.id.btn_ok) as Button).setOnClickListener { dialog.dismiss() }
+        (dialog.findViewById<Button>(R.id.btn_ok))?.setOnClickListener { dialog.dismiss() }
         dialog.show()
     }
 
@@ -687,8 +687,8 @@ class CustomSelectorActivity :
         dialog.setCancelable(false)
         dialog.requestWindowFeature(Window.FEATURE_NO_TITLE)
         dialog.setContentView(R.layout.custom_selector_limit_dialog)
-        (dialog.findViewById(R.id.btn_dismiss_limit_warning) as Button).setOnClickListener { dialog.dismiss() }
-        (dialog.findViewById(R.id.upload_limit_warning) as TextView).text =
+        (dialog.findViewById<Button>(R.id.btn_dismiss_limit_warning))?.setOnClickListener { dialog.dismiss() }
+        (dialog.findViewById<TextView>(R.id.upload_limit_warning))?.text =
             resources.getString(
                 R.string.custom_selector_over_limit_warning,
                 uploadLimit,

From abef27a7afb2d7e172853608f6f7487819eda1f9 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Sun, 12 Jan 2025 00:26:53 +0530
Subject: [PATCH 05/14] Refactor Unit Test: Replace Unsafe Casting with
 Type-Safe Mocking for findViewById

>PR refactors the unit test for NearbyParentFragment by replacing unsafe casting in the findViewById mocking statements with type-safe

>Ensured all findViewById mocks now use a consistent, type-safe format (findViewById<View>(...)) to reduce verbosity and potential casting errors.

>Verified the functionality of prepareViewsForSheetPosition remains unchanged, ensuring no regression in test behavior.
---
 .../nrw/commons/nearby/NearbyParentFragmentUnitTest.kt    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
index 7fb3ba8bde..65c4da2828 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
@@ -333,8 +333,8 @@ class NearbyParentFragmentUnitTest {
     fun testPrepareViewsForSheetPositionCaseCollapsed() {
         Whitebox.setInternalState(fragment, "isFABsExpanded", true)
         Whitebox.setInternalState(fragment, "mView", view)
-        whenever(view.findViewById(R.id.empty_view) as View?).thenReturn(view)
-        whenever(view.findViewById(R.id.empty_view1) as View?).thenReturn(view)
+        whenever(view.findViewById<View>(R.id.empty_view)).thenReturn(view)
+        whenever(view.findViewById<View>(R.id.empty_view1)).thenReturn(view)
         whenever(view.id).thenReturn(0)
         fragment.prepareViewsForSheetPosition(BottomSheetBehavior.STATE_COLLAPSED)
         verify(fab).isShown
@@ -345,8 +345,8 @@ class NearbyParentFragmentUnitTest {
     fun testPrepareViewsForSheetPositionCaseHidden() {
         Whitebox.setInternalState(fragment, "isFABsExpanded", true)
         Whitebox.setInternalState(fragment, "mView", view)
-        whenever(view.findViewById(R.id.empty_view) as View?).thenReturn(view)
-        whenever(view.findViewById(R.id.empty_view1) as View?).thenReturn(view)
+        whenever(view.findViewById<View>(R.id.empty_view)).thenReturn(view)
+        whenever(view.findViewById<View>(R.id.empty_view1)).thenReturn(view)
         whenever(view.id).thenReturn(0)
         whenever(fab.layoutParams).thenReturn(mock(CoordinatorLayout.LayoutParams::class.java))
         fragment.prepareViewsForSheetPosition(BottomSheetBehavior.STATE_HIDDEN)

From f2ef4bb43462471ae7b432ce49f67f1915fda108 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Sun, 12 Jan 2025 01:03:28 +0530
Subject: [PATCH 06/14] Update NearbyParentFragmentUnitTest.kt

---
 .../nrw/commons/nearby/NearbyParentFragmentUnitTest.kt    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
index 65c4da2828..7fb3ba8bde 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentUnitTest.kt
@@ -333,8 +333,8 @@ class NearbyParentFragmentUnitTest {
     fun testPrepareViewsForSheetPositionCaseCollapsed() {
         Whitebox.setInternalState(fragment, "isFABsExpanded", true)
         Whitebox.setInternalState(fragment, "mView", view)
-        whenever(view.findViewById<View>(R.id.empty_view)).thenReturn(view)
-        whenever(view.findViewById<View>(R.id.empty_view1)).thenReturn(view)
+        whenever(view.findViewById(R.id.empty_view) as View?).thenReturn(view)
+        whenever(view.findViewById(R.id.empty_view1) as View?).thenReturn(view)
         whenever(view.id).thenReturn(0)
         fragment.prepareViewsForSheetPosition(BottomSheetBehavior.STATE_COLLAPSED)
         verify(fab).isShown
@@ -345,8 +345,8 @@ class NearbyParentFragmentUnitTest {
     fun testPrepareViewsForSheetPositionCaseHidden() {
         Whitebox.setInternalState(fragment, "isFABsExpanded", true)
         Whitebox.setInternalState(fragment, "mView", view)
-        whenever(view.findViewById<View>(R.id.empty_view)).thenReturn(view)
-        whenever(view.findViewById<View>(R.id.empty_view1)).thenReturn(view)
+        whenever(view.findViewById(R.id.empty_view) as View?).thenReturn(view)
+        whenever(view.findViewById(R.id.empty_view1) as View?).thenReturn(view)
         whenever(view.id).thenReturn(0)
         whenever(fab.layoutParams).thenReturn(mock(CoordinatorLayout.LayoutParams::class.java))
         fragment.prepareViewsForSheetPosition(BottomSheetBehavior.STATE_HIDDEN)

From 7edf3938aa7ff2c0ff9114d0bfbe8e76515ca875 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Mon, 13 Jan 2025 20:21:26 +0530
Subject: [PATCH 07/14] Refactor: Rename Constants to Follow CamelCase Naming
 Convention

>Updated all constant variable names to follow the camelCase naming convention, removing underscores in the middle or end.

>Ensured variable names remain descriptive and align with code readability best practices.
---
 .../free/nrw/commons/quiz/QuizController.kt   | 20 +++++++++----------
 .../free/nrw/commons/review/ReviewActivity.kt |  8 ++++----
 .../nrw/commons/review/ReviewImageFragment.kt |  6 +++---
 .../nrw/commons/settings/SettingsFragment.kt  |  4 ++--
 .../commons/upload/ImageProcessingService.kt  |  5 ++---
 .../nrw/commons/utils/SwipableCardView.kt     |  4 ++--
 6 files changed, 23 insertions(+), 24 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
index 3cb4f52a67..9a3fce02e1 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
@@ -14,17 +14,17 @@ class QuizController {
 
     private val quiz: ArrayList<QuizQuestion> = ArrayList()
 
-    private val URL_FOR_SELFIE = "https://i.imgur.com/0fMYcpM.jpg"
-    private val URL_FOR_TAJ_MAHAL = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
-    private val URL_FOR_BLURRY_IMAGE = "https://i.imgur.com/Kepb5jR.jpg"
-    private val URL_FOR_SCREENSHOT = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
-    private val URL_FOR_EVENT = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
+    private val urlForSelfie = "https://i.imgur.com/0fMYcpM.jpg"
+    private val urlForTajMahal = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
+    private val urlForBlurryImage = "https://i.imgur.com/Kepb5jR.jpg"
+    private val urlForScreenshot = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
+    private val urlForEvent = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
 
     fun initialize(context: Context) {
         val q1 = QuizQuestion(
             1,
             context.getString(R.string.quiz_question_string),
-            URL_FOR_SELFIE,
+            urlForSelfie,
             false,
             context.getString(R.string.selfie_answer)
         )
@@ -33,7 +33,7 @@ class QuizController {
         val q2 = QuizQuestion(
             2,
             context.getString(R.string.quiz_question_string),
-            URL_FOR_TAJ_MAHAL,
+            urlForTajMahal,
             true,
             context.getString(R.string.taj_mahal_answer)
         )
@@ -42,7 +42,7 @@ class QuizController {
         val q3 = QuizQuestion(
             3,
             context.getString(R.string.quiz_question_string),
-            URL_FOR_BLURRY_IMAGE,
+            urlForBlurryImage,
             false,
             context.getString(R.string.blurry_image_answer)
         )
@@ -51,7 +51,7 @@ class QuizController {
         val q4 = QuizQuestion(
             4,
             context.getString(R.string.quiz_screenshot_question),
-            URL_FOR_SCREENSHOT,
+            urlForScreenshot,
             false,
             context.getString(R.string.screenshot_answer)
         )
@@ -60,7 +60,7 @@ class QuizController {
         val q5 = QuizQuestion(
             5,
             context.getString(R.string.quiz_question_string),
-            URL_FOR_EVENT,
+            urlForEvent,
             true,
             context.getString(R.string.construction_event_answer)
         )
diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.kt b/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.kt
index 40eb24ed02..209f991fb1 100644
--- a/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.kt
@@ -45,12 +45,12 @@ class ReviewActivity : BaseActivity() {
     private var hasNonHiddenCategories = false
     var media: Media? = null
 
-    private val SAVED_MEDIA = "saved_media"
+    private val savedMedia = "saved_media"
 
     override fun onSaveInstanceState(outState: Bundle) {
         super.onSaveInstanceState(outState)
         media?.let {
-            outState.putParcelable(SAVED_MEDIA, it)
+            outState.putParcelable(savedMedia, it)
         }
     }
 
@@ -90,8 +90,8 @@ class ReviewActivity : BaseActivity() {
             PorterDuff.Mode.SRC_IN
         )
 
-        if (savedInstanceState?.getParcelable<Media>(SAVED_MEDIA) != null) {
-            updateImage(savedInstanceState.getParcelable(SAVED_MEDIA)!!)
+        if (savedInstanceState?.getParcelable<Media>(savedMedia) != null) {
+            updateImage(savedInstanceState.getParcelable(savedMedia)!!)
             setUpMediaDetailOnOrientation()
         } else {
             runRandomizer()
diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.kt b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.kt
index f6da76bba7..2bc3335058 100644
--- a/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.kt
+++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.kt
@@ -31,7 +31,7 @@ class ReviewImageFragment : CommonsDaggerSupportFragment() {
     lateinit var sessionManager: SessionManager
 
     // Constant variable used to store user's key name for onSaveInstanceState method
-    private val SAVED_USER = "saved_user"
+    private val savedUser = "saved_user"
 
     // Variable that stores the value of user
     private var user: String? = null
@@ -129,7 +129,7 @@ class ReviewImageFragment : CommonsDaggerSupportFragment() {
                 question = getString(R.string.review_thanks)
 
                 user = reviewActivity.reviewController.firstRevision?.user()
-                    ?: savedInstanceState?.getString(SAVED_USER)
+                    ?: savedInstanceState?.getString(savedUser)
 
                 //if the user is null because of whatsoever reason, review will not be sent anyways
                 if (!user.isNullOrEmpty()) {
@@ -172,7 +172,7 @@ class ReviewImageFragment : CommonsDaggerSupportFragment() {
     override fun onSaveInstanceState(outState: Bundle) {
         super.onSaveInstanceState(outState)
         //Save user name when configuration changes happen
-        outState.putString(SAVED_USER, user)
+        outState.putString(savedUser, user)
     }
 
     private val reviewCallback: ReviewController.ReviewCallback
diff --git a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
index 2f293937c6..d899b57ae0 100644
--- a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
+++ b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
@@ -85,7 +85,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
     private var languageHistoryListView: ListView? = null
 
     private lateinit var inAppCameraLocationPermissionLauncher: ActivityResultLauncher<Array<String>>
-    private val GET_CONTENT_PICKER_HELP_URL = "https://commons-app.github.io/docs.html#get-content"
+    private val getContentPickerHelpUrl = "https://commons-app.github.io/docs.html#get-content"
 
     private val cameraPickLauncherForResult: ActivityResultLauncher<Intent> =
         registerForActivityResult(StartActivityForResult()) { result ->
@@ -297,7 +297,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
             getString(R.string.ok),
             getString(R.string.read_help_link),
             { },
-            { Utils.handleWebUrl(requireContext(), Uri.parse(GET_CONTENT_PICKER_HELP_URL)) },
+            { Utils.handleWebUrl(requireContext(), Uri.parse(getContentPickerHelpUrl)) },
             null
         )
     }
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/ImageProcessingService.kt b/app/src/main/java/fr/free/nrw/commons/upload/ImageProcessingService.kt
index ba9dc147c1..fca10be1e4 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/ImageProcessingService.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/ImageProcessingService.kt
@@ -10,7 +10,6 @@ import fr.free.nrw.commons.utils.ImageUtils.IMAGE_KEEP
 import fr.free.nrw.commons.utils.ImageUtils.IMAGE_OK
 import fr.free.nrw.commons.utils.ImageUtilsWrapper
 import io.reactivex.Single
-import io.reactivex.functions.Function
 import io.reactivex.schedulers.Schedulers
 import org.apache.commons.lang3.StringUtils
 import timber.log.Timber
@@ -26,7 +25,7 @@ class ImageProcessingService @Inject constructor(
     private val fileUtilsWrapper: FileUtilsWrapper,
     private val imageUtilsWrapper: ImageUtilsWrapper,
     private val readFBMD: ReadFBMD,
-    private val EXIFReader: EXIFReader,
+    private val exifReader: EXIFReader,
     private val mediaClient: MediaClient
 ) {
     /**
@@ -94,7 +93,7 @@ class ImageProcessingService @Inject constructor(
      * the presence of some basic Exif metadata.
      */
     private fun checkEXIF(filepath: String): Single<Int> =
-        EXIFReader.processMetadata(filepath)
+        exifReader.processMetadata(filepath)
 
 
     /**
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
index 5a8261c24f..def94c38a3 100644
--- a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
+++ b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
@@ -23,7 +23,7 @@ abstract class SwipableCardView @JvmOverloads constructor(
 
     private var x1 = 0f
     private var x2 = 0f
-    private val MINIMUM_THRESHOLD_FOR_SWIPE = 100f
+    private val minimumThresholdForSwipe = 100f
 
     init {
         interceptOnTouchListener()
@@ -45,7 +45,7 @@ abstract class SwipableCardView @JvmOverloads constructor(
                     isSwipe = deltaX != 0f
                 }
             }
-            if (isSwipe && pixelToDp(abs(deltaX)) > MINIMUM_THRESHOLD_FOR_SWIPE) {
+            if (isSwipe && pixelToDp(abs(deltaX)) > minimumThresholdForSwipe) {
                 onSwipe(v)
                 return@setOnTouchListener true
             }

From 8a76209788d589737644280dbd09f636419df64b Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Wed, 15 Jan 2025 19:49:20 +0530
Subject: [PATCH 08/14] Replace private val with const val for URL constants in
 QuizController

---
 .../fr/free/nrw/commons/quiz/QuizController.kt     | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
index 9a3fce02e1..64be27934e 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
@@ -14,11 +14,15 @@ class QuizController {
 
     private val quiz: ArrayList<QuizQuestion> = ArrayList()
 
-    private val urlForSelfie = "https://i.imgur.com/0fMYcpM.jpg"
-    private val urlForTajMahal = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
-    private val urlForBlurryImage = "https://i.imgur.com/Kepb5jR.jpg"
-    private val urlForScreenshot = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
-    private val urlForEvent = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
+    companion object{
+
+        const val urlForSelfie = "https://i.imgur.com/0fMYcpM.jpg"
+        const val urlForTajMahal = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
+        const val urlForBlurryImage = "https://i.imgur.com/Kepb5jR.jpg"
+        const val urlForScreenshot = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
+        const val urlForEvent = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
+    }
+
 
     fun initialize(context: Context) {
         val q1 = QuizQuestion(

From d4de3cd337e893b5a8c26a5e62e21526d571a960 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Thu, 16 Jan 2025 19:44:03 +0530
Subject: [PATCH 09/14] Renaming the constant to use UPPER_SNAKE_CASE

---
 .../free/nrw/commons/quiz/QuizController.kt   | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
index 64be27934e..72c80a2a37 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
@@ -16,11 +16,11 @@ class QuizController {
 
     companion object{
 
-        const val urlForSelfie = "https://i.imgur.com/0fMYcpM.jpg"
-        const val urlForTajMahal = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
-        const val urlForBlurryImage = "https://i.imgur.com/Kepb5jR.jpg"
-        const val urlForScreenshot = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
-        const val urlForEvent = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
+        const val URL_FOR_SELFIE = "https://i.imgur.com/0fMYcpM.jpg"
+        const val URL_FOR_TAJ_MAHAL = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
+        const val URL_FOR_BLURRY_IMAGE = "https://i.imgur.com/Kepb5jR.jpg"
+        const val URL_FOR_SCREENSHOT = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
+        const val RL_FOR_EVENT = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
     }
 
 
@@ -28,7 +28,7 @@ class QuizController {
         val q1 = QuizQuestion(
             1,
             context.getString(R.string.quiz_question_string),
-            urlForSelfie,
+            URL_FOR_SELFIE,
             false,
             context.getString(R.string.selfie_answer)
         )
@@ -37,7 +37,7 @@ class QuizController {
         val q2 = QuizQuestion(
             2,
             context.getString(R.string.quiz_question_string),
-            urlForTajMahal,
+            URL_FOR_TAJ_MAHAL,
             true,
             context.getString(R.string.taj_mahal_answer)
         )
@@ -46,7 +46,7 @@ class QuizController {
         val q3 = QuizQuestion(
             3,
             context.getString(R.string.quiz_question_string),
-            urlForBlurryImage,
+            URL_FOR_BLURRY_IMAGE,
             false,
             context.getString(R.string.blurry_image_answer)
         )
@@ -55,7 +55,7 @@ class QuizController {
         val q4 = QuizQuestion(
             4,
             context.getString(R.string.quiz_screenshot_question),
-            urlForScreenshot,
+            URL_FOR_SCREENSHOT,
             false,
             context.getString(R.string.screenshot_answer)
         )
@@ -64,7 +64,7 @@ class QuizController {
         val q5 = QuizQuestion(
             5,
             context.getString(R.string.quiz_question_string),
-            urlForEvent,
+            RL_FOR_EVENT,
             true,
             context.getString(R.string.construction_event_answer)
         )

From 0c8763bc04a9693c24f2eef93fe10acc24e2c4bc Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Thu, 16 Jan 2025 19:50:10 +0530
Subject: [PATCH 10/14] Renaming the constant to use UPPER_SNAKE_CASE

---
 app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
index 72c80a2a37..d9b6b7e52c 100644
--- a/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
+++ b/app/src/main/java/fr/free/nrw/commons/quiz/QuizController.kt
@@ -20,7 +20,7 @@ class QuizController {
         const val URL_FOR_TAJ_MAHAL = "https://upload.wikimedia.org/wikipedia/commons/1/15/Taj_Mahal-03.jpg"
         const val URL_FOR_BLURRY_IMAGE = "https://i.imgur.com/Kepb5jR.jpg"
         const val URL_FOR_SCREENSHOT = "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Social_media_app_mockup_screenshot.svg/500px-Social_media_app_mockup_screenshot.svg.png"
-        const val RL_FOR_EVENT = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
+        const val URL_FOR_EVENT = "https://upload.wikimedia.org/wikipedia/commons/5/51/HouseBuildingInNorthernVietnam.jpg"
     }
 
 
@@ -64,7 +64,7 @@ class QuizController {
         val q5 = QuizQuestion(
             5,
             context.getString(R.string.quiz_question_string),
-            RL_FOR_EVENT,
+            URL_FOR_EVENT,
             true,
             context.getString(R.string.construction_event_answer)
         )

From 7d6a46097cb1332fb5b25db1b8ded90171a51baa Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Thu, 16 Jan 2025 20:36:26 +0530
Subject: [PATCH 11/14] Update Done

---
 .../java/fr/free/nrw/commons/settings/SettingsFragment.kt     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
index d899b57ae0..f73d53e9d7 100644
--- a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
+++ b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt
@@ -85,7 +85,6 @@ class SettingsFragment : PreferenceFragmentCompat() {
     private var languageHistoryListView: ListView? = null
 
     private lateinit var inAppCameraLocationPermissionLauncher: ActivityResultLauncher<Array<String>>
-    private val getContentPickerHelpUrl = "https://commons-app.github.io/docs.html#get-content"
 
     private val cameraPickLauncherForResult: ActivityResultLauncher<Intent> =
         registerForActivityResult(StartActivityForResult()) { result ->
@@ -297,7 +296,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
             getString(R.string.ok),
             getString(R.string.read_help_link),
             { },
-            { Utils.handleWebUrl(requireContext(), Uri.parse(getContentPickerHelpUrl)) },
+            { Utils.handleWebUrl(requireContext(), Uri.parse(GET_CONTENT_PICKER_HELP_URL)) },
             null
         )
     }
@@ -511,6 +510,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
 
     @Suppress("LongLine")
     companion object {
+        const val GET_CONTENT_PICKER_HELP_URL = "https://commons-app.github.io/docs.html#get-content"
         private const val VANISH_ACCOUNT_URL = "https://meta.m.wikimedia.org/wiki/Special:Contact/accountvanishapps"
         private const val VANISH_ACCOUNT_SUCCESS_URL = "https://meta.m.wikimedia.org/wiki/Special:GlobalVanishRequest/vanished"
         /**

From cb41668cc58924a58e0dd7700d64ed1651ffda79 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Fri, 17 Jan 2025 19:38:37 +0530
Subject: [PATCH 12/14] **Refactor: Convert `minimumThresholdForSwipe` to a
 compile-time constant**

---
 .../java/fr/free/nrw/commons/utils/SwipableCardView.kt   | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
index def94c38a3..bde575386e 100644
--- a/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
+++ b/app/src/main/java/fr/free/nrw/commons/utils/SwipableCardView.kt
@@ -21,9 +21,14 @@ abstract class SwipableCardView @JvmOverloads constructor(
     defStyleAttr: Int = 0
 ) : CardView(context, attrs, defStyleAttr) {
 
+
+    companion object{
+        const val MINIMUM_THRESHOLD_FOR_SWIPE = 100f
+    }
+
     private var x1 = 0f
     private var x2 = 0f
-    private val minimumThresholdForSwipe = 100f
+
 
     init {
         interceptOnTouchListener()
@@ -45,7 +50,7 @@ abstract class SwipableCardView @JvmOverloads constructor(
                     isSwipe = deltaX != 0f
                 }
             }
-            if (isSwipe && pixelToDp(abs(deltaX)) > minimumThresholdForSwipe) {
+            if (isSwipe && pixelToDp(abs(deltaX)) > MINIMUM_THRESHOLD_FOR_SWIPE) {
                 onSwipe(v)
                 return@setOnTouchListener true
             }

From dbe14f9c1c231ecc813543e32621825252752be0 Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Sun, 26 Jan 2025 00:31:50 +0530
Subject: [PATCH 13/14] Convert AboutActivity from Java to Kotlin

This PR converts the AboutActivity class from Java to Kotlin

>Testing:
>Verified all functionalities of the AboutActivity, including toolbar setup, intent launches, and dialog interactions, to ensure behavior remains consistent post-conversion.
>Successfully ran unit tests for AboutActivity to confirm the correctness of methods and logic.
---
 .../fr/free/nrw/commons/AboutActivity.java    | 187 --------------
 .../java/fr/free/nrw/commons/AboutActivity.kt | 244 ++++++++++++++++++
 2 files changed, 244 insertions(+), 187 deletions(-)
 delete mode 100644 app/src/main/java/fr/free/nrw/commons/AboutActivity.java
 create mode 100644 app/src/main/java/fr/free/nrw/commons/AboutActivity.kt

diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java b/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
deleted file mode 100644
index dcc9bfd435..0000000000
--- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.java
+++ /dev/null
@@ -1,187 +0,0 @@
-package fr.free.nrw.commons;
-
-import android.annotation.SuppressLint;
-import android.content.Intent;
-import android.net.Uri;
-import android.os.Bundle;
-import android.view.Menu;
-import android.view.MenuInflater;
-import android.view.MenuItem;
-import android.view.View;
-import android.widget.ArrayAdapter;
-import android.widget.LinearLayout;
-import android.widget.Spinner;
-import androidx.annotation.NonNull;
-import fr.free.nrw.commons.databinding.ActivityAboutBinding;
-import fr.free.nrw.commons.theme.BaseActivity;
-import fr.free.nrw.commons.utils.ConfigUtils;
-import fr.free.nrw.commons.utils.DialogUtil;
-import java.util.Collections;
-import java.util.List;
-
-/**
- * Represents about screen of this app
- */
-public class AboutActivity extends BaseActivity {
-
-    /*
-      This View Binding class is auto-generated for each xml file. The format is usually the name
-      of the file with PascalCasing (The underscore characters will be ignored).
-      More information is available at https://developer.android.com/topic/libraries/view-binding
-     */
-    private ActivityAboutBinding binding;
-
-    /**
-     * This method helps in the creation About screen
-     *
-     * @param savedInstanceState Data bundle
-     */
-    @Override
-    @SuppressLint("StringFormatInvalid")
-    public void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-
-        /*
-          Instead of just setting the view with the xml file. We need to use View Binding class.
-         */
-        binding = ActivityAboutBinding.inflate(getLayoutInflater());
-        final View view = binding.getRoot();
-        setContentView(view);
-
-        setSupportActionBar(binding.toolbarBinding.toolbar);
-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
-        final String aboutText = getString(R.string.about_license);
-        /*
-          We can then access all the views by just using the id names like this.
-          camelCasing is used with underscore characters being ignored.
-         */
-        binding.aboutLicense.setHtmlText(aboutText);
-
-        @SuppressLint("StringFormatMatches")
-        String improveText = String.format(getString(R.string.about_improve), Urls.NEW_ISSUE_URL);
-        binding.aboutImprove.setHtmlText(improveText);
-        binding.aboutVersion.setText(ConfigUtils.getVersionNameWithSha(getApplicationContext()));
-
-        Utils.setUnderlinedText(binding.aboutFaq, R.string.about_faq, getApplicationContext());
-        Utils.setUnderlinedText(binding.aboutRateUs, R.string.about_rate_us, getApplicationContext());
-        Utils.setUnderlinedText(binding.aboutUserGuide, R.string.user_guide, getApplicationContext());
-        Utils.setUnderlinedText(binding.aboutPrivacyPolicy, R.string.about_privacy_policy, getApplicationContext());
-        Utils.setUnderlinedText(binding.aboutTranslate, R.string.about_translate, getApplicationContext());
-        Utils.setUnderlinedText(binding.aboutCredits, R.string.about_credits, getApplicationContext());
-
-        /*
-          To set listeners, we can create a separate method and use lambda syntax.
-        */
-        binding.facebookLaunchIcon.setOnClickListener(this::launchFacebook);
-        binding.githubLaunchIcon.setOnClickListener(this::launchGithub);
-        binding.websiteLaunchIcon.setOnClickListener(this::launchWebsite);
-        binding.aboutRateUs.setOnClickListener(this::launchRatings);
-        binding.aboutCredits.setOnClickListener(this::launchCredits);
-        binding.aboutPrivacyPolicy.setOnClickListener(this::launchPrivacyPolicy);
-        binding.aboutUserGuide.setOnClickListener(this::launchUserGuide);
-        binding.aboutFaq.setOnClickListener(this::launchFrequentlyAskedQuesions);
-        binding.aboutTranslate.setOnClickListener(this::launchTranslate);
-    }
-
-    @Override
-    public boolean onSupportNavigateUp() {
-        onBackPressed();
-        return true;
-    }
-
-    public void launchFacebook(View view) {
-        Intent intent;
-        try {
-            intent = new Intent(Intent.ACTION_VIEW, Uri.parse(Urls.FACEBOOK_APP_URL));
-            intent.setPackage(Urls.FACEBOOK_PACKAGE_NAME);
-            startActivity(intent);
-        } catch (Exception e) {
-            Utils.handleWebUrl(this, Uri.parse(Urls.FACEBOOK_WEB_URL));
-        }
-    }
-
-    public void launchGithub(View view) {
-        Intent intent;
-        try {
-            intent = new Intent(Intent.ACTION_VIEW, Uri.parse(Urls.GITHUB_REPO_URL));
-            intent.setPackage(Urls.GITHUB_PACKAGE_NAME);
-            startActivity(intent);
-        } catch (Exception e) {
-            Utils.handleWebUrl(this, Uri.parse(Urls.GITHUB_REPO_URL));
-        }
-    }
-
-    public void launchWebsite(View view) {
-        Utils.handleWebUrl(this, Uri.parse(Urls.WEBSITE_URL));
-    }
-
-    public void launchRatings(View view){
-        Utils.rateApp(this);
-    }
-
-    public void launchCredits(View view) {
-        Utils.handleWebUrl(this, Uri.parse(Urls.CREDITS_URL));
-    }
-
-    public void launchUserGuide(View view) {
-        Utils.handleWebUrl(this, Uri.parse(Urls.USER_GUIDE_URL));
-    }
-
-    public void launchPrivacyPolicy(View view) {
-        Utils.handleWebUrl(this, Uri.parse(BuildConfig.PRIVACY_POLICY_URL));
-    }
-
-    public void launchFrequentlyAskedQuesions(View view) {
-        Utils.handleWebUrl(this, Uri.parse(Urls.FAQ_URL));
-    }
-
-    @Override
-    public boolean onCreateOptionsMenu(Menu menu) {
-        MenuInflater inflater = getMenuInflater();
-        inflater.inflate(R.menu.menu_about, menu);
-        return super.onCreateOptionsMenu(menu);
-    }
-
-    @Override
-    public boolean onOptionsItemSelected(MenuItem item) {
-        switch (item.getItemId()) {
-            case R.id.share_app_icon:
-                String shareText = String.format(getString(R.string.share_text), Urls.PLAY_STORE_URL_PREFIX + this.getPackageName());
-                Intent sendIntent = new Intent();
-                sendIntent.setAction(Intent.ACTION_SEND);
-                sendIntent.putExtra(Intent.EXTRA_TEXT, shareText);
-                sendIntent.setType("text/plain");
-                startActivity(Intent.createChooser(sendIntent, getString(R.string.share_via)));
-                return true;
-            default:
-                return super.onOptionsItemSelected(item);
-        }
-    }
-
-    public void launchTranslate(View view) {
-        @NonNull List<String> sortedLocalizedNamesRef = CommonsApplication.getInstance().getLanguageLookUpTable().getCanonicalNames();
-        Collections.sort(sortedLocalizedNamesRef);
-        final ArrayAdapter<String> languageAdapter = new ArrayAdapter<>(AboutActivity.this,
-                android.R.layout.simple_spinner_dropdown_item, sortedLocalizedNamesRef);
-        final Spinner spinner = new Spinner(AboutActivity.this);
-        spinner.setLayoutParams(new LinearLayout.LayoutParams(LinearLayout.LayoutParams.WRAP_CONTENT, LinearLayout.LayoutParams.WRAP_CONTENT));
-        spinner.setAdapter(languageAdapter);
-        spinner.setGravity(17);
-        spinner.setPadding(50,0,0,0);
-
-        Runnable positiveButtonRunnable = () -> {
-            String langCode = CommonsApplication.getInstance().getLanguageLookUpTable().getCodes().get(spinner.getSelectedItemPosition());
-            Utils.handleWebUrl(AboutActivity.this, Uri.parse(Urls.TRANSLATE_WIKI_URL + langCode));
-        };
-        DialogUtil.showAlertDialog(this,
-            getString(R.string.about_translate_title),
-            getString(R.string.about_translate_message),
-            getString(R.string.about_translate_proceed),
-            getString(R.string.about_translate_cancel),
-            positiveButtonRunnable,
-            () -> {},
-            spinner
-        );
-    }
-
-}
diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt b/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
new file mode 100644
index 0000000000..08941d6db9
--- /dev/null
+++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
@@ -0,0 +1,244 @@
+package fr.free.nrw.commons
+
+import android.annotation.SuppressLint
+import android.content.Intent
+import android.net.Uri
+import android.os.Bundle
+import android.view.Menu
+import android.view.MenuItem
+import android.view.View
+import android.widget.ArrayAdapter
+import android.widget.LinearLayout
+import android.widget.Spinner
+import fr.free.nrw.commons.CommonsApplication.Companion.instance
+import fr.free.nrw.commons.databinding.ActivityAboutBinding
+import fr.free.nrw.commons.theme.BaseActivity
+import fr.free.nrw.commons.utils.ConfigUtils.getVersionNameWithSha
+import fr.free.nrw.commons.utils.DialogUtil.showAlertDialog
+import java.util.Collections
+
+/**
+ * Represents about screen of this app
+ */
+class AboutActivity : BaseActivity() {
+    /*
+         This View Binding class is auto-generated for each xml file. The format is usually the name
+         of the file with PascalCasing (The underscore characters will be ignored).
+         More information is available at https://developer.android.com/topic/libraries/view-binding
+        */
+    private var binding: ActivityAboutBinding? = null
+
+    /**
+     * This method helps in the creation About screen
+     *
+     * @param savedInstanceState Data bundle
+     */
+    @SuppressLint("StringFormatInvalid")
+    public override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+
+        /*
+          Instead of just setting the view with the xml file. We need to use View Binding class.
+         */
+        binding = ActivityAboutBinding.inflate(layoutInflater)
+        val view: View = binding!!.root
+        setContentView(view)
+
+        setSupportActionBar(binding!!.toolbarBinding.toolbar)
+        supportActionBar!!.setDisplayHomeAsUpEnabled(true)
+        val aboutText = getString(R.string.about_license)
+        /*
+          We can then access all the views by just using the id names like this.
+          camelCasing is used with underscore characters being ignored.
+         */
+        binding!!.aboutLicense.setHtmlText(aboutText)
+
+        @SuppressLint("StringFormatMatches") val improveText =
+            String.format(getString(R.string.about_improve), Urls.NEW_ISSUE_URL)
+        binding!!.aboutImprove.setHtmlText(improveText)
+        binding!!.aboutVersion.text = applicationContext.getVersionNameWithSha()
+
+        Utils.setUnderlinedText(
+            binding!!.aboutFaq, R.string.about_faq,
+            applicationContext
+        )
+        Utils.setUnderlinedText(
+            binding!!.aboutRateUs, R.string.about_rate_us,
+            applicationContext
+        )
+        Utils.setUnderlinedText(
+            binding!!.aboutUserGuide, R.string.user_guide,
+            applicationContext
+        )
+        Utils.setUnderlinedText(
+            binding!!.aboutPrivacyPolicy, R.string.about_privacy_policy,
+            applicationContext
+        )
+        Utils.setUnderlinedText(
+            binding!!.aboutTranslate, R.string.about_translate,
+            applicationContext
+        )
+        Utils.setUnderlinedText(
+            binding!!.aboutCredits, R.string.about_credits,
+            applicationContext
+        )
+
+        /*
+          To set listeners, we can create a separate method and use lambda syntax.
+        */
+        binding!!.facebookLaunchIcon.setOnClickListener { view: View? ->
+            this.launchFacebook(
+                view
+            )
+        }
+        binding!!.githubLaunchIcon.setOnClickListener { view: View? ->
+            this.launchGithub(
+                view
+            )
+        }
+        binding!!.websiteLaunchIcon.setOnClickListener { view: View? ->
+            this.launchWebsite(
+                view
+            )
+        }
+        binding!!.aboutRateUs.setOnClickListener { view: View? ->
+            this.launchRatings(
+                view
+            )
+        }
+        binding!!.aboutCredits.setOnClickListener { view: View? ->
+            this.launchCredits(
+                view
+            )
+        }
+        binding!!.aboutPrivacyPolicy.setOnClickListener { view: View? ->
+            this.launchPrivacyPolicy(
+                view
+            )
+        }
+        binding!!.aboutUserGuide.setOnClickListener { view: View? ->
+            this.launchUserGuide(
+                view
+            )
+        }
+        binding!!.aboutFaq.setOnClickListener { view: View? ->
+            this.launchFrequentlyAskedQuesions(
+                view
+            )
+        }
+        binding!!.aboutTranslate.setOnClickListener { view: View? ->
+            this.launchTranslate(
+                view
+            )
+        }
+    }
+
+    override fun onSupportNavigateUp(): Boolean {
+        onBackPressed()
+        return true
+    }
+
+    fun launchFacebook(view: View?) {
+        val intent: Intent
+        try {
+            intent = Intent(Intent.ACTION_VIEW, Uri.parse(Urls.FACEBOOK_APP_URL))
+            intent.setPackage(Urls.FACEBOOK_PACKAGE_NAME)
+            startActivity(intent)
+        } catch (e: Exception) {
+            Utils.handleWebUrl(this, Uri.parse(Urls.FACEBOOK_WEB_URL))
+        }
+    }
+
+    fun launchGithub(view: View?) {
+        val intent: Intent
+        try {
+            intent = Intent(Intent.ACTION_VIEW, Uri.parse(Urls.GITHUB_REPO_URL))
+            intent.setPackage(Urls.GITHUB_PACKAGE_NAME)
+            startActivity(intent)
+        } catch (e: Exception) {
+            Utils.handleWebUrl(this, Uri.parse(Urls.GITHUB_REPO_URL))
+        }
+    }
+
+    fun launchWebsite(view: View?) {
+        Utils.handleWebUrl(this, Uri.parse(Urls.WEBSITE_URL))
+    }
+
+    fun launchRatings(view: View?) {
+        Utils.rateApp(this)
+    }
+
+    fun launchCredits(view: View?) {
+        Utils.handleWebUrl(this, Uri.parse(Urls.CREDITS_URL))
+    }
+
+    fun launchUserGuide(view: View?) {
+        Utils.handleWebUrl(this, Uri.parse(Urls.USER_GUIDE_URL))
+    }
+
+    fun launchPrivacyPolicy(view: View?) {
+        Utils.handleWebUrl(this, Uri.parse(BuildConfig.PRIVACY_POLICY_URL))
+    }
+
+    fun launchFrequentlyAskedQuesions(view: View?) {
+        Utils.handleWebUrl(this, Uri.parse(Urls.FAQ_URL))
+    }
+
+    override fun onCreateOptionsMenu(menu: Menu): Boolean {
+        val inflater = menuInflater
+        inflater.inflate(R.menu.menu_about, menu)
+        return super.onCreateOptionsMenu(menu)
+    }
+
+    override fun onOptionsItemSelected(item: MenuItem): Boolean {
+        when (item.itemId) {
+            R.id.share_app_icon -> {
+                val shareText = String.format(
+                    getString(R.string.share_text),
+                    Urls.PLAY_STORE_URL_PREFIX + this.packageName
+                )
+                val sendIntent = Intent()
+                sendIntent.setAction(Intent.ACTION_SEND)
+                sendIntent.putExtra(Intent.EXTRA_TEXT, shareText)
+                sendIntent.setType("text/plain")
+                startActivity(Intent.createChooser(sendIntent, getString(R.string.share_via)))
+                return true
+            }
+
+            else -> return super.onOptionsItemSelected(item)
+        }
+    }
+
+    fun launchTranslate(view: View?) {
+        val sortedLocalizedNamesRef = instance.languageLookUpTable!!.getCanonicalNames()
+        Collections.sort(sortedLocalizedNamesRef)
+        val languageAdapter = ArrayAdapter(
+            this@AboutActivity,
+            android.R.layout.simple_spinner_dropdown_item, sortedLocalizedNamesRef
+        )
+        val spinner = Spinner(this@AboutActivity)
+        spinner.layoutParams =
+            LinearLayout.LayoutParams(
+                LinearLayout.LayoutParams.WRAP_CONTENT,
+                LinearLayout.LayoutParams.WRAP_CONTENT
+            )
+        spinner.adapter = languageAdapter
+        spinner.gravity = 17
+        spinner.setPadding(50, 0, 0, 0)
+
+        val positiveButtonRunnable = Runnable {
+            val langCode = instance.languageLookUpTable!!.getCodes()[spinner.selectedItemPosition]
+            Utils.handleWebUrl(this@AboutActivity, Uri.parse(Urls.TRANSLATE_WIKI_URL + langCode))
+        }
+        showAlertDialog(
+            this,
+            getString(R.string.about_translate_title),
+            getString(R.string.about_translate_message),
+            getString(R.string.about_translate_proceed),
+            getString(R.string.about_translate_cancel),
+            positiveButtonRunnable,
+            {},
+            spinner
+        )
+    }
+}

From 9390d8390bef4b9809b3413252786e5464c6140f Mon Sep 17 00:00:00 2001
From: Akshay Komar <akshaykomar732@gmail.com>
Date: Mon, 27 Jan 2025 00:08:40 +0530
Subject: [PATCH 14/14] Thank you for the suggestion! Since these methods all
 take a single View parameter, replacing them with method references is a
 great way to simplify the code and improve readability. I'll updated the code
 accordingly. Added a TODO in the code as a reminder to refactor this in the
 future.

---
 .../java/fr/free/nrw/commons/AboutActivity.kt | 59 ++++---------------
 1 file changed, 12 insertions(+), 47 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt b/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
index 08941d6db9..143f5e5696 100644
--- a/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
+++ b/app/src/main/java/fr/free/nrw/commons/AboutActivity.kt
@@ -33,7 +33,7 @@ class AboutActivity : BaseActivity() {
      *
      * @param savedInstanceState Data bundle
      */
-    @SuppressLint("StringFormatInvalid")
+    @SuppressLint("StringFormatInvalid")  //TODO:
     public override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
@@ -53,7 +53,8 @@ class AboutActivity : BaseActivity() {
          */
         binding!!.aboutLicense.setHtmlText(aboutText)
 
-        @SuppressLint("StringFormatMatches") val improveText =
+        @SuppressLint("StringFormatMatches") // TODO:
+        val improveText =
             String.format(getString(R.string.about_improve), Urls.NEW_ISSUE_URL)
         binding!!.aboutImprove.setHtmlText(improveText)
         binding!!.aboutVersion.text = applicationContext.getVersionNameWithSha()
@@ -86,51 +87,15 @@ class AboutActivity : BaseActivity() {
         /*
           To set listeners, we can create a separate method and use lambda syntax.
         */
-        binding!!.facebookLaunchIcon.setOnClickListener { view: View? ->
-            this.launchFacebook(
-                view
-            )
-        }
-        binding!!.githubLaunchIcon.setOnClickListener { view: View? ->
-            this.launchGithub(
-                view
-            )
-        }
-        binding!!.websiteLaunchIcon.setOnClickListener { view: View? ->
-            this.launchWebsite(
-                view
-            )
-        }
-        binding!!.aboutRateUs.setOnClickListener { view: View? ->
-            this.launchRatings(
-                view
-            )
-        }
-        binding!!.aboutCredits.setOnClickListener { view: View? ->
-            this.launchCredits(
-                view
-            )
-        }
-        binding!!.aboutPrivacyPolicy.setOnClickListener { view: View? ->
-            this.launchPrivacyPolicy(
-                view
-            )
-        }
-        binding!!.aboutUserGuide.setOnClickListener { view: View? ->
-            this.launchUserGuide(
-                view
-            )
-        }
-        binding!!.aboutFaq.setOnClickListener { view: View? ->
-            this.launchFrequentlyAskedQuesions(
-                view
-            )
-        }
-        binding!!.aboutTranslate.setOnClickListener { view: View? ->
-            this.launchTranslate(
-                view
-            )
-        }
+        binding!!.facebookLaunchIcon.setOnClickListener(::launchFacebook)
+        binding!!.githubLaunchIcon.setOnClickListener(::launchGithub)
+        binding!!.websiteLaunchIcon.setOnClickListener(::launchWebsite)
+        binding!!.aboutRateUs.setOnClickListener(::launchRatings)
+        binding!!.aboutCredits.setOnClickListener(::launchCredits)
+        binding!!.aboutPrivacyPolicy.setOnClickListener(::launchPrivacyPolicy)
+        binding!!.aboutUserGuide.setOnClickListener(::launchUserGuide)
+        binding!!.aboutFaq.setOnClickListener(::launchFrequentlyAskedQuesions)
+        binding!!.aboutTranslate.setOnClickListener(::launchTranslate)
     }
 
     override fun onSupportNavigateUp(): Boolean {