From 462d29ceb951d450e0ead7e721d664e5d4b33a8c Mon Sep 17 00:00:00 2001 From: devendrachoudharycodes Date: Sun, 15 Mar 2026 20:54:05 +0530 Subject: [PATCH] Check location difference only for camera captures; skip for gallery images since capture location is not passed in intent from Nearby to Upload screeand comments to the code for future ref --- .../java/fr/free/nrw/commons/upload/UploadActivity.kt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt index e83ea2c5f9..58a84eb4e4 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt @@ -1002,10 +1002,15 @@ class UploadActivity : BaseActivity(), UploadContract.View, UploadBaseFragment.C Manage EXIF Tags setting or turned "Record location for in-app shots" off. Also, location information is discarded if the difference between current location and location recorded just before capturing the image - is greater than 100 meters */ - if (isLocationTagUnchecked || locationDifference > 100 + is greater than 100 meters + NOTE:- The LOCATION_BEFORE_IMAGE_CAPTURE is only available + for in-app camera uploads. For gallery uploads, this location is not + passed via the intent from Nearby to UploadActivity. Therefore, + the location difference check should only apply to camera uploads. + */ + if (isLocationTagUnchecked || !defaultKvStore.getBoolean("inAppCameraLocationPref") - || !isInAppCameraUpload + || (isInAppCameraUpload && locationDifference > 100) ) { currLocation = null }