Skip to content

Commit 8d9295e

Browse files
Update gsoc.md
1 parent 1e9d461 commit 8d9295e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

android/gsoc.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ The [Commons app](https://play.google.com/store/apps/details?id=fr.free.nrw.comm
66

77
# How to apply
88

9-
Thank you for your interest! In the candidate selection phase of GSoC, we ask you (the student) to learn about the project and apply by performing these tasks (in this order):
9+
Thank you for your interest! In the candidate selection phase of GSoC, we ask you (the GSoC candidate) to learn about the project and apply by performing these tasks (in this order):
1010

1111
1. Compile and run the app as described in [the documentation](https://github.com/commons-app/commons-app-documentation/blob/master/android/Quick-start-guide-for-Developers.md#quick-start-guide-for-developers).
1212
2. Fix 1 bug by following the instructions at the "Developers" section [here](https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers). Fixing bugs is a good opportunity to demonstrate that you can work on the app.
1313
3. (_optional but preferred as it demonstrates your attention to details and understanding of git_) Review 1 existing pull request:
14-
1. Go to https://github.com/commons-app/apps-android-commons/pulls and find a pull request that does **not** contain the words "Review by student".
14+
1. Go to https://github.com/commons-app/apps-android-commons/pulls and find a pull request that does **not** contain the words "Review by GSoC applicant".
1515
2. Go to the page of the original issue. The original issue should be mentioned at the top of the pull request, for instance "_Fixes #xyz_". If the pull request does not mention any issue, please add a comment on the pull request asking for a link to the original issue, and choose a different pull request.
1616
3. Try to reproduce the original issue. Once you have managed to reproduce it, take a video of the issue reproduction (to make a screencast on Android you can use [adb](https://stackoverflow.com/questions/28217333/how-to-record-android-devices-screen-on-android-version-below-4-4-kitkat) or [this button](https://support.google.com/android/answer/9075928) or any other screencast app that works for you). Keep the resulting video file, you will use it later.
1717
4. Go back to the source code of the app, and perform a `git pull` to make sure you are at the latest master. Now create a new branch and _pull_ the pull request, for instance: `git checkout -b pr1 master; git pull https://github.com/person-who-wrote-the-pr/apps-android-commons.git pr1` (replace `person-who-wrote-the-pr` with the username of the person who wrote the pull request, and `pr1` with the name of the branch of the pull request). Compile and run. If the pull request really solves the issue, then the issue should not happen now. Take a video showing that.
1818
5. On the pull request page, add a comment containing:
19-
- These exact words: "Review by student"
19+
- These exact words: "Review by GSoC applicant"
2020
- Post the two videos (before merging the pull request showing the issue, after merging the pull request)
2121
- Say whether the issue was solved after merging the pull request or not.
2222
- Optionally, explain how the source code change could be improved.
@@ -51,9 +51,9 @@ If you really want to work on a different task, it can be considered. It can be
5151
- [Make Nearby show all pins that could be presented on the screen, rather than a circle](https://github.com/commons-app/apps-android-commons/issues/5480) + [Split Nearby into a fast query for coordinates + a details query for each pin](https://github.com/commons-app/apps-android-commons/issues/4560) + [Export Nearby items for offline use on map apps](https://github.com/commons-app/apps-android-commons/issues/953) + [Report that Nearby item is not at specified location](https://github.com/commons-app/apps-android-commons/issues/965).
5252
- If you have another idea, please post it as a new issue on our GitHub and mention you are considering it for GSoC, so that we can provide feedback.
5353

54-
# How we choose the student
54+
# How we choose the GSoC applicant
5555

56-
We choose the student based on (from the most important):
56+
We choose the GSoC applicant based on (from the most important):
5757
- Technical challengingness of merged bugfix(es).
5858
- Quality of code (absence of bugs, good self-testing, use of Java & Android conventions).
5959
- Efficiency and smoothness of interactions on GitHub.

0 commit comments

Comments
 (0)