without CTS, our types allow invalid handler (#1551)

* without CTS, our types allow invalid handler

you must either specify the jsonschemas or enable (deprecated) proxy mode

handler<E,T>(fn) types say that the state should be of type T, but if
the user specifies T has a Cell<...> it will be stripped away by the
compiler - and so our runtime won't know - and it was enabling proxy mode

we should only enable proxy mode if the user explicitly specifies.

* use CTS mode for simpleValue

Author: anotherjesse

packages/runner/src/builder/module.ts

@@ -123,8 +123,17 @@ export function handler<E, T>(
   handler?: (event: E, props: T) => any,
 ): HandlerFactory<T, E> {
   if (typeof eventSchema === "function") {
-    handler = eventSchema;
-    eventSchema = stateSchema = undefined;
+    if (
+      stateSchema && typeof stateSchema === "object" &&
+      "proxy" in stateSchema && stateSchema.proxy === true
+    ) {
+      handler = eventSchema;
+      eventSchema = stateSchema = undefined;
+    } else {
+      throw new Error(
+        "invalid handler, no schema provided - did you forget to enable CTS?",
+      );
+    }
   }
 
   const schema: JSONSchema | undefined = eventSchema || stateSchema

packages/runner/test/module.test.ts

@@ -100,6 +100,7 @@ describe("module", () => {
           props.x = event.clientX;
           props.y = event.clientY;
         },
+        { proxy: true },
       );
       expect(typeof clickHandler).toBe("function");
       expect(isModule(clickHandler)).toBe(true);
@@ -111,6 +112,7 @@ describe("module", () => {
           props.x = event.clientX;
           props.y = event.clientY;
         },
+        { proxy: true },
       );
       const stream = clickHandler({ x: opaqueRef(10), y: opaqueRef(20) });
       expect(isOpaqueRef(stream)).toBe(true);
@@ -201,6 +203,7 @@ describe("module", () => {
           props.x = event.clientX;
           props.y = event.clientY;
         },
+        { proxy: true },
       );
       const stream = clickHandler.with({ x: opaqueRef(10), y: opaqueRef(20) });
       expect(isOpaqueRef(stream)).toBe(true);

recipes/simpleValue.tsx

@@ -1,3 +1,4 @@
+/// <cts-enable />
 import {
   Cell,
   derive,