chore: lint common-ui, common-os-ui

Author: jsantell

typescript/packages/common-os-ui/src/components/code-editor/os-code-editor.ts

@@ -135,9 +135,9 @@ export class OsCodeEditor extends ReactiveElement {
     const ext = EditorView.updateListener.of((update) => {
       if (update.docChanged) {
         if (this.#docChangeTimeout) {
-          window.clearTimeout(this.#docChangeTimeout);
+          globalThis.clearTimeout(this.#docChangeTimeout);
         }
-        this.#docChangeTimeout = window.setTimeout(() => {
+        this.#docChangeTimeout = globalThis.setTimeout(() => {
           this.dispatchEvent(new CustomEvent("doc-change", { detail: update }));
         }, 500);
       }
@@ -154,7 +154,7 @@ export class OsCodeEditor extends ReactiveElement {
     this.destroy.add(() => {
       this.#editorView?.destroy();
       if (this.#docChangeTimeout) {
-        window.clearTimeout(this.#docChangeTimeout);
+        globalThis.clearTimeout(this.#docChangeTimeout);
       }
     });
   }

typescript/packages/common-os-ui/src/components/editor/os-rich-text-editor.ts

@@ -384,8 +384,8 @@ export class OsRichTextEditor extends HTMLElement {
   }
 
   /** TODO implement */
-  async fetchCompletions(_suggestion: Suggestion) {
-    return [];
+  fetchCompletions(_suggestion: Suggestion) {
+    return Promise.resolve([]);
   }
 
   /**

typescript/packages/common-os-ui/src/components/editor/suggestions.ts

@@ -214,18 +214,18 @@ const replaceFx = (
   suggestion: Suggestion | null,
   completion: string | null,
 ) =>
-async () => {
+() => {
   if (suggestion == null) {
-    return createInfoMsg("No active suggestion to replace");
+    return Promise.resolve(createInfoMsg("No active suggestion to replace"));
   }
   if (completion == null) {
-    return createInfoMsg("No completion to replace");
+    return Promise.resolve(createInfoMsg("No completion to replace"));
   }
   executeCommand(
     view,
     replaceWithText(suggestion.from, suggestion.to, completion),
   );
-  return createInfoMsg("Replaced suggestion with completion");
+  return Promise.resolve(createInfoMsg("Replaced suggestion with completion"));
 };
 
 /**

typescript/packages/common-os-ui/src/components/os-dialog.ts

@@ -68,12 +68,12 @@ export class OsDialog extends LitElement {
   open = false;
 
   override connectedCallback(): void {
-    window.addEventListener("keydown", this.#onEsc);
+    globalThis.addEventListener("keydown", this.#onEsc);
     super.connectedCallback();
   }
 
   override disconnectedCallback(): void {
-    window.removeEventListener("keydown", this.#onEsc);
+    globalThis.removeEventListener("keydown", this.#onEsc);
   }
 
   #onEsc = (event: KeyboardEvent) => {

typescript/packages/common-os-ui/src/components/os-navstack.ts

@@ -73,7 +73,7 @@ export class OsNavstack extends LitElement {
 
   async back() {
     const panels = [...this.panels];
-    let lastPanel = panels.at(-1);
+    const lastPanel = panels.at(-1);
     if (!lastPanel) {
       return;
     }

typescript/packages/common-os-ui/src/shared/dom.ts

@@ -1,6 +1,6 @@
 /** Create a class string using a record of classnames to toggle-states */
 export const classes = (classRecord: Record<string, boolean>) => {
-  let toggledClasses: Array<string> = [];
+  const toggledClasses: Array<string> = [];
   for (const [className, isActive] of Object.entries(classRecord)) {
     if (isActive) toggledClasses.push(className);
   }
@@ -11,7 +11,7 @@ export const classes = (classRecord: Record<string, boolean>) => {
 export const animationFrame = () =>
   new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
 
-export const toggleInvisible = async (
+export const toggleInvisible = (
   element: HTMLElement,
   isInvisible: boolean,
 ) => {

typescript/packages/common-ui/src/components/common-form.ts

@@ -62,7 +62,7 @@ export class ReferenceFieldElement extends LitElement {
       <input
         class="field-input ${this.error ? "has-error" : ""}"
         .value=${this.value}
-        @input=${async (e: Event) => {
+        @input=${(e: Event) => {
       const value = (e.target as HTMLInputElement).value;
       this.dispatch(value);
     }}
@@ -96,7 +96,7 @@ export class ZodFormSubmitEvent extends Event {
 
 @customElement("common-form")
 export class CommonFormElement extends LitElement {
-  static properties = {
+  static override properties = {
     value: {},
   };
   private _internalValue: { [key: string]: any } = {};
@@ -316,10 +316,11 @@ export class CommonFormElement extends LitElement {
         case "ZodObject":
           sample[key] = {};
           break;
-        case "ZodEnum":
+        case "ZodEnum": {
           const values = (fieldSchema as any)._def.values;
           sample[key] = values[Math.floor(Math.random() * values.length)];
           break;
+        }
         case "ZodArray":
           sample[key] = [];
           break;
@@ -486,7 +487,7 @@ export class CommonFormElement extends LitElement {
     }
 
     // Create a copy of the current value to modify
-    let submitValue = { ...this._internalValue };
+    const submitValue = { ...this._internalValue };
 
     // If there are reference fields, convert them before submission
     if (this.referenceFields.size > 0) {

typescript/packages/common-ui/src/components/common-input-file.ts

@@ -95,7 +95,7 @@ export class CommonFileInputElement extends LitElement {
    * @param files Array of File objects to be read.
    * @returns Promise resolving to an array containing each file and its content.
    */
-  private async readFiles(files: File[]): Promise<FileContent[]> {
+  private readFiles(files: File[]): Promise<FileContent[]> {
     const readFile = (file: File): Promise<FileContent> => {
       return new Promise((resolve) => {
         const reader = new FileReader();

typescript/packages/common-ui/src/components/common-table.ts

@@ -355,26 +355,26 @@ export class CommonTableElement extends LitElement {
   handleDownload(item: any) {
     const data = JSON.stringify(item, null, 2);
     const blob = new Blob([data], { type: "application/json" });
-    const url = window.URL.createObjectURL(blob);
+    const url = globalThis.URL.createObjectURL(blob);
     const a = document.createElement("a");
     a.href = url;
     a.download = `data-${Date.now()}.json`;
     document.body.appendChild(a);
     a.click();
-    window.URL.revokeObjectURL(url);
+    globalThis.URL.revokeObjectURL(url);
     document.body.removeChild(a);
   }
 
   handleDownloadAll() {
     const data = JSON.stringify(this.data, null, 2);
     const blob = new Blob([data], { type: "application/json" });
-    const url = window.URL.createObjectURL(blob);
+    const url = globalThis.URL.createObjectURL(blob);
     const a = document.createElement("a");
     a.href = url;
     a.download = `all-data-${Date.now()}.json`;
     document.body.appendChild(a);
     a.click();
-    window.URL.revokeObjectURL(url);
+    globalThis.URL.revokeObjectURL(url);
     document.body.removeChild(a);
   }
 
@@ -386,7 +386,7 @@ export class CommonTableElement extends LitElement {
     }
   }
 
-  async handleImport(_: Event) {
+  handleImport(_: Event) {
     const input = document.createElement("input");
     input.type = "file";
     input.accept = ".json";

typescript/packages/common-ui/src/components/shoelace/index.ts

@@ -8,7 +8,7 @@ import { registerIconLibrary } from "@shoelace-style/shoelace";
  * Calling with no arguments will perform this on `document`.
  */
 export const adoptShoelaceStyles = (
-  host: Document | ShadowRoot = window.document,
+  host: Document | ShadowRoot = globalThis.document,
 ) => {
   host.adoptedStyleSheets = [theme.styleSheet!];
 };
@@ -28,7 +28,7 @@ export const registerShoelaceIcons = () => {
 };
 
 export const setupShoelace = ({
-  host = window.document,
+  host = globalThis.document,
 }: {
   host?: Document | ShadowRoot;
 } = {}) => {