Fix: Mark synthetic element access expressions as requiring rewrite

Problem:
When the ClosureTransformer creates synthetic nodes for map callbacks
(e.g., `tagCounts[element]` inside a recipe callback), the dataflow
analysis was marking them as `requiresRewrite: false`, preventing the
OpaqueRefJSXTransformer from wrapping them in derive calls.

Root Cause:
In dataflow.ts, synthetic element access expressions were falling through
to the default case (line 483-487) which sets `requiresRewrite: false`.

Solution:
Added special handling for synthetic element access expressions (lines
470-477 in dataflow.ts) to match the behavior of non-synthetic element
access expressions, setting `requiresRewrite: true` when they contain
OpaqueRefs.

Also simplified filterRelevantDataFlows in helpers.ts to keep all
dataflows except those originating from ignored parameters, since both
builder parameters and map parameters are now OpaqueRefs that need to be
tracked.

Test Changes:
- Updated map-element-access-opaque.expected.tsx with correct parameter naming
- Updated map-array-destructured.expected.tsx to wrap element[0] and element[1]
- Fixed element-access-both-opaque input/expected files to use correct directive

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>

Author: seefeldb

packages/ts-transformers/src/ast/dataflow.ts

@@ -200,7 +200,9 @@ export function createDataFlowAnalyzer(
   };
 
   // Helper: Check if an element access expression has a static (literal) index
-  const isStaticElementAccess = (expression: ts.ElementAccessExpression): boolean => {
+  const isStaticElementAccess = (
+    expression: ts.ElementAccessExpression,
+  ): boolean => {
     const argumentExpression = expression.argumentExpression;
     return argumentExpression !== undefined &&
       ts.isExpression(argumentExpression) &&
@@ -494,7 +496,8 @@ export function createDataFlowAnalyzer(
           return merged;
         }
 
-        // JSX elements, arrow functions, and other containers preserve requiresRewrite from children
+        // For JSX elements, arrow functions, and other expression containers, preserve requiresRewrite from children
+        // This matches the non-synthetic code paths for these node types
         if (
           ts.isJsxElement(expression) ||
           ts.isJsxFragment(expression) ||

packages/ts-transformers/src/transformers/opaque-ref/helpers.ts

@@ -188,18 +188,8 @@ export function filterRelevantDataFlows(
     ) {
       return false;
     }
-    if (isParameterExpression(dataFlow.expression)) {
-      if (resolvesToMapParameter(dataFlow.expression, context.checker)) {
-        return true;
-      }
-      if (resolvesToBuilderParameter(dataFlow.expression, context.checker)) {
-        return false;
-      }
-      return false;
-    }
-    if (resolvesToBuilderParameter(dataFlow.expression, context.checker)) {
-      return false;
-    }
+    // Keep all other dataflows, including builder parameters and map parameters
+    // Both are OpaqueRefs that may need to be included in derive calls
     return true;
   });
 }