chore: Fix up deno task test-all to run all tests and return non-0 status upon failure (#483)

jsantell · web-flow · commit 5383455e7288 · 2025-02-28T12:03:22.000-08:00
chore: Fix up deno task test-all to run all tests and return non-0 status code upon failure.
diff --git a/typescript/packages/common-builder/deno.json b/typescript/packages/common-builder/deno.json
@@ -2,6 +2,6 @@
   "name": "@commontools/builder",
   "exports": "./src/index.ts",
   "tasks": {
-    "build": "../scripts/build.ts"
+    "test": "deno test"
   }
 }
diff --git a/typescript/packages/common-charm/deno.json b/typescript/packages/common-charm/deno.json
@@ -1,4 +1,7 @@
 {
   "name": "@commontools/charm",
+  "tasks": {
+    "test": "deno test"
+  },
   "exports": "./src/index.ts"
 }
diff --git a/typescript/packages/common-cli/deno.json b/typescript/packages/common-cli/deno.json
@@ -1,6 +1,7 @@
 {
   "tasks": {
     "start": "deno run --allow-read --allow-env --allow-net main.ts",
-    "memtest": "deno run --allow-read --allow-env --allow-net memory_test.ts"
+    "memtest": "deno run --allow-read --allow-env --allow-net memory_test.ts",
+    "test": "deno test"
   }
 }
diff --git a/typescript/packages/common-html/deno.json b/typescript/packages/common-html/deno.json
@@ -2,6 +2,6 @@
   "name": "@commontools/html",
   "exports": "./src/index.ts",
   "tasks": {
-    "test-browser": "../scripts/test-browser.ts test-browser/**/*.ts"
+    "test": "deno test"
   }
 }
diff --git a/typescript/packages/common-os-ui/deno.json b/typescript/packages/common-os-ui/deno.json
@@ -1,5 +1,8 @@
 {
   "name": "@commontools/os-ui",
+  "tasks": {
+    "test": "deno test"
+  },
   "exports": "./src/index.ts",
   "imports": {
     "@codemirror/lang-css": "npm:@codemirror/lang-css@^6.3.1",
diff --git a/typescript/packages/common-runner/deno.json b/typescript/packages/common-runner/deno.json
@@ -1,4 +1,7 @@
 {
   "name": "@commontools/runner",
+  "tasks": {
+    "test": "deno test"
+  },
   "exports": "./src/index.ts"
 }
diff --git a/typescript/packages/common-runner/src/runner.ts b/typescript/packages/common-runner/src/runner.ts
@@ -199,7 +199,7 @@ export function run<T, R = any>(
 
   const internal = {
     ...(deepCopy(defaults) as { internal: any })?.internal,
-    ...recipe.initial?.internal,
+    ...(recipe.initial as { internal: any } | void)?.internal,
     ...processCell.get()?.internal,
   };
 
diff --git a/typescript/packages/common-ui/deno.json b/typescript/packages/common-ui/deno.json
@@ -1,6 +1,9 @@
 {
   "name": "@commontools/ui",
   "exports": "./src/index.ts",
+  "tasks": {
+    "test": "echo 'No tests to run.'"
+  },
   "imports": {
     "@shoelace-style/shoelace": "npm:@shoelace-style/shoelace@^2.19.1"
   }
diff --git a/typescript/packages/deno.json b/typescript/packages/deno.json
@@ -16,7 +16,7 @@
     "./toolshed"
   ],
   "tasks": {
-    "test-all": "./scripts/test-all.sh"
+    "test-all": "./scripts/test-all.ts"
   },
   "compilerOptions": {
     "jsx": "react-jsxdev",
diff --git a/typescript/packages/jumble/deno.json b/typescript/packages/jumble/deno.json
@@ -2,7 +2,8 @@
   "tasks": {
     "dev": "deno run -A --node-modules-dir=auto npm:vite",
     "build": "deno run -A --node-modules-dir=auto npm:vite build",
-    "preview": "deno run -A --node-modules-dir=auto npm:vite preview"
+    "preview": "deno run -A --node-modules-dir=auto npm:vite preview",
+    "test": "echo 'No tests to run.'"
   },
   "imports": {
     "@/": "./src/",
diff --git a/typescript/packages/llm-client/deno.json b/typescript/packages/llm-client/deno.json
@@ -1,4 +1,7 @@
 {
   "name": "@commontools/llm-client",
+  "tasks": {
+    "test": "echo 'No tests to run.'"
+  },
   "exports": "./src/index.ts"
 }
diff --git a/typescript/packages/scripts/test-all.sh b/typescript/packages/scripts/test-all.sh
diff --git a/typescript/packages/scripts/test-all.ts b/typescript/packages/scripts/test-all.ts
@@ -0,0 +1,55 @@
+#!/usr/bin/env -S deno run --allow-read --allow-run
+import * as path from "jsr:@std/path";
+
+const decoder = new TextDecoder();
+const workspaceCwd = Deno.cwd();
+const manifest = JSON.parse(await Deno.readTextFile("./deno.json"));
+const members: string[] = manifest.workspace;
+
+const DISABLED = [
+  "common-cli", // Disabled until `memory_test.ts` passes
+  "common-html", // Disabled until we get tests and jsx in tests passing
+  "common-identity", // Disabled until we have web test runner
+  "common-iframe-sandbox", // Disabled until we have web test runner
+  "deno-vite-plugin", // Do not test vendored code
+  "toolshed", // Requires extra configuration to run (e.g. redis)
+];
+
+let success = true;
+for (const memberPath of members) {
+  // Convert "./common-memory" to "common-memory"
+  const packageName = memberPath.substring(2);
+  if (DISABLED.includes(packageName)) {
+    continue;
+  }
+  console.log(`Testing ${packageName}...`);
+  const packagePath = path.join(workspaceCwd, packageName);
+  if (!await testPackage(packagePath)) {
+    success = false;
+  }
+}
+
+if (success) {
+  console.log("All tests passing!");
+} else {
+  console.error("One or more tests failed.");
+  Deno.exit(1);
+}
+
+async function testPackage(packagePath: string): Promise<boolean> {
+  const result = await new Deno.Command(Deno.execPath(), {
+    args: ["task", "test"],
+    cwd: packagePath,
+    stdout: "piped",
+  }).output();
+
+  const stdout = decoder.decode(result.stdout);
+  if (stdout) {
+    console.log(stdout);
+  }
+  const stderr = decoder.decode(result.stderr);
+  if (stderr) {
+    console.error(stderr);
+  }
+  return result.success;
+}

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,6 @@`
`2`	`2`	`"name": "@commontools/builder",`
`3`	`3`	`"exports": "./src/index.ts",`
`4`	`4`	`"tasks": {`
`5`		`- "build": "../scripts/build.ts"`
	`5`	`+ "test": "deno test"`
`6`	`6`	`}`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@commontools/charm",`
	`3`	`+ "tasks": {`
	`4`	`+ "test": "deno test"`
	`5`	`+ },`
`3`	`6`	`"exports": "./src/index.ts"`
`4`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"tasks": {`
`3`	`3`	`"start": "deno run --allow-read --allow-env --allow-net main.ts",`
`4`		`- "memtest": "deno run --allow-read --allow-env --allow-net memory_test.ts"`
	`4`	`+ "memtest": "deno run --allow-read --allow-env --allow-net memory_test.ts",`
	`5`	`+ "test": "deno test"`
`5`	`6`	`}`
`6`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,6 @@`
`2`	`2`	`"name": "@commontools/html",`
`3`	`3`	`"exports": "./src/index.ts",`
`4`	`4`	`"tasks": {`
`5`		`- "test-browser": "../scripts/test-browser.ts test-browser/*/.ts"`
	`5`	`+ "test": "deno test"`
`6`	`6`	`}`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@commontools/os-ui",`
	`3`	`+ "tasks": {`
	`4`	`+ "test": "deno test"`
	`5`	`+ },`
`3`	`6`	`"exports": "./src/index.ts",`
`4`	`7`	`"imports": {`
`5`	`8`	`"@codemirror/lang-css": "npm:@codemirror/lang-css@^6.3.1",`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@commontools/runner",`
	`3`	`+ "tasks": {`
	`4`	`+ "test": "deno test"`
	`5`	`+ },`
`3`	`6`	`"exports": "./src/index.ts"`
`4`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@commontools/ui",`
`3`	`3`	`"exports": "./src/index.ts",`
	`4`	`+ "tasks": {`
	`5`	`+ "test": "echo 'No tests to run.'"`
	`6`	`+ },`
`4`	`7`	`"imports": {`
`5`	`8`	`"@shoelace-style/shoelace": "npm:@shoelace-style/shoelace@^2.19.1"`
`6`	`9`	`}`