Skip to content

Commit 584a7b2

Browse files
committed
Action cubic review notes
1 parent 32d9d11 commit 584a7b2

File tree

2 files changed

+60
-5
lines changed

2 files changed

+60
-5
lines changed

packages/ui/src/v2/components/ct-fab/ct-fab.ts

Lines changed: 53 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,16 @@ export class CTFab extends BaseElement {
5353
backdrop-filter var(--ct-theme-animation-duration, 300ms) ease,
5454
-webkit-backdrop-filter var(--ct-theme-animation-duration, 300ms) ease;
5555
z-index: 998;
56+
}
57+
58+
.backdrop.active {
59+
backdrop-filter: blur(8px);
60+
-webkit-backdrop-filter: blur(8px);
61+
pointer-events: auto;
62+
}
63+
64+
/* Position-specific backdrop masks */
65+
:host([position="bottom-right"]) .backdrop {
5666
mask-image: radial-gradient(
5767
circle at bottom right,
5868
rgba(0, 0, 0, 1) 0%,
@@ -67,10 +77,49 @@ export class CTFab extends BaseElement {
6777
);
6878
}
6979
70-
.backdrop.active {
71-
backdrop-filter: blur(8px);
72-
-webkit-backdrop-filter: blur(8px);
73-
pointer-events: auto;
80+
:host([position="bottom-left"]) .backdrop {
81+
mask-image: radial-gradient(
82+
circle at bottom left,
83+
rgba(0, 0, 0, 1) 0%,
84+
rgba(0, 0, 0, 0.5) 40%,
85+
rgba(0, 0, 0, 0) 70%
86+
);
87+
-webkit-mask-image: radial-gradient(
88+
circle at bottom left,
89+
rgba(0, 0, 0, 1) 0%,
90+
rgba(0, 0, 0, 0.5) 40%,
91+
rgba(0, 0, 0, 0) 70%
92+
);
93+
}
94+
95+
:host([position="top-right"]) .backdrop {
96+
mask-image: radial-gradient(
97+
circle at top right,
98+
rgba(0, 0, 0, 1) 0%,
99+
rgba(0, 0, 0, 0.5) 40%,
100+
rgba(0, 0, 0, 0) 70%
101+
);
102+
-webkit-mask-image: radial-gradient(
103+
circle at top right,
104+
rgba(0, 0, 0, 1) 0%,
105+
rgba(0, 0, 0, 0.5) 40%,
106+
rgba(0, 0, 0, 0) 70%
107+
);
108+
}
109+
110+
:host([position="top-left"]) .backdrop {
111+
mask-image: radial-gradient(
112+
circle at top left,
113+
rgba(0, 0, 0, 1) 0%,
114+
rgba(0, 0, 0, 0.5) 40%,
115+
rgba(0, 0, 0, 0) 70%
116+
);
117+
-webkit-mask-image: radial-gradient(
118+
circle at top left,
119+
rgba(0, 0, 0, 1) 0%,
120+
rgba(0, 0, 0, 0.5) 40%,
121+
rgba(0, 0, 0, 0) 70%
122+
);
74123
}
75124
76125
/* FAB container - positioned by host */

packages/ui/src/v2/components/ct-prompt-input/ct-prompt-input.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,13 @@ export class CTPromptInput extends BaseElement {
899899
*/
900900
private _handleModelChange(event: Event) {
901901
const select = event.target as HTMLSelectElement;
902-
this._modelController.setValue(select.value);
902+
const newValue = select.value;
903+
this._modelController.setValue(newValue);
904+
905+
// When model is a plain string (not bound to Cell), update it directly
906+
if (typeof this.model === "string") {
907+
this.model = newValue;
908+
}
903909
}
904910

905911
/**

0 commit comments

Comments
 (0)