Clear intermediate results to prevent stale output

Author: bfollington

packages/runner/src/builtins/llm.ts

@@ -155,13 +155,15 @@ export function llm(
     if (hash === previousCallHash || hash === requestHashWithLog.get()) return;
     previousCallHash = hash;
 
-    resultWithLog.set(undefined);
-    partialWithLog.set(undefined);
-
     if (!Array.isArray(messages) || messages.length === 0) {
+      resultWithLog.set(undefined);
+      partialWithLog.set(undefined);
       pendingWithLog.set(false);
       return;
     }
+
+    resultWithLog.set(undefined);
+    partialWithLog.set(undefined);
     pendingWithLog.set(true);
 
     const updatePartial = (text: string) => {
@@ -201,6 +203,9 @@ export function llm(
           partial.withTx(tx).set(undefined);
         });
 
+        // Reset previousCallHash to allow retry after error
+        previousCallHash = undefined;
+
         // TODO(seefeld): Not writing now, so we retry the request after failure.
         // Replace this with more fine-grained retry logic.
         // requestHash.setAtPath([], hash, log);
@@ -271,6 +276,8 @@ export function generateText(
 
     // If no prompt is provided, don't make a request
     if (!prompt) {
+      resultWithLog.set(undefined);
+      partialWithLog.set(undefined);
       pendingWithLog.set(false);
       return;
     }
@@ -338,6 +345,9 @@ export function generateText(
           partial.withTx(tx).set(undefined);
         });
 
+        // Reset previousCallHash to allow retry after error
+        previousCallHash = undefined;
+
         // TODO(seefeld): Not writing now, so we retry the request after failure.
         // Replace this with more fine-grained retry logic.
         // requestHash.setAtPath([], hash, log);
@@ -411,6 +421,8 @@ export function generateObject<T extends Record<string, unknown>>(
       inputsCell.getAsQueryResult([], tx) ?? {};
 
     if (!prompt || !schema) {
+      resultWithLog.set(undefined);
+      partialWithLog.set(undefined);
       pendingWithLog.set(false);
       return;
     }
@@ -476,6 +488,9 @@ export function generateObject<T extends Record<string, unknown>>(
           partial.withTx(tx).set(undefined);
         });
 
+        // Reset previousCallHash to allow retry after error
+        previousCallHash = undefined;
+
         // TODO(seefeld): Not writing now, so we retry the request after failure.
         // Replace this with more fine-grained retry logic.
         // requestHash.setAtPath([], hash, log);