Optionally log the selector in our spans, so we can track down which queries are slow. (#1874)

* Optionally log the selector in our spans, so we can track down which queries are slow.

* Move the selectSchema mesage to the space.querySchema span instead of the space.instance.querySchema.

* Added integration test to check the timing, though this is standalone enough that it could be a unit test.
This data was captured from a real charm with a slow query.

* Remove unused selection tracker for now

Author: ubik2

packages/memory/space-schema.ts

@@ -151,7 +151,6 @@ export class ServerObjectManager extends BaseObjectManager<
 export const selectSchema = <Space extends MemorySpace>(
   session: Session<Space>,
   { selectSchema, since, classification }: SchemaQuery["args"],
-  selectionTracker?: MapSet<string, SchemaPathSelector>,
 ): FactSelection => {
   const startTime = performance.timeOrigin + performance.now();
 
@@ -178,9 +177,6 @@ export const selectSchema = <Space extends MemorySpace>(
     };
     const matchingFacts = getMatchingFacts(session, factSelector);
     for (const entry of matchingFacts) {
-      const factKey = manager.toKey(entry.address);
-      // TODO(@ubik2): need to remove this or schemaTracker
-      selectionTracker?.add(factKey, selectorEntry.value);
       // The top level facts we accessed should be included
       addToSelection(includedFacts, entry, entry.cause, entry.since);
 

packages/memory/space.ts

@@ -887,6 +887,10 @@ export const querySchema = <Space extends MemorySpace>(
 
     if (command.args?.selectSchema) {
       span.setAttribute("querySchema.has_selector", true);
+      span.setAttribute(
+        "querySchema.selectSchema",
+        JSON.stringify(command.args.selectSchema),
+      );
     }
     if (command.args?.since !== undefined) {
       span.setAttribute("querySchema.since", command.args.since);