change refs emission to be for all named non-container types (#1765)

* change refs emission to be for all named non-container types (still do not auto-promote root)

* format

* doc with both short- and long-term strategies for finishing this implementation

* progress towards working implementation, still WIP

* update fixtures to no longer expect root types to always be promoted to named defs (only promote if referenced elsewhere)

* and finish updating js-runtime fixtures' expectations too

* don't include callables/function-like things in json schemas

* update README about skipping callables

* handle anonymous type cycles more properly by synthesizing a name for them AnonymousType_{counter}

* fix linting

* factor out structure for special-casing certain built-in types' schemas

* handle certain built-in types specially

* fix bug i just introduced

* fix built-in type handling

* improve handling of boolean schemas as per robin's PR comment

* fmt

Author: mathpirate

packages/js-runtime/test/fixtures/handler-schema/array-cell-remove-intersection.expected.ts

@@ -7,26 +7,32 @@ interface ListState {
     items: Cell<Item[]>;
 }
 const removeItem = handler({} as const satisfies JSONSchema, {
+    $schema: "https://json-schema.org/draft-07/schema#",
     type: "object",
     properties: {
         items: {
             type: "array",
             items: {
-                type: "object",
-                properties: {
-                    text: {
-                        type: "string"
-                    }
-                },
-                required: ["text"]
+                $ref: "#/definitions/Item"
             },
             asCell: true
         },
         index: {
             type: "number"
         }
     },
-    required: ["items", "index"]
+    required: ["items", "index"],
+    definitions: {
+        Item: {
+            type: "object",
+            properties: {
+                text: {
+                    type: "string"
+                }
+            },
+            required: ["text"]
+        }
+    }
 } as const satisfies JSONSchema, (_, { items, index }) => {
     const next = items.get().slice();
     if (index >= 0 && index < next.length)
@@ -38,26 +44,32 @@ type ListStateWithIndex = ListState & {
     index: number;
 };
 const removeItemAlias = handler({} as const satisfies JSONSchema, {
+    $schema: "https://json-schema.org/draft-07/schema#",
     type: "object",
     properties: {
         items: {
             type: "array",
             items: {
-                type: "object",
-                properties: {
-                    text: {
-                        type: "string"
-                    }
-                },
-                required: ["text"]
+                $ref: "#/definitions/Item"
             },
             asCell: true
         },
         index: {
             type: "number"
         }
     },
-    required: ["items", "index"]
+    required: ["items", "index"],
+    definitions: {
+        Item: {
+            type: "object",
+            properties: {
+                text: {
+                    type: "string"
+                }
+            },
+            required: ["text"]
+        }
+    }
 } as const satisfies JSONSchema, (_, { items, index }) => {
     const next = items.get().slice();
     if (index >= 0 && index < next.length)

packages/js-runtime/test/fixtures/handler-schema/date-and-map-types.expected.ts

@@ -9,117 +9,57 @@ interface TimedState {
     history: Map<string, Date>;
 }
 const timedHandler = handler({
+    $schema: "https://json-schema.org/draft-07/schema#",
     type: "object",
     properties: {
         timestamp: {
             type: "string",
             format: "date-time"
         },
         data: {
+            $ref: "#/definitions/Map"
+        }
+    },
+    required: ["timestamp", "data"],
+    definitions: {
+        Map: {
             type: "object",
             properties: {
-                clear: {
-                    type: "object",
-                    properties: {}
-                },
-                delete: {
-                    type: "object",
-                    properties: {}
-                },
-                forEach: {
-                    type: "object",
-                    properties: {}
-                },
-                get: {
-                    type: "object",
-                    properties: {}
-                },
-                has: {
-                    type: "object",
-                    properties: {}
-                },
-                set: {
-                    type: "object",
-                    properties: {}
-                },
                 size: {
                     type: "number"
-                },
-                entries: {
-                    type: "object",
-                    properties: {}
-                },
-                keys: {
-                    type: "object",
-                    properties: {}
-                },
-                values: {
-                    type: "object",
-                    properties: {}
                 }
             },
-            required: ["clear", "delete", "forEach", "get", "has", "set", "size", "entries", "keys", "values"]
+            required: ["size"]
         }
-    },
-    required: ["timestamp", "data"]
+    }
 } as const satisfies JSONSchema, {
+    $schema: "https://json-schema.org/draft-07/schema#",
     type: "object",
     properties: {
         lastUpdate: {
             type: "string",
             format: "date-time"
         },
         history: {
+            $ref: "#/definitions/Map"
+        }
+    },
+    required: ["lastUpdate", "history"],
+    definitions: {
+        Map: {
             type: "object",
             properties: {
-                clear: {
-                    type: "object",
-                    properties: {}
-                },
-                delete: {
-                    type: "object",
-                    properties: {}
-                },
-                forEach: {
-                    type: "object",
-                    properties: {}
-                },
-                get: {
-                    type: "object",
-                    properties: {}
-                },
-                has: {
-                    type: "object",
-                    properties: {}
-                },
-                set: {
-                    type: "object",
-                    properties: {}
-                },
                 size: {
                     type: "number"
-                },
-                entries: {
-                    type: "object",
-                    properties: {}
-                },
-                keys: {
-                    type: "object",
-                    properties: {}
-                },
-                values: {
-                    type: "object",
-                    properties: {}
                 }
             },
-            required: ["clear", "delete", "forEach", "get", "has", "set", "size", "entries", "keys", "values"]
+            required: ["size"]
         }
-    },
-    required: ["lastUpdate", "history"]
+    }
 } as const satisfies JSONSchema, (event, state) => {
     state.lastUpdate = event.timestamp;
     event.data.forEach((value, key) => {
         state.history.set(key, new Date());
     });
 });
-export { timedHandler };
+export { timedHandler };

packages/js-runtime/test/fixtures/jsx-expressions/jsx-complex-mixed.expected.tsx

@@ -13,27 +13,13 @@ interface State {
     taxRate: number;
 }
 export default recipe({
+    $schema: "https://json-schema.org/draft-07/schema#",
     type: "object",
     properties: {
         items: {
             type: "array",
             items: {
-                type: "object",
-                properties: {
-                    id: {
-                        type: "number"
-                    },
-                    name: {
-                        type: "string"
-                    },
-                    price: {
-                        type: "number"
-                    },
-                    active: {
-                        type: "boolean"
-                    }
-                },
-                required: ["id", "name", "price", "active"]
+                $ref: "#/definitions/Item"
             }
         },
         filter: {
@@ -46,7 +32,27 @@ export default recipe({
             type: "number"
         }
     },
-    required: ["items", "filter", "discount", "taxRate"]
+    required: ["items", "filter", "discount", "taxRate"],
+    definitions: {
+        Item: {
+            type: "object",
+            properties: {
+                id: {
+                    type: "number"
+                },
+                name: {
+                    type: "string"
+                },
+                price: {
+                    type: "number"
+                },
+                active: {
+                    type: "boolean"
+                }
+            },
+            required: ["id", "name", "price", "active"]
+        }
+    }
 } as const satisfies JSONSchema, (state) => {
     return {
         [UI]: (<div>
@@ -84,4 +90,3 @@ export default recipe({
       </div>),
     };
 });
-