Fix/schema traversal mismatch - CT-541 (#1352)

* Fix bug in schema traversal where in some cases we were not returning the value.
* Added test

Author: ubik2

packages/memory/test/space-test.ts

@@ -1,6 +1,6 @@
 import { assert, assertEquals, assertExists, assertMatch } from "@std/assert";
 import { refer } from "merkle-reference";
-import { SchemaContext } from "@commontools/runner";
+import { JSONSchema, SchemaContext } from "@commontools/runner";
 import * as Changes from "../changes.ts";
 import * as Commit from "../commit.ts";
 import * as Fact from "../fact.ts";
@@ -2013,3 +2013,105 @@ test(
     );
   },
 );
+
+test(
+  "returns all entries from charm list",
+  DB,
+  async (session) => {
+    const charmSchema = {
+      type: "object",
+      properties: {
+        ["$NAME"]: { type: "string" },
+        ["$UI"]: { type: "object" },
+      },
+      required: ["$UI", "$NAME"],
+    } as const satisfies JSONSchema;
+
+    const charmListSchema = {
+      type: "array",
+      items: { ...charmSchema, asCell: true },
+    } as const satisfies JSONSchema;
+
+    const c1 = Fact.assert({
+      the,
+      of: doc1,
+      is: {
+        "value": { "$NAME": "test 1", "$UI": { "type": "vnode" } },
+      },
+    });
+
+    const c2 = Fact.assert({
+      the,
+      of: doc2,
+      is: {
+        "value": { "$NAME": "test 2", "$UI": { "type": "vnode" } },
+      },
+    });
+
+    const c_list = Fact.assert({
+      the,
+      of: doc3,
+      is: {
+        "value": [
+          {
+            "space": space.did(),
+            "cell": { "/": doc1.slice(3) },
+            "path": [],
+            "schema": charmSchema,
+          },
+          {
+            "space": space.did(),
+            "cell": { "/": doc2.slice(3) },
+            "path": [],
+            "schema": charmSchema,
+          },
+        ],
+      },
+    });
+
+    const tr1 = Transaction.create({
+      issuer: alice.did(),
+      subject: space.did(),
+      changes: Changes.from([c1, c2, c_list]),
+    });
+    const write1 = await session.transact(tr1);
+    assert(write1.ok);
+
+    const schemaSelector: SchemaSelector = {
+      [doc3]: {
+        [the]: {
+          _: {
+            path: [],
+            schemaContext: {
+              schema: charmListSchema,
+              rootSchema: charmListSchema,
+            },
+          },
+        },
+      },
+    };
+
+    const result = session.querySchema({
+      cmd: "/memory/graph/query",
+      iss: alice.did(),
+      sub: space.did(),
+      args: {
+        selectSchema: schemaSelector,
+      },
+      prf: [],
+    });
+
+    assertExists(
+      getResultForDoc(result, space.did(), doc1),
+      "doc1 should be in the result",
+    );
+    assertExists(
+      getResultForDoc(result, space.did(), doc2),
+      "doc2 should be in the result",
+    );
+    assertExists(
+      getResultForDoc(result, space.did(), doc3),
+      "doc3 should be in the result",
+    );
+  },
+);

packages/runner/src/traverse.ts

@@ -614,7 +614,10 @@ export class SchemaObjectTraverser<K, S> extends BaseObjectTraverser<K, S> {
       if (!deepEqual(nextDoc.path, nextSelector!.path)) {
         throw new Error("New doc path doesn't match selector path");
       }
-      this.traverseWithSchemaContext(nextDoc, nextSelector!.schemaContext!);
+      return this.traverseWithSchemaContext(
+        nextDoc,
+        nextSelector!.schemaContext!,
+      );
     }
   }
 
@@ -664,7 +667,7 @@ export class SchemaObjectTraverser<K, S> extends BaseObjectTraverser<K, S> {
       if (this.isValidType(schemaObj, "array")) {
         if (this.tracker.enter(doc.value)) {
           try {
-            this.traverseArrayWithSchema(doc, {
+            return this.traverseArrayWithSchema(doc, {
               schema: schemaObj,
               rootSchema: schemaContext.rootSchema,
             });
@@ -688,7 +691,7 @@ export class SchemaObjectTraverser<K, S> extends BaseObjectTraverser<K, S> {
       } else if (this.isValidType(schemaObj, "object")) {
         if (this.tracker.enter(doc.value)) {
           try {
-            this.traverseObjectWithSchema(doc, {
+            return this.traverseObjectWithSchema(doc, {
               schema: schemaObj,
               rootSchema: schemaContext.rootSchema,
             });