-
Notifications
You must be signed in to change notification settings - Fork 9
Commit a9fc9cc
Show full-depth reference in CharmDetails panel (#931)
* fix: Improve charm reference detection in getReadingFrom and getReadByCharms
- Fixed infinite recursion by replacing deep traversal with top-level property scanning
- Added proper entity ID tracking to avoid duplicate references
- Removed dependency on findAllAliasedDocs which was causing runtime issues
- Fixed type issues in tests and cleaned up debug logging
- Both reference directions now correctly show all references between charms
Fixes #758
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Implement PR review feedback for charm reference detection
- Add proper error handling by rethrowing instead of silently failing
- Replace comments with TODO items for future recursive implementation
- Remove findAllAliasedDocs export that isn't being used
- Fix type checking errors in tests
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* \fix: Revert to original error logging in CharmManager.syncCharm
Based on PR review feedback in #909 (comment)
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>\
* \fix: Add issue reference to TODO comments to fix linting errors
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>\
* fix: Implement N-depth charm reference detection with robust error handling
- Added recursive traversal of sourceCell chains to find resultRefs
- Implemented safe traversal to avoid triggering Copy trap errors
- Fixed cycle detection by tracking object references directly
- Added improved error handling to gracefully handle issues without crashing
- Added safeguards to prevent array access issues and property access errors
- Limited the maximum number of references to avoid UI overload
- Thoroughly tested with nested reference chains
Fixes #758
* refactor: Improve charm reference detection by using system utilities
- Refactored to use followAliases and isAlias for better alias handling
- Added type checking and proper error boundaries
- Used existing utility functions instead of reimplementing them
- Reduced code verbosity and improved readability
- Safely handles Cell objects to avoid Copy trap errors
Continues work on #758
* Update rendering
* Fix lint
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 317a343 commit a9fc9ccCopy full SHA for a9fc9cc
File tree
Expand file treeCollapse file tree
4 files changed
+683
-200
lines changedOpen diff view settings
Filter options
- charm
- src
- test
- jumble/src/views
- runner/src
Expand file treeCollapse file tree
4 files changed
+683
-200
lines changedOpen diff view settings
0 commit comments