CT-518 add charm on navigateTo in jumble (#1343)

* add the charm to charm manager list when viewed with navigateTo in jumble
* fix issues where compiler.tsx was only working once:

  - we were creating the charm cells improperly (a second charm would share cells with the first due to cause naming) - additionally navigate shouldn't navigate if it returns undefined

Author: anotherjesse

packages/charm/src/manager.ts

@@ -251,7 +251,7 @@ export class CharmManager {
     return this.charms;
   }
 
-  private async add(newCharms: Cell<Charm>[]) {
+  async add(newCharms: Cell<Charm>[]) {
     await this.syncCharms(this.charms);
     await this.runtime.idle();
 

packages/jumble/src/components/CommandCenter.tsx

@@ -436,7 +436,15 @@ export function CommandCenter() {
     };
 
     const handleNavigateToCharm = (event: CustomEvent) => {
-      const { charmId, replicaName } = event.detail || {};
+      const { charmId, charm, replicaName } = event.detail || {};
+
+      // If we have a charm object, ensure it's added to the charm manager
+      if (charm && charmManager) {
+        charmManager.add([charm]).catch((err) => {
+          console.error("Failed to add charm to manager:", err);
+        });
+      }
+
       if (charmId && replicaName) {
         navigate(
           createPath("charmShow", {
@@ -478,7 +486,7 @@ export function CommandCenter() {
         handleNavigateToCharm as EventListener,
       );
     };
-  }, [focusedCharmId, allCommands, navigate, focusedReplicaId]);
+  }, [focusedCharmId, allCommands, navigate, focusedReplicaId, charmManager]);
 
   const handleBack = () => {
     if (commandPathIds.length === 1) {

packages/jumble/src/utils/navigation.ts

@@ -15,7 +15,7 @@ export function navigateToCharm(charm: Cell<any>, replicaName?: string): void {
 
   globalThis.dispatchEvent(
     new CustomEvent("navigate-to-charm", {
-      detail: { charmId: id, replicaName },
+      detail: { charmId: id, charm, replicaName },
     }),
   );
 }

packages/runner/src/builtins/navigate-to.ts

@@ -20,6 +20,8 @@ export function navigateTo(
       throw new Error("navigateCallback is not set");
     }
 
-    runtime.navigateCallback(target);
+    if (target && target.get()) {
+      runtime.navigateCallback(target);
+    }
   };
 }

packages/runner/src/runner.ts

@@ -735,7 +735,7 @@ export class Runner implements IRunner {
       (result: any) =>
         sendValueToBinding(processCell, mappedOutputBindings, result),
       addCancel,
-      inputCells, // cause
+      { inputs: inputsCell, parents: processCell.getDoc() },
       processCell,
       this.runtime,
     );

recipes/compiler.tsx

@@ -55,26 +55,29 @@ const updateCode = handler<{ detail: { value: string } }, { code: string }>(
 
 const visit = handler<
   { detail: { value: string } },
-  { result: { [UI]: any; [NAME]: string } }
+  { code: string }
 >(
   (_, state) => {
-    return navigateTo(state.result);
+    const { result } = compileAndRun({
+      files: [{ name: "/main.tsx", contents: state.code }],
+      main: "/main.tsx",
+    });
+
+    console.log("result", result);
+
+    return navigateTo(result);
   },
 );
 
 export default recipe(
   InputSchema,
   OutputSchema,
   ({ code }) => {
-    const { result, error, errors } = compileAndRun({
+    const { error, errors } = compileAndRun({
       files: [{ name: "/main.tsx", contents: code }],
       main: "/main.tsx",
     });
 
-    derive(result, (result) => {
-      console.log("result", result);
-    });
-
     return {
       [NAME]: "My First Compiler",
       [UI]: (
@@ -87,9 +90,9 @@ export default recipe(
           />
           {ifElse(
             error,
-            <pre>{error}</pre>,
+            <b>fix the errors</b>,
             <common-button
-              onClick={visit({ result })}
+              onClick={visit({ code })}
             >
               Navigate To Charm
             </common-button>,