replace .all() with .iter(), hoping this helps with memory blowup

Author: ellyxir

packages/memory/space-schema.ts

@@ -348,18 +348,16 @@ function addToSelection(
 }
 
 // Get the ValueEntry objects for the facts that match our selector
-function getMatchingFacts<Space extends MemorySpace>(
+function* getMatchingFacts<Space extends MemorySpace>(
   session: SpaceStoreSession<Space>,
   factSelector: FactSelector,
 ): Iterable<IAttestation & { cause: CauseString; since: number }> {
-  const results = [];
   for (const fact of selectFacts(session, factSelector)) {
-    results.push({
+    yield {
       value: fact.is,
       address: { id: fact.of, type: fact.the, path: [] },
       cause: fact.cause,
       since: fact.since,
-    });
+    };
   }
-  return results;
 }

packages/memory/space.ts

@@ -570,15 +570,16 @@ export const selectFacts = function* <Space extends MemorySpace>(
   { store }: Session<Space>,
   { the, of, cause, is, since }: FactSelector,
 ): Iterable<SelectedFact> {
-  const rows = store.prepare(EXPORT).all({
-    the: the === SelectAllString ? null : the,
-    of: of === SelectAllString ? null : of,
-    cause: cause === SelectAllString ? null : cause,
-    is: is === undefined ? null : {},
-    since: since ?? null,
-  }) as StateRow[];
-
-  for (const row of rows) {
+  const stmt = store.prepare(EXPORT);
+  for (
+    const row of stmt.iter({
+      the: the === SelectAllString ? null : the,
+      of: of === SelectAllString ? null : of,
+      cause: cause === SelectAllString ? null : cause,
+      is: is === undefined ? null : {},
+      since: since ?? null,
+    }) as Iterable<StateRow>
+  ) {
     yield toFact(row);
   }
 };
@@ -587,14 +588,19 @@ export const selectFact = function <Space extends MemorySpace>(
   { store }: Session<Space>,
   { the, of, since }: { the: MIME; of: URI; since?: number },
 ): SelectedFact | undefined {
-  const rows = store.prepare(EXPORT).all({
-    the: the,
-    of: of,
-    cause: null,
-    is: null,
-    since: since ?? null,
-  }) as StateRow[];
-  return (rows.length > 0) ? toFact(rows[0]) : undefined;
+  const stmt = store.prepare(EXPORT);
+  for (
+    const row of stmt.iter({
+      the: the,
+      of: of,
+      cause: null,
+      is: null,
+      since: since ?? null,
+    }) as Iterable<StateRow>
+  ) {
+    return toFact(row);
+  }
+  return undefined;
 };
 
 /**