fix: failing test

Author: Gozala

typescript/packages/common-charm/src/storage.ts

@@ -239,6 +239,7 @@ class StorageImpl implements Storage {
   // TODO(seefeld,gozala): Should just be one again.
   private _getStorageProviderForSpace(space: Space): StorageProvider {
     if (!space) throw new Error("No space set");
+    if (!this.signer) throw new Error("No signer set");
 
     let provider = this.storageProviders.get(space);
 

typescript/packages/common-charm/src/storage/remote.ts

@@ -3,7 +3,6 @@ import { log } from "../storage.ts";
 import { type StorageProvider, type StorageValue } from "./base.ts";
 import type { Entity, JSONValue, MemorySpace, Protocol } from "@commontools/memory/interface";
 import * as Memory from "@commontools/memory/consumer";
-import { Identity } from "@commontools/identity";
 import { assert } from "@commontools/memory/fact";
 import * as Changes from "@commontools/memory/changes";
 export * from "@commontools/memory/interface";

typescript/packages/common-charm/test/storage.test.ts

@@ -4,8 +4,10 @@ import { storage } from "../src/storage.ts";
 import { StorageProvider } from "../src/storage/base.ts";
 import { InMemoryStorageProvider } from "../src/storage/memory.ts";
 import { createRef, DocImpl, getDoc, getSpace } from "@commontools/runner";
+import { Identity } from "@commontools/identity";
 
 storage.setRemoteStorage(new URL("memory://"));
+storage.setSigner(await Identity.fromPassphrase("test operator"));
 
 describe("Storage", () => {
   let storage2: StorageProvider;

typescript/packages/common-identity/src/pass-key.ts

@@ -2,9 +2,9 @@ import { Identity } from "./identity.ts";
 import { bufferSourceToArrayBuffer, random } from "./utils.ts";
 
 const RP = "Common Tools";
-const RP_ID = new URL(window.location.href).host;
 const PRF_SALT = new TextEncoder().encode("PRF_SALT");
 const TIMEOUT = 60_000;
+const RP_ID = () => new URL(window.location.href).host;
 
 // These are algorithms to use, in order of preference.
 // We prefer ED25519 for security and size, though support
@@ -85,7 +85,7 @@ export class PassKey {
 
     let publicKey: PublicKeyCredentialCreationOptions = {
       challenge,
-      rp: { id: RP_ID, name: RP },
+      rp: { id: RP_ID(), name: RP },
       user,
       attestation: "none", // default
       authenticatorSelection: {
@@ -131,7 +131,7 @@ export class PassKey {
       publicKey: {
         allowCredentials,
         challenge: random(32),
-        rpId: RP_ID,
+        rpId: RP_ID(),
         userVerification: userVerification ?? "preferred",
         extensions: { prf: { eval: { first: PRF_SALT } } },
         timeout: TIMEOUT,

typescript/packages/common-identity/src/utils.ts

@@ -26,7 +26,7 @@ export function once(
 const HASH_ALG = "SHA-256";
 // Hash input via SHA-256.
 export async function hash(input: Uint8Array): Promise<Uint8Array> {
-  return new Uint8Array(await window.crypto.subtle.digest(HASH_ALG, input));
+  return new Uint8Array(await globalThis.crypto.subtle.digest(HASH_ALG, input));
 }
 
 // Clones object using Structured Clone Algorithm.